diff mbox series

ACPI: video: Fix Lenovo Ideapad Z570 DMI match

Message ID 20230202124449.427651-1-hdegoede@redhat.com
State Accepted
Commit 2d11eae42d52a131f06061015e49dc0f085c5bfc
Headers show
Series ACPI: video: Fix Lenovo Ideapad Z570 DMI match | expand

Commit Message

Hans de Goede Feb. 2, 2023, 12:44 p.m. UTC
Multiple Ideapad Z570 variants need acpi_backlight=native to force native
use on these pre Windows 8 machines since acpi_video backlight control
does not work here.

The original DMI quirk matches on a product_name of "102434U" but other
variants may have different product_name-s such as e.g. "1024D9U".

Move to checking product_version instead as is more or less standard for
Lenovo DMI quirks for similar reasons.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 drivers/acpi/video_detect.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Rafael J. Wysocki Feb. 6, 2023, 6 p.m. UTC | #1
On Thu, Feb 2, 2023 at 1:44 PM Hans de Goede <hdegoede@redhat.com> wrote:
>
> Multiple Ideapad Z570 variants need acpi_backlight=native to force native
> use on these pre Windows 8 machines since acpi_video backlight control
> does not work here.
>
> The original DMI quirk matches on a product_name of "102434U" but other
> variants may have different product_name-s such as e.g. "1024D9U".
>
> Move to checking product_version instead as is more or less standard for
> Lenovo DMI quirks for similar reasons.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
>  drivers/acpi/video_detect.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/video_detect.c b/drivers/acpi/video_detect.c
> index a8c02608dde4..710ac640267d 100644
> --- a/drivers/acpi/video_detect.c
> +++ b/drivers/acpi/video_detect.c
> @@ -434,7 +434,7 @@ static const struct dmi_system_id video_detect_dmi_table[] = {
>          /* Lenovo Ideapad Z570 */
>          .matches = {
>                 DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> -               DMI_MATCH(DMI_PRODUCT_NAME, "102434U"),
> +               DMI_MATCH(DMI_PRODUCT_VERSION, "Ideapad Z570"),
>                 },
>         },
>         {
> --

Applied as 6.3 material, thanks!
diff mbox series

Patch

diff --git a/drivers/acpi/video_detect.c b/drivers/acpi/video_detect.c
index a8c02608dde4..710ac640267d 100644
--- a/drivers/acpi/video_detect.c
+++ b/drivers/acpi/video_detect.c
@@ -434,7 +434,7 @@  static const struct dmi_system_id video_detect_dmi_table[] = {
 	 /* Lenovo Ideapad Z570 */
 	 .matches = {
 		DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
-		DMI_MATCH(DMI_PRODUCT_NAME, "102434U"),
+		DMI_MATCH(DMI_PRODUCT_VERSION, "Ideapad Z570"),
 		},
 	},
 	{