Message ID | 20230210170044.11835-1-kaehndan@gmail.com |
---|---|
State | Accepted |
Commit | 37f5b858a66543b2b67c0288280af623985abc29 |
Headers | show |
Series | HID: cp2112: Fix driver not registering GPIO IRQ chip as threaded | expand |
diff --git a/drivers/hid/hid-cp2112.c b/drivers/hid/hid-cp2112.c index 1e16b0fa310d..27cadadda7c9 100644 --- a/drivers/hid/hid-cp2112.c +++ b/drivers/hid/hid-cp2112.c @@ -1354,6 +1354,7 @@ static int cp2112_probe(struct hid_device *hdev, const struct hid_device_id *id) girq->parents = NULL; girq->default_type = IRQ_TYPE_NONE; girq->handler = handle_simple_irq; + girq->threaded = true; ret = gpiochip_add_data(&dev->gc, dev); if (ret < 0) {
The CP2112 generates interrupts from a polling routine on a thread, and can only support threaded interrupts. This patch configures the gpiochip irq chip with this flag, disallowing consumers to request a hard IRQ from this driver, which resulted in a segfault previously. Signed-off-by: Danny Kaehn <kaehndan@gmail.com> --- Note -- this patch was first submitted with the patchset: "DeviceTree Support for USB-HID Devices and CP2112" It is now submitted separately upon request, as it is not coupled to the other patches in that series. drivers/hid/hid-cp2112.c | 1 + 1 file changed, 1 insertion(+)