| Message ID | 20230202-asahi-t8112-dt-v1-2-cb5442d1c229@jannau.net |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Device trees for Apple M2 (t8112) based devices | expand |
On 12/02/2023 16:41, Janne Grunau wrote: > The block on Apple M2 SoCs is compatible with the existing driver so > just add its per-SoC compatible. > > Signed-off-by: Janne Grunau <j@jannau.net> > > --- > This trivial dt-bindings update should be merged through the asahi-soc > tree to ensure validation of the Apple M2 (t8112) devicetrees in this > series. No, the bindings go via subsystem. Just because you want to validate something is not really a reason - you can validate on next. Don't create special rules for Asahi... or rather - why Asahi is special than everyone else? > --- > Documentation/devicetree/bindings/arm/apple/apple,pmgr.yaml | 1 + > 1 file changed, 1 insertion(+) Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On 2023-02-13 12:10:36 +0100, Krzysztof Kozlowski wrote: > On 12/02/2023 16:41, Janne Grunau wrote: > > The block on Apple M2 SoCs is compatible with the existing driver so > > just add its per-SoC compatible. > > > > Signed-off-by: Janne Grunau <j@jannau.net> > > > > --- > > This trivial dt-bindings update should be merged through the asahi-soc > > tree to ensure validation of the Apple M2 (t8112) devicetrees in this > > series. > > No, the bindings go via subsystem. Just because you want to validate > something is not really a reason - you can validate on next. Don't > create special rules for Asahi... or rather - why Asahi is special than > everyone else? We did that 2 or 3 times in the past without commnts that it is not desired so I wasn't aware that this would be special handling. Merging binding and devicetree updates together looks to me like the most sensible option since dtbs validation is the only testable dependecy of dt binding updates. Keeping them together ensures the dtbs validate without delaying devicetree changes by one kernel release after the dt-bindings change was merged. I suppose it works out most of the time if the merge request is sent only if it validates in next. That still depends on the merge order in the merge window but -rc1 should be fine. I'll consider devicetree validation as eventually valid from now on and not care too much about it. Janne
diff --git a/Documentation/devicetree/bindings/arm/apple/apple,pmgr.yaml b/Documentation/devicetree/bindings/arm/apple/apple,pmgr.yaml index 0dc957a56d35..673277a7a224 100644 --- a/Documentation/devicetree/bindings/arm/apple/apple,pmgr.yaml +++ b/Documentation/devicetree/bindings/arm/apple/apple,pmgr.yaml @@ -23,6 +23,7 @@ properties: items: - enum: - apple,t8103-pmgr + - apple,t8112-pmgr - apple,t6000-pmgr - const: apple,pmgr - const: syscon
The block on Apple M2 SoCs is compatible with the existing driver so just add its per-SoC compatible. Signed-off-by: Janne Grunau <j@jannau.net> --- This trivial dt-bindings update should be merged through the asahi-soc tree to ensure validation of the Apple M2 (t8112) devicetrees in this series. --- Documentation/devicetree/bindings/arm/apple/apple,pmgr.yaml | 1 + 1 file changed, 1 insertion(+)