| Message ID | 1460055213-29479-3-git-send-email-zoltan.kiss@linaro.org |
|---|---|
| State | Accepted |
| Commit | bbf89669df69c460d18dc672e628d8d17299e2f7 |
| Headers | show |
For this patch alone: Reviewed-by: Balasubramanian Manoharan <bala.manoharan@linaro.org> On 8 April 2016 at 00:23, Zoltan Kiss <zoltan.kiss@linaro.org> wrote: > This function is not referred. > > Signed-off-by: Zoltan Kiss <zoltan.kiss@linaro.org> > --- > platform/linux-generic/include/odp_classification_internal.h | 9 > ++------- > platform/linux-generic/odp_classification.c | 10 > ---------- > 2 files changed, 2 insertions(+), 17 deletions(-) > > diff --git a/platform/linux-generic/include/odp_classification_internal.h > b/platform/linux-generic/include/odp_classification_internal.h > index 86b40fc..3a88462 100644 > --- a/platform/linux-generic/include/odp_classification_internal.h > +++ b/platform/linux-generic/include/odp_classification_internal.h > @@ -54,6 +54,8 @@ based on the l3_preference value of the pktio > cos_t *match_qos_cos(pktio_entry_t *entry, const uint8_t *pkt_addr, > odp_packet_hdr_t *hdr); > /** > +@internal > + > Packet Classifier > > Start function for Packet Classifier > @@ -61,13 +63,6 @@ This function calls Classifier module internal > functions for a given packet and > enqueues the packet to specific Queue based on PMR and CoS selected. > The packet is allocated from the pool associated with the CoS > **/ > -int packet_classifier(odp_pktio_t pktio, odp_packet_t pkt); > - > -/** > -@internal > - > -Same as packet classifier uses linux-generic internal pktio struct > -**/ > int _odp_packet_classifier(pktio_entry_t *entry, odp_packet_t pkt); > > /** > diff --git a/platform/linux-generic/odp_classification.c > b/platform/linux-generic/odp_classification.c > index 4f2974b..2ad190b 100644 > --- a/platform/linux-generic/odp_classification.c > +++ b/platform/linux-generic/odp_classification.c > @@ -774,16 +774,6 @@ int _odp_packet_classifier(pktio_entry_t *entry, > odp_packet_t pkt) > } > } > > -int packet_classifier(odp_pktio_t pktio, odp_packet_t pkt) > -{ > - pktio_entry_t *entry; > - > - entry = get_pktio_entry(pktio); > - if (entry == NULL) > - return -1; > - return _odp_packet_classifier(entry, pkt); > -} > - > cos_t *pktio_select_cos(pktio_entry_t *entry, const uint8_t *pkt_addr, > odp_packet_hdr_t *pkt_hdr) > { > -- > 1.9.1 > >
On 04/11/16 07:02, Bala Manoharan wrote: > For this patch alone: > Reviewed-by: Balasubramanian Manoharan <bala.manoharan@linaro.org > <mailto:bala.manoharan@linaro.org>> > merged this 2/2 patch, Maxim. > > On 8 April 2016 at 00:23, Zoltan Kiss <zoltan.kiss@linaro.org > <mailto:zoltan.kiss@linaro.org>> wrote: > > This function is not referred. > > Signed-off-by: Zoltan Kiss <zoltan.kiss@linaro.org > <mailto:zoltan.kiss@linaro.org>> > --- > platform/linux-generic/include/odp_classification_internal.h | 9 > ++------- > platform/linux-generic/odp_classification.c | 10 ---------- > 2 files changed, 2 insertions(+), 17 deletions(-) > > diff --git > a/platform/linux-generic/include/odp_classification_internal.h > b/platform/linux-generic/include/odp_classification_internal.h > index 86b40fc..3a88462 100644 > --- a/platform/linux-generic/include/odp_classification_internal.h > +++ b/platform/linux-generic/include/odp_classification_internal.h > @@ -54,6 +54,8 @@ based on the l3_preference value of the pktio > cos_t *match_qos_cos(pktio_entry_t *entry, const uint8_t *pkt_addr, > odp_packet_hdr_t *hdr); > /** > +@internal > + > Packet Classifier > > Start function for Packet Classifier > @@ -61,13 +63,6 @@ This function calls Classifier module internal > functions for a given packet and > enqueues the packet to specific Queue based on PMR and CoS selected. > The packet is allocated from the pool associated with the CoS > **/ > -int packet_classifier(odp_pktio_t pktio, odp_packet_t pkt); > - > -/** > -@internal > - > -Same as packet classifier uses linux-generic internal pktio struct > -**/ > int _odp_packet_classifier(pktio_entry_t *entry, odp_packet_t pkt); > > /** > diff --git a/platform/linux-generic/odp_classification.c > b/platform/linux-generic/odp_classification.c > index 4f2974b..2ad190b 100644 > --- a/platform/linux-generic/odp_classification.c > +++ b/platform/linux-generic/odp_classification.c > @@ -774,16 +774,6 @@ int _odp_packet_classifier(pktio_entry_t > *entry, odp_packet_t pkt) > } > } > > -int packet_classifier(odp_pktio_t pktio, odp_packet_t pkt) > -{ > - pktio_entry_t *entry; > - > - entry = get_pktio_entry(pktio); > - if (entry == NULL) > - return -1; > - return _odp_packet_classifier(entry, pkt); > -} > - > cos_t *pktio_select_cos(pktio_entry_t *entry, const uint8_t > *pkt_addr, > odp_packet_hdr_t *pkt_hdr) > { > -- > 1.9.1 > >
diff --git a/platform/linux-generic/include/odp_classification_internal.h b/platform/linux-generic/include/odp_classification_internal.h index 86b40fc..3a88462 100644 --- a/platform/linux-generic/include/odp_classification_internal.h +++ b/platform/linux-generic/include/odp_classification_internal.h @@ -54,6 +54,8 @@ based on the l3_preference value of the pktio cos_t *match_qos_cos(pktio_entry_t *entry, const uint8_t *pkt_addr, odp_packet_hdr_t *hdr); /** +@internal + Packet Classifier Start function for Packet Classifier @@ -61,13 +63,6 @@ This function calls Classifier module internal functions for a given packet and enqueues the packet to specific Queue based on PMR and CoS selected. The packet is allocated from the pool associated with the CoS **/ -int packet_classifier(odp_pktio_t pktio, odp_packet_t pkt); - -/** -@internal - -Same as packet classifier uses linux-generic internal pktio struct -**/ int _odp_packet_classifier(pktio_entry_t *entry, odp_packet_t pkt); /** diff --git a/platform/linux-generic/odp_classification.c b/platform/linux-generic/odp_classification.c index 4f2974b..2ad190b 100644 --- a/platform/linux-generic/odp_classification.c +++ b/platform/linux-generic/odp_classification.c @@ -774,16 +774,6 @@ int _odp_packet_classifier(pktio_entry_t *entry, odp_packet_t pkt) } } -int packet_classifier(odp_pktio_t pktio, odp_packet_t pkt) -{ - pktio_entry_t *entry; - - entry = get_pktio_entry(pktio); - if (entry == NULL) - return -1; - return _odp_packet_classifier(entry, pkt); -} - cos_t *pktio_select_cos(pktio_entry_t *entry, const uint8_t *pkt_addr, odp_packet_hdr_t *pkt_hdr) {
This function is not referred. Signed-off-by: Zoltan Kiss <zoltan.kiss@linaro.org> --- platform/linux-generic/include/odp_classification_internal.h | 9 ++------- platform/linux-generic/odp_classification.c | 10 ---------- 2 files changed, 2 insertions(+), 17 deletions(-)