| Message ID | 20230215192530.299263-5-alex.bennee@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | testing/next: docker, avocado, unit, | expand |
On 15/2/23 20:25, Alex Bennée wrote: > When we re-factored we dropped the unlink() step which turns out to be > required for rmdir to do its thing. If we had been checking the return > value we would have noticed so lets do that with this fix. > > Fixes: 68406d1085 (tests/unit: cleanups for test-io-channel-command) > Signed-off-by: Alex Bennée <alex.bennee@linaro.org> > Suggested-by: Philippe Mathieu-Daudé <philmd@linaro.org> > --- > tests/unit/test-io-channel-command.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
On 2/15/23 09:25, Alex Bennée wrote: > When we re-factored we dropped the unlink() step which turns out to be > required for rmdir to do its thing. If we had been checking the return > value we would have noticed so lets do that with this fix. > > Fixes: 68406d1085 (tests/unit: cleanups for test-io-channel-command) > Signed-off-by: Alex Bennée<alex.bennee@linaro.org> > Suggested-by: Philippe Mathieu-Daudé<philmd@linaro.org> > --- > tests/unit/test-io-channel-command.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~
On 15/02/2023 20.25, Alex Bennée wrote: > When we re-factored we dropped the unlink() step which turns out to be > required for rmdir to do its thing. If we had been checking the return > value we would have noticed so lets do that with this fix. > > Fixes: 68406d1085 (tests/unit: cleanups for test-io-channel-command) > Signed-off-by: Alex Bennée <alex.bennee@linaro.org> > Suggested-by: Philippe Mathieu-Daudé <philmd@linaro.org> > --- > tests/unit/test-io-channel-command.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) Reviewed-by: Thomas Huth <thuth@redhat.com>
diff --git a/tests/unit/test-io-channel-command.c b/tests/unit/test-io-channel-command.c index f3c34152ac..70e82e0e12 100644 --- a/tests/unit/test-io-channel-command.c +++ b/tests/unit/test-io-channel-command.c @@ -42,6 +42,7 @@ static void test_io_channel_command_fifo(bool async) g_auto(GStrv) dstargv = g_strsplit(dstargs, " ", -1); QIOChannel *src, *dst; QIOChannelTest *test; + int err; if (mkfifo(fifo, 0600)) { g_error("mkfifo: %s", strerror(errno)); @@ -61,7 +62,10 @@ static void test_io_channel_command_fifo(bool async) object_unref(OBJECT(src)); object_unref(OBJECT(dst)); - g_rmdir(tmpdir); + err = g_unlink(fifo); + g_assert(err == 0); + err = g_rmdir(tmpdir); + g_assert(err == 0); } static void test_io_channel_command_fifo_async(void)
When we re-factored we dropped the unlink() step which turns out to be required for rmdir to do its thing. If we had been checking the return value we would have noticed so lets do that with this fix. Fixes: 68406d1085 (tests/unit: cleanups for test-io-channel-command) Signed-off-by: Alex Bennée <alex.bennee@linaro.org> Suggested-by: Philippe Mathieu-Daudé <philmd@linaro.org> --- tests/unit/test-io-channel-command.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)