| Message ID | 20230216201259.405939-1-hussein@unixcat.org |
|---|---|
| State | New |
| Headers | show |
| Series | Add error checking to sysfs_update_group in drivers/scsi/scsi_transport_spi.c | expand |
diff --git a/drivers/scsi/scsi_transport_spi.c b/drivers/scsi/scsi_transport_spi.c index 2442d4d2e3f3..f905b4787a42 100644 --- a/drivers/scsi/scsi_transport_spi.c +++ b/drivers/scsi/scsi_transport_spi.c @@ -1559,8 +1559,9 @@ static int spi_target_configure(struct transport_container *tc, { struct kobject *kobj = &cdev->kobj; - /* force an update based on parameters read from the device */ - sysfs_update_group(kobj, &target_attribute_group); + /* force an update based on parameters read from the device, log an error on failure */ + if (sysfs_update_group(kobj, &target_attribute_group)) + pr_err("Unable to update sysfs entries\n"); return 0; }
An instance of sysfs_update_group now checks the result and on error, logs it via pr_err(). Signed-off-by: Nur Hussein <hussein@unixcat.org> --- drivers/scsi/scsi_transport_spi.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)