| Message ID | 20230219185401.10479-1-rdunlap@infradead.org |
|---|---|
| State | New |
| Headers | show |
| Series | drm/msm: fix new Konfig dependency warning | expand |
On Sun, Feb 19, 2023 at 10:54 AM Randy Dunlap <rdunlap@infradead.org> wrote: > > DEVFREQ_GOV_SIMPLE_ONDEMAND depends on PM_DEVFREQ, so in order to > select the former safely, this symbol should also depend on > PM_DEVFREQ to avoid a Kconfig dependency warning. > > WARNING: unmet direct dependencies detected for DEVFREQ_GOV_SIMPLE_ONDEMAND > Depends on [n]: PM_DEVFREQ [=n] > Selected by [m]: > - DRM_MSM [=m] && HAS_IOMEM [=y] && DRM [=m] && (ARCH_QCOM || SOC_IMX5 || COMPILE_TEST [=y]) && COMMON_CLK [=y] && IOMMU_SUPPORT [=y] && (QCOM_OCMEM [=n] || QCOM_OCMEM [=n]=n) && (QCOM_LLCC [=y] || QCOM_LLCC [=y]=n) && (QCOM_COMMAND_DB [=n] || QCOM_COMMAND_DB [=n]=n) > Actually, I fixed devfreq[1] so that we no longer depend on DEVFREQ_GOV_SIMPLE_ONDEMAND .. probably we should just drop DEVFREQ_GOV_SIMPLE_ONDEMAND from the kconfig instead, sorry I forgot to do that already BR, -R [1] https://patchwork.freedesktop.org/series/113232/ > Fixes: 6563f60f14cb ("drm/msm/gpu: Add devfreq tuning debugfs") > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Cc: Rob Clark <robdclark@gmail.com> > Cc: Abhinav Kumar <quic_abhinavk@quicinc.com> > Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > Cc: Sean Paul <sean@poorly.run> > Cc: David Airlie <airlied@gmail.com> > Cc: Daniel Vetter <daniel@ffwll.ch> > Cc: linux-arm-msm@vger.kernel.org > Cc: dri-devel@lists.freedesktop.org > Cc: freedreno@lists.freedesktop.org > --- > drivers/gpu/drm/msm/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff -- a/drivers/gpu/drm/msm/Kconfig b/drivers/gpu/drm/msm/Kconfig > --- a/drivers/gpu/drm/msm/Kconfig > +++ b/drivers/gpu/drm/msm/Kconfig > @@ -9,6 +9,7 @@ config DRM_MSM > depends on QCOM_OCMEM || QCOM_OCMEM=n > depends on QCOM_LLCC || QCOM_LLCC=n > depends on QCOM_COMMAND_DB || QCOM_COMMAND_DB=n > + depends on PM_DEVFREQ > select IOMMU_IO_PGTABLE > select QCOM_MDT_LOADER if ARCH_QCOM > select REGULATOR
On 2/19/23 15:09, Rob Clark wrote: > On Sun, Feb 19, 2023 at 10:54 AM Randy Dunlap <rdunlap@infradead.org> wrote: >> >> DEVFREQ_GOV_SIMPLE_ONDEMAND depends on PM_DEVFREQ, so in order to >> select the former safely, this symbol should also depend on >> PM_DEVFREQ to avoid a Kconfig dependency warning. >> >> WARNING: unmet direct dependencies detected for DEVFREQ_GOV_SIMPLE_ONDEMAND >> Depends on [n]: PM_DEVFREQ [=n] >> Selected by [m]: >> - DRM_MSM [=m] && HAS_IOMEM [=y] && DRM [=m] && (ARCH_QCOM || SOC_IMX5 || COMPILE_TEST [=y]) && COMMON_CLK [=y] && IOMMU_SUPPORT [=y] && (QCOM_OCMEM [=n] || QCOM_OCMEM [=n]=n) && (QCOM_LLCC [=y] || QCOM_LLCC [=y]=n) && (QCOM_COMMAND_DB [=n] || QCOM_COMMAND_DB [=n]=n) >> > > Actually, I fixed devfreq[1] so that we no longer depend on > DEVFREQ_GOV_SIMPLE_ONDEMAND .. probably we should just drop > DEVFREQ_GOV_SIMPLE_ONDEMAND from the kconfig instead, sorry I forgot > to do that already OK, I'll resend the patch with that change, unless you want to handle it... Thanks. > BR, > -R > > [1] https://patchwork.freedesktop.org/series/113232/ > >> Fixes: 6563f60f14cb ("drm/msm/gpu: Add devfreq tuning debugfs") >> Signed-off-by: Randy Dunlap <rdunlap@infradead.org> >> Cc: Rob Clark <robdclark@gmail.com> >> Cc: Abhinav Kumar <quic_abhinavk@quicinc.com> >> Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> >> Cc: Sean Paul <sean@poorly.run> >> Cc: David Airlie <airlied@gmail.com> >> Cc: Daniel Vetter <daniel@ffwll.ch> >> Cc: linux-arm-msm@vger.kernel.org >> Cc: dri-devel@lists.freedesktop.org >> Cc: freedreno@lists.freedesktop.org >> --- >> drivers/gpu/drm/msm/Kconfig | 1 + >> 1 file changed, 1 insertion(+) >> >> diff -- a/drivers/gpu/drm/msm/Kconfig b/drivers/gpu/drm/msm/Kconfig >> --- a/drivers/gpu/drm/msm/Kconfig >> +++ b/drivers/gpu/drm/msm/Kconfig >> @@ -9,6 +9,7 @@ config DRM_MSM >> depends on QCOM_OCMEM || QCOM_OCMEM=n >> depends on QCOM_LLCC || QCOM_LLCC=n >> depends on QCOM_COMMAND_DB || QCOM_COMMAND_DB=n >> + depends on PM_DEVFREQ >> select IOMMU_IO_PGTABLE >> select QCOM_MDT_LOADER if ARCH_QCOM >> select REGULATOR
On Sun, Feb 19, 2023 at 3:12 PM Randy Dunlap <rdunlap@infradead.org> wrote: > > > > On 2/19/23 15:09, Rob Clark wrote: > > On Sun, Feb 19, 2023 at 10:54 AM Randy Dunlap <rdunlap@infradead.org> wrote: > >> > >> DEVFREQ_GOV_SIMPLE_ONDEMAND depends on PM_DEVFREQ, so in order to > >> select the former safely, this symbol should also depend on > >> PM_DEVFREQ to avoid a Kconfig dependency warning. > >> > >> WARNING: unmet direct dependencies detected for DEVFREQ_GOV_SIMPLE_ONDEMAND > >> Depends on [n]: PM_DEVFREQ [=n] > >> Selected by [m]: > >> - DRM_MSM [=m] && HAS_IOMEM [=y] && DRM [=m] && (ARCH_QCOM || SOC_IMX5 || COMPILE_TEST [=y]) && COMMON_CLK [=y] && IOMMU_SUPPORT [=y] && (QCOM_OCMEM [=n] || QCOM_OCMEM [=n]=n) && (QCOM_LLCC [=y] || QCOM_LLCC [=y]=n) && (QCOM_COMMAND_DB [=n] || QCOM_COMMAND_DB [=n]=n) > >> > > > > Actually, I fixed devfreq[1] so that we no longer depend on > > DEVFREQ_GOV_SIMPLE_ONDEMAND .. probably we should just drop > > DEVFREQ_GOV_SIMPLE_ONDEMAND from the kconfig instead, sorry I forgot > > to do that already > > OK, I'll resend the patch with that change, unless you want to handle it... Go for it, thx BR, -R > Thanks. > > > BR, > > -R > > > > [1] https://patchwork.freedesktop.org/series/113232/ > > > >> Fixes: 6563f60f14cb ("drm/msm/gpu: Add devfreq tuning debugfs") > >> Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > >> Cc: Rob Clark <robdclark@gmail.com> > >> Cc: Abhinav Kumar <quic_abhinavk@quicinc.com> > >> Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > >> Cc: Sean Paul <sean@poorly.run> > >> Cc: David Airlie <airlied@gmail.com> > >> Cc: Daniel Vetter <daniel@ffwll.ch> > >> Cc: linux-arm-msm@vger.kernel.org > >> Cc: dri-devel@lists.freedesktop.org > >> Cc: freedreno@lists.freedesktop.org > >> --- > >> drivers/gpu/drm/msm/Kconfig | 1 + > >> 1 file changed, 1 insertion(+) > >> > >> diff -- a/drivers/gpu/drm/msm/Kconfig b/drivers/gpu/drm/msm/Kconfig > >> --- a/drivers/gpu/drm/msm/Kconfig > >> +++ b/drivers/gpu/drm/msm/Kconfig > >> @@ -9,6 +9,7 @@ config DRM_MSM > >> depends on QCOM_OCMEM || QCOM_OCMEM=n > >> depends on QCOM_LLCC || QCOM_LLCC=n > >> depends on QCOM_COMMAND_DB || QCOM_COMMAND_DB=n > >> + depends on PM_DEVFREQ > >> select IOMMU_IO_PGTABLE > >> select QCOM_MDT_LOADER if ARCH_QCOM > >> select REGULATOR > > -- > ~Randy
diff -- a/drivers/gpu/drm/msm/Kconfig b/drivers/gpu/drm/msm/Kconfig --- a/drivers/gpu/drm/msm/Kconfig +++ b/drivers/gpu/drm/msm/Kconfig @@ -9,6 +9,7 @@ config DRM_MSM depends on QCOM_OCMEM || QCOM_OCMEM=n depends on QCOM_LLCC || QCOM_LLCC=n depends on QCOM_COMMAND_DB || QCOM_COMMAND_DB=n + depends on PM_DEVFREQ select IOMMU_IO_PGTABLE select QCOM_MDT_LOADER if ARCH_QCOM select REGULATOR
DEVFREQ_GOV_SIMPLE_ONDEMAND depends on PM_DEVFREQ, so in order to select the former safely, this symbol should also depend on PM_DEVFREQ to avoid a Kconfig dependency warning. WARNING: unmet direct dependencies detected for DEVFREQ_GOV_SIMPLE_ONDEMAND Depends on [n]: PM_DEVFREQ [=n] Selected by [m]: - DRM_MSM [=m] && HAS_IOMEM [=y] && DRM [=m] && (ARCH_QCOM || SOC_IMX5 || COMPILE_TEST [=y]) && COMMON_CLK [=y] && IOMMU_SUPPORT [=y] && (QCOM_OCMEM [=n] || QCOM_OCMEM [=n]=n) && (QCOM_LLCC [=y] || QCOM_LLCC [=y]=n) && (QCOM_COMMAND_DB [=n] || QCOM_COMMAND_DB [=n]=n) Fixes: 6563f60f14cb ("drm/msm/gpu: Add devfreq tuning debugfs") Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Cc: Rob Clark <robdclark@gmail.com> Cc: Abhinav Kumar <quic_abhinavk@quicinc.com> Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Cc: Sean Paul <sean@poorly.run> Cc: David Airlie <airlied@gmail.com> Cc: Daniel Vetter <daniel@ffwll.ch> Cc: linux-arm-msm@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Cc: freedreno@lists.freedesktop.org --- drivers/gpu/drm/msm/Kconfig | 1 + 1 file changed, 1 insertion(+)