| Message ID | 20230220111215.27471-4-pierrick.bouvier@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Adds support for running QEMU natively on windows-arm64 | expand |
Reviewed-by: Konstantin Kostiuk <kkostiuk@redhat.com> On 2/20/23 12:12, Pierrick Bouvier wrote: > Reported when compiling with clang-windows-arm64. > > ../qga/vss-win32/install.cpp:537:9: error: variable 'hr' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized] > if (!(ControlService(service, SERVICE_CONTROL_STOP, NULL))) { > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > ../qga/vss-win32/install.cpp:545:12: note: uninitialized use occurs here > return hr; > ^~ > Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org> > --- > qga/vss-win32/install.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/qga/vss-win32/install.cpp b/qga/vss-win32/install.cpp > index b57508fbe0..b8087e5baa 100644 > --- a/qga/vss-win32/install.cpp > +++ b/qga/vss-win32/install.cpp > @@ -518,7 +518,7 @@ namespace _com_util > /* Stop QGA VSS provider service using Winsvc API */ > STDAPI StopService(void) > { > - HRESULT hr; > + HRESULT hr = S_OK; > SC_HANDLE manager = OpenSCManager(NULL, NULL, SC_MANAGER_ALL_ACCESS); > SC_HANDLE service = NULL; >
On 20/2/23 12:12, Pierrick Bouvier wrote: > Reported when compiling with clang-windows-arm64. > > ../qga/vss-win32/install.cpp:537:9: error: variable 'hr' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized] > if (!(ControlService(service, SERVICE_CONTROL_STOP, NULL))) { > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > ../qga/vss-win32/install.cpp:545:12: note: uninitialized use occurs here > return hr; > ^~ > Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org> > --- > qga/vss-win32/install.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/qga/vss-win32/install.cpp b/qga/vss-win32/install.cpp > index b57508fbe0..b8087e5baa 100644 > --- a/qga/vss-win32/install.cpp > +++ b/qga/vss-win32/install.cpp > @@ -518,7 +518,7 @@ namespace _com_util > /* Stop QGA VSS provider service using Winsvc API */ > STDAPI StopService(void) > { > - HRESULT hr; > + HRESULT hr = S_OK; > SC_HANDLE manager = OpenSCManager(NULL, NULL, SC_MANAGER_ALL_ACCESS); > SC_HANDLE service = NULL; > Fixes: 917ebcb170 ("qga-win: Fix QGA VSS Provider service stop failure") Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
diff --git a/qga/vss-win32/install.cpp b/qga/vss-win32/install.cpp index b57508fbe0..b8087e5baa 100644 --- a/qga/vss-win32/install.cpp +++ b/qga/vss-win32/install.cpp @@ -518,7 +518,7 @@ namespace _com_util /* Stop QGA VSS provider service using Winsvc API */ STDAPI StopService(void) { - HRESULT hr; + HRESULT hr = S_OK; SC_HANDLE manager = OpenSCManager(NULL, NULL, SC_MANAGER_ALL_ACCESS); SC_HANDLE service = NULL;
Reported when compiling with clang-windows-arm64. ../qga/vss-win32/install.cpp:537:9: error: variable 'hr' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized] if (!(ControlService(service, SERVICE_CONTROL_STOP, NULL))) { ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../qga/vss-win32/install.cpp:545:12: note: uninitialized use occurs here return hr; ^~ Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org> --- qga/vss-win32/install.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)