| Message ID | 87zg9d99mp.fsf@jogness.linutronix.de |
|---|---|
| State | New |
| Headers | show |
| Series | [5.15-rt] printk: ignore consoles without write() callback | expand |
On Thu, Feb 16, 2023 at 11:45:58AM +0106, John Ogness wrote: > The ttynull driver does not provide an implementation for the write() > callback. This leads to a NULL pointer dereference in the related > printing kthread, which assumes it can call that callback. > > Do not create kthreads for consoles that do not implement the write() > callback. Also, for pr_flush(), ignore consoles that do not implement > write() or write_atomic() since there is no way those consoles can > flush their output. > > --- > This is only a problem for the PREEMPT_RT tree. Mainline does not have > this problem. Sorry for resurrecting this old thread but we actually want this patch in 5.15-rt. I am not sure why this was not applied to 5.15-rt yet since it is already applied to 5.10-rt. Could you please consider to pick this for 5.15-rt? Best regards, Krishanth
On 4/23/25 06:10, Krishanth Jagaduri wrote: > On Thu, Feb 16, 2023 at 11:45:58AM +0106, John Ogness wrote: >> The ttynull driver does not provide an implementation for the write() >> callback. This leads to a NULL pointer dereference in the related >> printing kthread, which assumes it can call that callback. >> >> Do not create kthreads for consoles that do not implement the write() >> callback. Also, for pr_flush(), ignore consoles that do not implement >> write() or write_atomic() since there is no way those consoles can >> flush their output. >> >> --- >> This is only a problem for the PREEMPT_RT tree. Mainline does not have >> this problem. > Sorry for resurrecting this old thread but we actually want this patch > in 5.15-rt. > > I am not sure why this was not applied to 5.15-rt yet since it is already > applied to 5.10-rt. > > Could you please consider to pick this for 5.15-rt? > > Best regards, > Krishanth Hi Krishanth, Thanks for pointing this out. I will investigate including this patch in the next v5.15 patch set, which should be released this week. Thanks, Joe
diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c index 7f27cfee283e..752afe88b5b4 100644 --- a/kernel/printk/printk.c +++ b/kernel/printk/printk.c @@ -2343,6 +2343,10 @@ static int printk_kthread_func(void *data) /* Must be called within console_lock(). */ static void start_printk_kthread(struct console *con) { + /* No need to start a printing thread if the console cannot print. */ + if (!con->write) + return; + con->thread = kthread_run(printk_kthread_func, con, "pr/%s%d", con->name, con->index); if (IS_ERR(con->thread)) { @@ -3737,6 +3741,8 @@ bool pr_flush(int timeout_ms, bool reset_on_progress) for_each_console(con) { if (!(con->flags & CON_ENABLED)) continue; + if (!con->write && !con->write_atomic) + continue; printk_seq = read_console_seq(con); if (printk_seq < seq) diff += seq - printk_seq;
The ttynull driver does not provide an implementation for the write() callback. This leads to a NULL pointer dereference in the related printing kthread, which assumes it can call that callback. Do not create kthreads for consoles that do not implement the write() callback. Also, for pr_flush(), ignore consoles that do not implement write() or write_atomic() since there is no way those consoles can flush their output. Link: https://lore.kernel.org/lkml/878rgy37f5.fsf@jogness.linutronix.de Fixes: 8782b1ef4125 ("printk: move console printing to kthreads") Reported-by: Michael Thalmeier <michael.thalmeier@hale.at> Signed-off-by: John Ogness <john.ogness@linutronix.de> --- This is only a problem for the PREEMPT_RT tree. Mainline does not have this problem. kernel/printk/printk.c | 6 ++++++ 1 file changed, 6 insertions(+)