| Message ID | 1460464554-14116-1-git-send-email-kong.kongxinwei@hisilicon.com |
|---|---|
| State | New |
| Headers | show |
On 2016/4/12 20:45, Hannes Reinecke wrote: > On 04/12/2016 02:35 PM, Xinwei Kong wrote: >> some usb disk such as Manufacturer Lenovo will have some problem in >> init process. >> >> when it run "scsi_dh_find_driver" function, because this parameter of >> "sdev->inquiry[5]" is 115, it will return "alua" in "scsi_dh_find_driver" >> function and will have some error log (alua: Attach failed (-22)). some >> usb init will fail and isn't used. >> >> Signed-off-by: Xinwei Kong <kong.kongxinwei@hisilicon.com> >> --- >> drivers/scsi/scsi_dh.c | 3 --- >> 1 file changed, 3 deletions(-) >> >> diff --git a/drivers/scsi/scsi_dh.c b/drivers/scsi/scsi_dh.c >> index 54d446c..36b3f354e 100644 >> --- a/drivers/scsi/scsi_dh.c >> +++ b/drivers/scsi/scsi_dh.c >> @@ -77,9 +77,6 @@ scsi_dh_find_driver(struct scsi_device *sdev) >> { >> const struct scsi_dh_blist *b; >> >> - if (scsi_device_tpgs(sdev)) >> - return "alua"; >> - >> for (b = scsi_dh_blist; b->vendor; b++) { >> if (!strncmp(sdev->vendor, b->vendor, strlen(b->vendor)) && >> !strncmp(sdev->model, b->model, strlen(b->model))) { >> > Nack. > That will completely disable ALUA support for everybody. > > And should've been fixed with commit > 221255aee67ec1c752001080aafec0c4e9390d95 > ("scsi: ignore errors from scsi_dh_add_device()"). > > Please validate. > ok, I slove this bug for using this patch. thank you xinwei > Cheers, > > Hannes > -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/scsi/scsi_dh.c b/drivers/scsi/scsi_dh.c index 54d446c..36b3f354e 100644 --- a/drivers/scsi/scsi_dh.c +++ b/drivers/scsi/scsi_dh.c @@ -77,9 +77,6 @@ scsi_dh_find_driver(struct scsi_device *sdev) { const struct scsi_dh_blist *b; - if (scsi_device_tpgs(sdev)) - return "alua"; - for (b = scsi_dh_blist; b->vendor; b++) { if (!strncmp(sdev->vendor, b->vendor, strlen(b->vendor)) && !strncmp(sdev->model, b->model, strlen(b->model))) {
some usb disk such as Manufacturer Lenovo will have some problem in init process. when it run "scsi_dh_find_driver" function, because this parameter of "sdev->inquiry[5]" is 115, it will return "alua" in "scsi_dh_find_driver" function and will have some error log (alua: Attach failed (-22)). some usb init will fail and isn't used. Signed-off-by: Xinwei Kong <kong.kongxinwei@hisilicon.com> --- drivers/scsi/scsi_dh.c | 3 --- 1 file changed, 3 deletions(-) -- 2.8.0 -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html