diff mbox series

printk/console: Enable console kthreads only when there is no boot console left

Message ID 878rgrro4z.fsf@jogness.linutronix.de
State New
Headers show
Series printk/console: Enable console kthreads only when there is no boot console left | expand

Commit Message

John Ogness Feb. 21, 2023, 4:15 p.m. UTC 
The console kthreads uncovered several races in console drivers.
All problems were in situation when a console was being properly
initialized and registered while an early console, using the same
port, was being used.

These problems are pretty hard to debug because they often result
into silent boot crashes. It would be nice to fix them but it
looks like a can of worms.

Prevent these problems by delaying the use of console kthreads
after all early consoles are gone. It might later be optimized.
But let's close this can of worms with a big hammer for now
so that they do not break first impression on the kthreads
that solve other real problems.

Link: https://lore.kernel.org/r/20220619204949.50d9154d@thinkpad
Link: https://lore.kernel.org/r/2a82eae7-a256-f70c-fd82-4e510750906e@samsung.com
Reported-by: Marek Behún <kabel@kernel.org>
Signed-off-by: Petr Mladek <pmladek@suse.com>
Tested-by: Marek Behún <kabel@kernel.org>
[ rebased for 5.10.165-rt81 by john.ogness ]
---
 kernel/printk/printk.c | 31 ++++++++++++++++++++++++++-----
 1 file changed, 26 insertions(+), 5 deletions(-)

Comments

André Pribil Feb. 22, 2023, 2:35 p.m. UTC | #1 
Hi John,

here is some further information about the issue. 

Not sure if this is just a coincidence, but I found the following workaround for me:
I had a "stdout-path = &uart3;" setting in the device-tree and a "console=ttymxc2,115200" 
kernel command line parameter at the same time. If I remove the "console" command line
parameter, then I don't see this corruption anymore. 

Andre
diff mbox series

Patch

diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c
index d2205872304d..db095bd0f17c 100644
--- a/kernel/printk/printk.c
+++ b/kernel/printk/printk.c
@@ -2986,6 +2986,21 @@  void __init console_init(void)
 	}
 }
 
+#ifdef CONFIG_PRINTK
+static int __init printk_activate_kthreads(void)
+{
+	struct console *con;
+
+	console_lock();
+	for_each_console(con)
+		printk_start_kthread(con);
+	kthreads_started = true;
+	console_unlock();
+
+	return 0;
+}
+#endif
+
 /*
  * Some boot consoles access data that is in the init section and which will
  * be discarded after the initcalls have been run. To make sure that no code
@@ -3002,6 +3017,7 @@  void __init console_init(void)
  */
 static int __init printk_late_init(void)
 {
+	bool no_bootcon = true;
 	struct console *con;
 	int ret;
 
@@ -3023,15 +3039,20 @@  static int __init printk_late_init(void)
 			pr_warn("bootconsole [%s%d] uses init memory and must be disabled even before the real one is ready\n",
 				con->name, con->index);
 			unregister_console(con);
+			continue;
 		}
+
+		no_bootcon = false;
 	}
 
 #ifdef CONFIG_PRINTK
-	console_lock();
-	for_each_console(con)
-		start_printk_kthread(con);
-	kthreads_started = true;
-	console_unlock();
+	/*
+	 * Some console drivers are not ready to use the same port with
+	 * boot (early) and normal console in parallel. Stay on the safe
+	 * side and enable kthreads only when there is no boot console.
+	 */
+	if (no_bootcon)
+		printk_activate_kthreads();
 #endif
 
 	ret = cpuhp_setup_state_nocalls(CPUHP_PRINTK_DEAD, "printk:dead", NULL,