| Message ID | 1328148728-32258-5-git-send-email-richard.zhao@linaro.org |
|---|---|
| State | Accepted |
| Headers | show |
Hi Richard, On Thu, Feb 2, 2012 at 12:12 AM, Richard Zhao <richard.zhao@linaro.org> wrote: > Signed-off-by: Richard Zhao <richard.zhao@linaro.org> > --- > arch/arm/boot/dts/imx6q-sabrelite.dts | 12 ++++++++++++ > 1 files changed, 12 insertions(+), 0 deletions(-) I would like to test your audio support patch on mx6sabrelite, but the missing sound/soc/imx-sgtl5000.c does not allow me to do it. I think you would better introduce sound/soc/imx-sgtl5000.c first (on separate patch series) so that people could test this patch without using the imx-sgtl5000.c implementation from the Linaro kernel. Without imx-sgtl5000.c in place, this patch only introduces dead code at the moment. Regards, Fabio Estevam
On Thu, Feb 02, 2012 at 09:24:57AM -0200, Fabio Estevam wrote: > Hi Richard, > > On Thu, Feb 2, 2012 at 12:12 AM, Richard Zhao <richard.zhao@linaro.org> wrote: > > Signed-off-by: Richard Zhao <richard.zhao@linaro.org> > > --- > > arch/arm/boot/dts/imx6q-sabrelite.dts | 12 ++++++++++++ > > 1 files changed, 12 insertions(+), 0 deletions(-) > > I would like to test your audio support patch on mx6sabrelite, but the > missing sound/soc/imx-sgtl5000.c does not allow me to do it. I have a test branch. I'll push to my linaro git on git.linaro.org tomorrow. > > I think you would better introduce sound/soc/imx-sgtl5000.c first (on > separate patch series) so that people could test this patch without > using the imx-sgtl5000.c implementation from the Linaro kernel. > > Without imx-sgtl5000.c in place, this patch only introduces dead code > at the moment. Each patch make sense too without sgtl5000. Thanks Richard > > Regards, > > Fabio Estevam
On 2/2/12, Richard Zhao <richard.zhao@linaro.org> wrote: >> Without imx-sgtl5000.c in place, this patch only introduces dead code >> at the moment. > Each patch make sense too without sgtl5000. Well, as this patch goal is to provide audio support to mx6sabrelite, we need imx-sgtl5000 in place to test it, right? How can we know that don't get a kernel oops or something? Regards, Fabio Estevam
On Thu, Feb 02, 2012 at 12:15:52PM -0200, Fabio Estevam wrote: > On 2/2/12, Richard Zhao <richard.zhao@linaro.org> wrote: > > >> Without imx-sgtl5000.c in place, this patch only introduces dead code > >> at the moment. > > Each patch make sense too without sgtl5000. > > Well, as this patch goal is to provide audio support to mx6sabrelite, > we need imx-sgtl5000 in place to test it, right? My goal seem less important here. You see I'm adding more and more things into the patch series, which is out of my goal. The maintainers only consider right patch go to right git. > How can we know that > don't get a kernel oops or something? patch pass building is possible go to upstream too. > > Regards, > > Fabio Estevam
diff --git a/arch/arm/boot/dts/imx6q-sabrelite.dts b/arch/arm/boot/dts/imx6q-sabrelite.dts index cdc2ad6..3a9d32c 100644 --- a/arch/arm/boot/dts/imx6q-sabrelite.dts +++ b/arch/arm/boot/dts/imx6q-sabrelite.dts @@ -44,6 +44,18 @@ uart2: uart@021e8000 { status = "okay"; }; + + i2c@021a0000 { /* I2C1 */ + status = "okay"; + clock-frequency = <100000>; + + codec: sgtl5000@0a { + compatible = "fsl,sgtl5000"; + reg = <0x0a>; + VDDA-supply = <®_2p5v>; + VDDIO-supply = <®_3p3v>; + }; + }; }; };
Signed-off-by: Richard Zhao <richard.zhao@linaro.org> --- arch/arm/boot/dts/imx6q-sabrelite.dts | 12 ++++++++++++ 1 files changed, 12 insertions(+), 0 deletions(-)