| Message ID | 20230226053953.4681-5-rdunlap@infradead.org |
|---|---|
| State | New |
| Headers | show |
| Series | drivers: select REGMAP instead of depending on it | expand |
On Sat 2023-02-25 21:39:49, Randy Dunlap wrote: > REGMAP is a hidden (not user visible) symbol. Users cannot set it > directly thru "make *config", so drivers should select it instead of > depending on it if they need it. > > Consistently using "select" or "depends on" can also help reduce > Kconfig circular dependency issues. > > Therefore, change the use of "depends on REGMAP" to "select REGMAP". > > Fixes: 3fce8e1eb994 ("leds: TI LMU: Add common code for TI LMU devices") > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Cc: Dan Murphy <dmurphy@ti.com> Acked-by: Pavel Machek <pavel@ucw.cz> Best regards, Pavel
On Sat, 25 Feb 2023, Randy Dunlap wrote: > REGMAP is a hidden (not user visible) symbol. Users cannot set it > directly thru "make *config", so drivers should select it instead of > depending on it if they need it. > > Consistently using "select" or "depends on" can also help reduce > Kconfig circular dependency issues. > > Therefore, change the use of "depends on REGMAP" to "select REGMAP". > > Fixes: 3fce8e1eb994 ("leds: TI LMU: Add common code for TI LMU devices") > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Cc: Dan Murphy <dmurphy@ti.com> > Cc: Pavel Machek <pavel@ucw.cz> > Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com> > Cc: Lee Jones <lee@kernel.org> > Cc: linux-leds@vger.kernel.org > --- > drivers/leds/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks
diff -- a/drivers/leds/Kconfig b/drivers/leds/Kconfig --- a/drivers/leds/Kconfig +++ b/drivers/leds/Kconfig @@ -795,7 +795,7 @@ config LEDS_SPI_BYTE config LEDS_TI_LMU_COMMON tristate "LED driver for TI LMU" depends on LEDS_CLASS - depends on REGMAP + select REGMAP help Say Y to enable the LED driver for TI LMU devices. This supports common features between the TI LM3532, LM3631, LM3632,
REGMAP is a hidden (not user visible) symbol. Users cannot set it directly thru "make *config", so drivers should select it instead of depending on it if they need it. Consistently using "select" or "depends on" can also help reduce Kconfig circular dependency issues. Therefore, change the use of "depends on REGMAP" to "select REGMAP". Fixes: 3fce8e1eb994 ("leds: TI LMU: Add common code for TI LMU devices") Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Cc: Dan Murphy <dmurphy@ti.com> Cc: Pavel Machek <pavel@ucw.cz> Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com> Cc: Lee Jones <lee@kernel.org> Cc: linux-leds@vger.kernel.org --- drivers/leds/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)