| Message ID | 20230301214952.2190757-4-saravanak@google.com |
|---|---|
| State | New |
| Headers | show |
| Series | Remove use of fw_devlink_purge_absent_suppliers() | expand |
On Wed, Mar 01, 2023 at 01:49:50PM -0800, Saravana Kannan wrote: > After recent changes to fw_devlink that ended with commit 4a032827daa8 > ("of: property: Simplify of_link_to_phandle()"), fw_devlink no longer > cares about the "compatible" property and figures out the correct struct > device at runtime. So, we no longer need to call > fw_devlink_purge_absent_suppliers(). > > Signed-off-by: Saravana Kannan <saravanak@google.com> > Cc: Yongqin Liu <yongqin.liu@linaro.org> > Cc: Sumit Semwal <sumit.semwal@linaro.org> Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> > --- > drivers/usb/typec/tcpm/tcpm.c | 9 --------- > 1 file changed, 9 deletions(-) > > diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c > index a0d943d78580..fd131f07020c 100644 > --- a/drivers/usb/typec/tcpm/tcpm.c > +++ b/drivers/usb/typec/tcpm/tcpm.c > @@ -6112,15 +6112,6 @@ static int tcpm_fw_get_caps(struct tcpm_port *port, > if (!fwnode) > return -EINVAL; > > - /* > - * This fwnode has a "compatible" property, but is never populated as a > - * struct device. Instead we simply parse it to read the properties. > - * This it breaks fw_devlink=on. To maintain backward compatibility > - * with existing DT files, we work around this by deleting any > - * fwnode_links to/from this fwnode. > - */ > - fw_devlink_purge_absent_suppliers(fwnode); > - > ret = typec_get_fw_cap(&port->typec_caps, fwnode); > if (ret < 0) > return ret; > -- > 2.39.2.722.g9855ee24e9-goog
diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c index a0d943d78580..fd131f07020c 100644 --- a/drivers/usb/typec/tcpm/tcpm.c +++ b/drivers/usb/typec/tcpm/tcpm.c @@ -6112,15 +6112,6 @@ static int tcpm_fw_get_caps(struct tcpm_port *port, if (!fwnode) return -EINVAL; - /* - * This fwnode has a "compatible" property, but is never populated as a - * struct device. Instead we simply parse it to read the properties. - * This it breaks fw_devlink=on. To maintain backward compatibility - * with existing DT files, we work around this by deleting any - * fwnode_links to/from this fwnode. - */ - fw_devlink_purge_absent_suppliers(fwnode); - ret = typec_get_fw_cap(&port->typec_caps, fwnode); if (ret < 0) return ret;
After recent changes to fw_devlink that ended with commit 4a032827daa8 ("of: property: Simplify of_link_to_phandle()"), fw_devlink no longer cares about the "compatible" property and figures out the correct struct device at runtime. So, we no longer need to call fw_devlink_purge_absent_suppliers(). Signed-off-by: Saravana Kannan <saravanak@google.com> Cc: Yongqin Liu <yongqin.liu@linaro.org> Cc: Sumit Semwal <sumit.semwal@linaro.org> --- drivers/usb/typec/tcpm/tcpm.c | 9 --------- 1 file changed, 9 deletions(-)