diff mbox series

[v2] clk: Print an info line before disabling unused clocks

Message ID 20230307132928.3887737-1-konrad.dybcio@linaro.org
State Accepted
Commit 12ca59b91d04df32e41be5a52f0cabba912c11de
Headers show
Series [v2] clk: Print an info line before disabling unused clocks | expand

Commit Message

Konrad Dybcio March 7, 2023, 1:29 p.m. UTC 
Currently, the regulator framework informs us before calling into
their unused cleanup paths, which eases at least some debugging. The
same could be beneficial for clocks, so that random shutdowns shortly
after most initcalls are done can be less of a guess.

Add a pr_info before disabling unused clocks to do so.

Reviewed-by: Marijn Suijten <marijn.suijten@somainline.org>
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
v1 -> v2:
- Don't add 'else' right before a return
- Add Marijn's r-b

 drivers/clk/clk.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Stephen Boyd March 29, 2023, 6:49 p.m. UTC | #1 
Quoting Konrad Dybcio (2023-03-07 05:29:28)
> Currently, the regulator framework informs us before calling into
> their unused cleanup paths, which eases at least some debugging. The
> same could be beneficial for clocks, so that random shutdowns shortly
> after most initcalls are done can be less of a guess.
> 
> Add a pr_info before disabling unused clocks to do so.
> 
> Reviewed-by: Marijn Suijten <marijn.suijten@somainline.org>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---

Applied to clk-next
diff mbox series

Patch

diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
index ae07685c7588..115a80fda3f9 100644
--- a/drivers/clk/clk.c
+++ b/drivers/clk/clk.c
@@ -1406,6 +1406,8 @@  static int __init clk_disable_unused(void)
 		return 0;
 	}
 
+	pr_info("clk: Disabling unused clocks\n");
+
 	clk_prepare_lock();
 
 	hlist_for_each_entry(core, &clk_root_list, child_node)