[2/8] serial: Use B0 instead of implicit zero assumption

Message ID	20230309080923.11778-3-ilpo.jarvinen@linux.intel.com
State	New
Headers	show Return-Path: <linux-serial-owner@vger.kernel.org> From: =?utf-8?q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com> To: linux-serial@vger.kernel.org, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Jiri Slaby <jirislaby@kernel.org>, linux-kernel@vger.kernel.org Cc: =?utf-8?q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com> Subject: [PATCH 2/8] serial: Use B0 instead of implicit zero assumption Date: Thu, 9 Mar 2023 10:09:17 +0200 Message-Id: <20230309080923.11778-3-ilpo.jarvinen@linux.intel.com> In-Reply-To: <20230309080923.11778-1-ilpo.jarvinen@linux.intel.com> References: <20230309080923.11778-1-ilpo.jarvinen@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk
Series	tty: Cleanups \| expand [0/8] tty: Cleanups [2/8] serial: Use B0 instead of implicit zero assumption [4/8] serial: Move uart_change_speed() earlier [6/8] serial: Make hw_stopped bool [8/8] serial: Remove uart_wait_until_sent() forward declaration [1/8] n_tty: Convert no_space_left to space_left boolean [3/8] Bluetooth: hci_ldisc: Fix tty_set_termios() return value assumptions [5/8] n_tty: Use DIV_ROUND_UP() in room calculation [7/8] n_tty: Reindent if condition

Message ID

20230309080923.11778-3-ilpo.jarvinen@linux.intel.com

State

New

Headers

From: =?utf-8?q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>
To: linux-serial@vger.kernel.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jiri Slaby <jirislaby@kernel.org>, linux-kernel@vger.kernel.org
Cc: =?utf-8?q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>
Subject: [PATCH 2/8] serial: Use B0 instead of implicit zero assumption
Date: Thu,  9 Mar 2023 10:09:17 +0200
Message-Id: <20230309080923.11778-3-ilpo.jarvinen@linux.intel.com>
In-Reply-To: <20230309080923.11778-1-ilpo.jarvinen@linux.intel.com>
References: <20230309080923.11778-1-ilpo.jarvinen@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

Series

tty: Cleanups | expand

Commit Message

Ilpo Järvinen March 9, 2023, 8:09 a.m. UTC

Compare against B0 rather than assume B0 equals zero, which is true for
all archs but explicit B0 makes the code more obvious.

Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
---
 drivers/tty/serial/serial_core.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_core.c
index ee2aabcc8943..296d2c33ea7a 100644
--- a/drivers/tty/serial/serial_core.c
+++ b/drivers/tty/serial/serial_core.c
@@ -1662,10 +1662,10 @@  static void uart_set_termios(struct tty_struct *tty,
 	cflag = tty->termios.c_cflag;
 
 	/* Handle transition to B0 status */
-	if ((old_termios->c_cflag & CBAUD) && !(cflag & CBAUD))
+	if (((old_termios->c_cflag & CBAUD) != B0) && ((cflag & CBAUD) == B0))
 		uart_clear_mctrl(uport, TIOCM_RTS | TIOCM_DTR);
 	/* Handle transition away from B0 status */
-	else if (!(old_termios->c_cflag & CBAUD) && (cflag & CBAUD)) {
+	else if (((old_termios->c_cflag & CBAUD) == B0) && ((cflag & CBAUD) != B0)) {
 		unsigned int mask = TIOCM_DTR;
 
 		if (!(cflag & CRTSCTS) || !tty_throttled(tty))

[2/8] serial: Use B0 instead of implicit zero assumption

Commit Message

Patch