| Message ID | 20230317191341.1670660-1-trix@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | leds: flash: set varaiables mvflash_3,4ch_regs storage-class-specifier to static | expand |
On Fri 2023-03-17 15:13:41, Tom Rix wrote: > smatch reports > drivers/leds/flash/leds-qcom-flash.c:103:18: warning: > symbol 'mvflash_3ch_regs' was not declared. Should it be static? > drivers/leds/flash/leds-qcom-flash.c:115:18: warning: > symbol 'mvflash_4ch_regs' was not declared. Should it be static? > > These variables are only used in leds-qcom-flash.c, > so it should be static. > > Signed-off-by: Tom Rix <trix@redhat.com> Acked-by: Pavel Machek <pavel@ucw.cz> BR, Pavel
On Fri, 17 Mar 2023, Tom Rix wrote: > smatch reports > drivers/leds/flash/leds-qcom-flash.c:103:18: warning: > symbol 'mvflash_3ch_regs' was not declared. Should it be static? > drivers/leds/flash/leds-qcom-flash.c:115:18: warning: > symbol 'mvflash_4ch_regs' was not declared. Should it be static? > > These variables are only used in leds-qcom-flash.c, > so it should be static. > > Signed-off-by: Tom Rix <trix@redhat.com> > --- > drivers/leds/flash/leds-qcom-flash.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) I fixed-up some spelling / formatting issues and ... Applied, thanks -- Lee Jones [李琼斯]
diff --git a/drivers/leds/flash/leds-qcom-flash.c b/drivers/leds/flash/leds-qcom-flash.c index 406ed8761c78..90a24fa25a49 100644 --- a/drivers/leds/flash/leds-qcom-flash.c +++ b/drivers/leds/flash/leds-qcom-flash.c @@ -100,7 +100,7 @@ enum { REG_MAX_COUNT, }; -struct reg_field mvflash_3ch_regs[REG_MAX_COUNT] = { +static struct reg_field mvflash_3ch_regs[REG_MAX_COUNT] = { REG_FIELD(0x08, 0, 7), /* status1 */ REG_FIELD(0x09, 0, 7), /* status2 */ REG_FIELD(0x0a, 0, 7), /* status3 */ @@ -112,7 +112,7 @@ struct reg_field mvflash_3ch_regs[REG_MAX_COUNT] = { REG_FIELD(0x4c, 0, 2), /* chan_en */ }; -struct reg_field mvflash_4ch_regs[REG_MAX_COUNT] = { +static struct reg_field mvflash_4ch_regs[REG_MAX_COUNT] = { REG_FIELD(0x06, 0, 7), /* status1 */ REG_FIELD(0x07, 0, 6), /* status2 */ REG_FIELD(0x09, 0, 7), /* status3 */
smatch reports drivers/leds/flash/leds-qcom-flash.c:103:18: warning: symbol 'mvflash_3ch_regs' was not declared. Should it be static? drivers/leds/flash/leds-qcom-flash.c:115:18: warning: symbol 'mvflash_4ch_regs' was not declared. Should it be static? These variables are only used in leds-qcom-flash.c, so it should be static. Signed-off-by: Tom Rix <trix@redhat.com> --- drivers/leds/flash/leds-qcom-flash.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)