Message ID | 20230317141622.1926573-5-quic_mohs@quicinc.com |
---|---|
State | New |
Headers | show |
Series | Add resets for ADSP based audio clock controller driver | expand |
On 3/17/2023 11:57 PM, Stephen Boyd wrote: > Quoting Mohammad Rafi Shaik (2023-03-17 07:16:22) >> Modify AHB clocks explicit registration from qcom_cc_probe to >> qcom_cc_probe_by_index. > Why? Isn't it the same? yes, it is same. As per the previous version review comment, modified qcom_cc_probe to qcom_cc_probe_by_index.
Quoting Mohammad Rafi Shaik (2023-03-23 00:45:26) > > On 3/17/2023 11:57 PM, Stephen Boyd wrote: > > Quoting Mohammad Rafi Shaik (2023-03-17 07:16:22) > >> Modify AHB clocks explicit registration from qcom_cc_probe to > >> qcom_cc_probe_by_index. > > Why? Isn't it the same? > yes, it is same. > > As per the previous version review comment, modified qcom_cc_probe to > qcom_cc_probe_by_index. Previously you were probing with index 1. That necessitated using qcom_cc_probe_by_index() instead of qcom_cc_probe(). That is no longer the case though, so this patch is unnecessary.
diff --git a/drivers/clk/qcom/lpassaudiocc-sc7280.c b/drivers/clk/qcom/lpassaudiocc-sc7280.c index 134eb1529ede..b7f4688a61f4 100644 --- a/drivers/clk/qcom/lpassaudiocc-sc7280.c +++ b/drivers/clk/qcom/lpassaudiocc-sc7280.c @@ -830,7 +830,7 @@ static int lpass_aon_cc_sc7280_probe(struct platform_device *pdev) if (of_property_read_bool(pdev->dev.of_node, "qcom,adsp-pil-mode")) { lpass_audio_cc_sc7280_regmap_config.name = "cc"; desc = &lpass_cc_sc7280_desc; - ret = qcom_cc_probe(pdev, desc); + ret = qcom_cc_probe_by_index(pdev, 0, desc); goto exit; }
Modify AHB clocks explicit registration from qcom_cc_probe to qcom_cc_probe_by_index. Signed-off-by: Mohammad Rafi Shaik <quic_mohs@quicinc.com> --- drivers/clk/qcom/lpassaudiocc-sc7280.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)