| Message ID | 20230320104658.22186-2-johan+linaro@kernel.org |
|---|---|
| State | Accepted |
| Commit | b6b88111c0dbcef04cd0e0bafd646e4c09728302 |
| Headers | show |
| Series | [1/3] dt-bindings: wireless: add ath11k pcie bindings | expand |
On 21/03/2023 09:14, Krzysztof Kozlowski wrote: > On 20/03/2023 11:46, Johan Hovold wrote: >> Add devicetree bindings for Qualcomm ath11k PCIe devices such as WCN6856 >> for which the calibration data variant may need to be described. >> >> Signed-off-by: Johan Hovold <johan+linaro@kernel.org> >> --- >> .../bindings/net/wireless/pci17cb,1103.yaml | 56 +++++++++++++++++++ >> 1 file changed, 56 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/net/wireless/pci17cb,1103.yaml >> >> diff --git a/Documentation/devicetree/bindings/net/wireless/pci17cb,1103.yaml b/Documentation/devicetree/bindings/net/wireless/pci17cb,1103.yaml >> new file mode 100644 >> index 000000000000..df67013822c6 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/net/wireless/pci17cb,1103.yaml > > PCI devices are kind of exception in the naming, so this should be > qcom,ath11k-pci.yaml or qcom,wcn6856.yaml (or something similar) > > >> @@ -0,0 +1,56 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +# Copyright (c) 2023 Linaro Limited >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/net/wireless/pci17cb,1103.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Qualcomm Technologies ath11k wireless devices (PCIe) >> + >> +maintainers: >> + - Kalle Valo <kvalo@kernel.org> >> + >> +description: | >> + Qualcomm Technologies IEEE 802.11ax PCIe devices. >> + >> +properties: >> + compatible: >> + enum: >> + - pci17cb,1103 # WCN6856 >> + >> + reg: >> + maxItems: 1 >> + >> + qcom,ath11k-calibration-variant: > > qcom,calibration-variant Ah, so there is already property with ath11k, then let's go with existing name. Best regards, Krzysztof
On Tue, Mar 21, 2023 at 09:14:15AM +0100, Krzysztof Kozlowski wrote: > On 20/03/2023 11:46, Johan Hovold wrote: > > Add devicetree bindings for Qualcomm ath11k PCIe devices such as WCN6856 > > for which the calibration data variant may need to be described. > > > > Signed-off-by: Johan Hovold <johan+linaro@kernel.org> > > --- > > .../bindings/net/wireless/pci17cb,1103.yaml | 56 +++++++++++++++++++ > > 1 file changed, 56 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/net/wireless/pci17cb,1103.yaml > > > > diff --git a/Documentation/devicetree/bindings/net/wireless/pci17cb,1103.yaml b/Documentation/devicetree/bindings/net/wireless/pci17cb,1103.yaml > > new file mode 100644 > > index 000000000000..df67013822c6 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/net/wireless/pci17cb,1103.yaml > > PCI devices are kind of exception in the naming, so this should be > qcom,ath11k-pci.yaml or qcom,wcn6856.yaml (or something similar) Heh, I suggested something similar in my reply to Kalle. Let's go with 'qcom,ath11k-pci.yaml' then as he first suggested (and keeping the current schema file unchanged?). > > @@ -0,0 +1,56 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +# Copyright (c) 2023 Linaro Limited > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/net/wireless/pci17cb,1103.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Qualcomm Technologies ath11k wireless devices (PCIe) > > + > > +maintainers: > > + - Kalle Valo <kvalo@kernel.org> > > + > > +description: | > > + Qualcomm Technologies IEEE 802.11ax PCIe devices. > > + > > +properties: > > + compatible: > > + enum: > > + - pci17cb,1103 # WCN6856 > > + > > + reg: > > + maxItems: 1 > > + > > + qcom,ath11k-calibration-variant: > > qcom,calibration-variant This one is already in use as you noticed. > > + $ref: /schemas/types.yaml#/definitions/string > > + description: calibration data variant > > Your description copies the name of property. Instead say something more... Yeah, I was actively avoiding trying to say too much (e.g. mentioning the name of the current firmware file). See the definition in qcom,ath11k.yaml. I can try to find some middle ground unless you prefer copying the current definition. Johan
diff --git a/Documentation/devicetree/bindings/net/wireless/pci17cb,1103.yaml b/Documentation/devicetree/bindings/net/wireless/pci17cb,1103.yaml new file mode 100644 index 000000000000..df67013822c6 --- /dev/null +++ b/Documentation/devicetree/bindings/net/wireless/pci17cb,1103.yaml @@ -0,0 +1,56 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +# Copyright (c) 2023 Linaro Limited +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/net/wireless/pci17cb,1103.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Qualcomm Technologies ath11k wireless devices (PCIe) + +maintainers: + - Kalle Valo <kvalo@kernel.org> + +description: | + Qualcomm Technologies IEEE 802.11ax PCIe devices. + +properties: + compatible: + enum: + - pci17cb,1103 # WCN6856 + + reg: + maxItems: 1 + + qcom,ath11k-calibration-variant: + $ref: /schemas/types.yaml#/definitions/string + description: calibration data variant + +required: + - compatible + - reg + +additionalProperties: false + +examples: + - | + pcie { + #address-cells = <3>; + #size-cells = <2>; + + pcie@0 { + device_type = "pci"; + reg = <0x0 0x0 0x0 0x0 0x0>; + #address-cells = <3>; + #size-cells = <2>; + ranges; + + bus-range = <0x01 0xff>; + + wifi@0 { + compatible = "pci17cb,1103"; + reg = <0x10000 0x0 0x0 0x0 0x0>; + + qcom,ath11k-calibration-variant = "LE_X13S"; + }; + }; + };
Add devicetree bindings for Qualcomm ath11k PCIe devices such as WCN6856 for which the calibration data variant may need to be described. Signed-off-by: Johan Hovold <johan+linaro@kernel.org> --- .../bindings/net/wireless/pci17cb,1103.yaml | 56 +++++++++++++++++++ 1 file changed, 56 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/wireless/pci17cb,1103.yaml