| Message ID | 20230319042732.278691-1-sensor1010@163.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v1] scsi: scsi_debug: Remove redundant driver match function | expand |
On 19/03/2023 04:27, Lizhe wrote: > If there is no driver match function, the driver core assumes that each > candidate pair (driver, device) matches, see driver_match_device() > > Drop the pseudo_lld bus's match function that always returned 1 and so I'd have "Drop the pseudo_lld_bus match function .." > implements the same behaviour as when there is no match function. > > Signed-off-by: Lizhe<sensor1010@163.com> > --- Reviewed-by: John Garry <john.g.garry@oracle.com>
Lizhe, > If there is no driver match function, the driver core assumes that each > candidate pair (driver, device) matches, see driver_match_device() > > Drop the pseudo_lld bus's match function that always returned 1 and so > implements the same behaviour as when there is no match function. Applied to 6.4/scsi-staging, thanks!
diff --git a/drivers/scsi/scsi_debug.c b/drivers/scsi/scsi_debug.c index 8553277effb3..fa6f150b7364 100644 --- a/drivers/scsi/scsi_debug.c +++ b/drivers/scsi/scsi_debug.c @@ -7950,15 +7950,8 @@ static void sdebug_driver_remove(struct device *dev) scsi_host_put(sdbg_host->shost); } -static int pseudo_lld_bus_match(struct device *dev, - struct device_driver *dev_driver) -{ - return 1; -} - static struct bus_type pseudo_lld_bus = { .name = "pseudo", - .match = pseudo_lld_bus_match, .probe = sdebug_driver_probe, .remove = sdebug_driver_remove, .drv_groups = sdebug_drv_groups,
If there is no driver match function, the driver core assumes that each candidate pair (driver, device) matches, see driver_match_device() Drop the pseudo_lld bus's match function that always returned 1 and so implements the same behaviour as when there is no match function. Signed-off-by: Lizhe <sensor1010@163.com> --- drivers/scsi/scsi_debug.c | 7 ------- 1 file changed, 7 deletions(-)