| Message ID | 20230321061419.3139051-1-jsnitsel@redhat.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | scsi: mpt3sas: Don't print sense pool info twice | expand |
On Fri, 24 Mar 2023 12:32:04 -0700, Jerry Snitselaar wrote: > _base_allocate_sense_dma_pool() already prints out the sense pool > information, so don't print it a second time after calling it in > _base_allocate_memory_pools(). In addition the version in > _base_allocate_memory_pools() was using the wrong size value, sz, > which was last assigned when doing some nvme calculations instead of > sense_sz to determine the pool size in kilobytes. > > [...] Applied to 6.3/scsi-fixes, thanks! [1/1] scsi: mpt3sas: Don't print sense pool info twice https://git.kernel.org/mkp/scsi/c/d684a7a26f7d
diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.c b/drivers/scsi/mpt3sas/mpt3sas_base.c index 2ee9ea57554d..14ae0a9c5d3d 100644 --- a/drivers/scsi/mpt3sas/mpt3sas_base.c +++ b/drivers/scsi/mpt3sas/mpt3sas_base.c @@ -6616,11 +6616,6 @@ _base_allocate_memory_pools(struct MPT3SAS_ADAPTER *ioc) else if (rc == -EAGAIN) goto try_32bit_dma; total_sz += sense_sz; - ioc_info(ioc, - "sense pool(0x%p)- dma(0x%llx): depth(%d)," - "element_size(%d), pool_size(%d kB)\n", - ioc->sense, (unsigned long long)ioc->sense_dma, ioc->scsiio_depth, - SCSI_SENSE_BUFFERSIZE, sz / 1024); /* reply pool, 4 byte align */ sz = ioc->reply_free_queue_depth * ioc->reply_sz; rc = _base_allocate_reply_pool(ioc, sz);
_base_allocate_sense_dma_pool() already prints out the sense pool information, so don't print it a second time after calling it in _base_allocate_memory_pools(). In addition the version in _base_allocate_memory_pools() was using the wrong size value, sz, which was last assigned when doing some nvme calculations instead of sense_sz to determine the pool size in kilobytes. Cc: Sathya Prakash <sathya.prakash@broadcom.com> Cc: Sreekanth Reddy <sreekanth.reddy@broadcom.com> Cc: Suganath Prabu Subramani <suganath-prabu.subramani@broadcom.com> Cc: MPT-FusionLinux.pdl@broadcom.com Cc: "Martin K. Petersen" <martin.petersen@oracle.com> Signed-off-by: Jerry Snitselaar <jsnitsel@redhat.com> --- drivers/scsi/mpt3sas/mpt3sas_base.c | 5 ----- 1 file changed, 5 deletions(-)