diff mbox

[v2] spec: If installing default network, restart libvirtd

Message ID 36fbd20f23e3400d7c6ca88797b6e9f30535432d.1461680163.git.crobinso@redhat.com
State Accepted
Commit 1d4400082a02c41b152cc9ab7b4cfc428cc527ee
Headers show

Commit Message

Cole Robinson April 26, 2016, 2:16 p.m. UTC 
If libvirt-daemon-config-network is installed while libvirtd is already
running, the daemon doesn't notice the network. Users then have to
manually restart libvirtd (or reboot) to pick up the network.

Instead let's trigger a daemon restart when the package is first installed.
Then the default network is available immediately if libvirtd was already
running.

https://bugzilla.redhat.com/show_bug.cgi?id=867546
---
v2: Send the patch with actual try-restart/condrestart

Plain restart is kind of suboptimal since it will drop all open
libvirt connections. Ideally we would use reload which is meant
for this case, but it's kinda crashy with current git:

http://www.redhat.com/archives/libvir-list/2016-April/msg01624.html

And in fact daemon restart is what the spec triggers on libvirt-daemon
upgrade anyways, so this isn't anything new WRT packaging.

 libvirt.spec.in | 8 ++++++++
 1 file changed, 8 insertions(+)

-- 
2.7.4

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
diff mbox

Patch

diff --git a/libvirt.spec.in b/libvirt.spec.in
index 35212da..4eff5ae 100644
--- a/libvirt.spec.in
+++ b/libvirt.spec.in
@@ -1849,6 +1849,14 @@  if test $1 -eq 1 && test ! -f %{_sysconfdir}/libvirt/qemu/networks/default.xml ;
          < %{_datadir}/libvirt/networks/default.xml \
          > %{_sysconfdir}/libvirt/qemu/networks/default.xml
     ln -s ../default.xml %{_sysconfdir}/libvirt/qemu/networks/autostart/default.xml
+
+    # Make sure libvirt picks up the new network defininiton
+      %if %{with_systemd}
+    /bin/systemctl try-restart libvirtd.service >/dev/null 2>&1 ||:
+      %else
+    /sbin/service libvirtd condrestart > /dev/null 2>&1 || :
+      %endif
+
 fi
     %endif