| Message ID | 20230328021912.177301-8-ychuang570808@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Introduce Nuvoton ma35d1 SoC | expand |
On 28/03/2023 04:19, Jacky Huang wrote: > From: Jacky Huang <ychuang3@nuvoton.com> > > Add documentation to describe nuvoton ma35d1 uart driver bindings. > This depends on clock patches, so it must be taken together. Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
Dear Krzysztof, Thanks for your review. On 2023/3/29 下午 04:20, Krzysztof Kozlowski wrote: > On 28/03/2023 04:19, Jacky Huang wrote: >> From: Jacky Huang <ychuang3@nuvoton.com> >> >> Add documentation to describe nuvoton ma35d1 uart driver bindings. >> > This depends on clock patches, so it must be taken together. > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > Best regards, > Krzysztof > OK, I will combine this patch with the clock patch. Best regards, Jacky Huang
On 29/03/2023 10:44, Jacky Huang wrote: > Dear Krzysztof, > > > Thanks for your review. > > > On 2023/3/29 下午 04:20, Krzysztof Kozlowski wrote: >> On 28/03/2023 04:19, Jacky Huang wrote: >>> From: Jacky Huang <ychuang3@nuvoton.com> >>> >>> Add documentation to describe nuvoton ma35d1 uart driver bindings. >>> >> This depends on clock patches, so it must be taken together. >> >> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> >> Best regards, >> Krzysztof >> > > OK, I will combine this patch with the clock patch. I don't know what you mean by "combine", but I don't think this is what we want. You must clearly state all dependencies and patch merging strategy/way. Best regards, Krzysztof
On 2023/3/30 下午 03:33, Krzysztof Kozlowski wrote: > On 29/03/2023 10:44, Jacky Huang wrote: >> Dear Krzysztof, >> >> >> Thanks for your review. >> >> >> On 2023/3/29 下午 04:20, Krzysztof Kozlowski wrote: >>> On 28/03/2023 04:19, Jacky Huang wrote: >>>> From: Jacky Huang <ychuang3@nuvoton.com> >>>> >>>> Add documentation to describe nuvoton ma35d1 uart driver bindings. >>>> >>> This depends on clock patches, so it must be taken together. >>> >>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >>> >>> Best regards, >>> Krzysztof >>> >> OK, I will combine this patch with the clock patch. > I don't know what you mean by "combine", but I don't think this is what > we want. You must clearly state all dependencies and patch merging > strategy/way. > > Best regards, > Krzysztof > Dear Krzysztof, I may be misunderstanding your request. I thought it was moving the "nuvoton,ma35d1-serial.yaml" to the patch of nuvoton,ma35d1-clk.h. Would you please provide guidance what should I do next on this [PATCH v6 07/12]. Thank you. Best regards, Jacky Huang
On Thu, Mar 30, 2023 at 06:52:11PM +0800, Jacky Huang wrote: > > > On 2023/3/30 下午 03:33, Krzysztof Kozlowski wrote: > > On 29/03/2023 10:44, Jacky Huang wrote: > > > Dear Krzysztof, > > > > > > > > > Thanks for your review. > > > > > > > > > On 2023/3/29 下午 04:20, Krzysztof Kozlowski wrote: > > > > On 28/03/2023 04:19, Jacky Huang wrote: > > > > > From: Jacky Huang <ychuang3@nuvoton.com> > > > > > > > > > > Add documentation to describe nuvoton ma35d1 uart driver bindings. > > > > > > > > > This depends on clock patches, so it must be taken together. > > > > > > > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > > > > > > > Best regards, > > > > Krzysztof > > > > > > > OK, I will combine this patch with the clock patch. > > I don't know what you mean by "combine", but I don't think this is what > > we want. You must clearly state all dependencies and patch merging > > strategy/way. > > > > Best regards, > > Krzysztof > > > > Dear Krzysztof, > > > I may be misunderstanding your request. > I thought it was moving the "nuvoton,ma35d1-serial.yaml" to the patch of > nuvoton,ma35d1-clk.h. > Would you please provide guidance what should I do next on this [PATCH v6 > 07/12]. Thank you. The only combining you should do is putting the 2 patches in the same series. Combining to 1 patch would be wrong. Your other option is just drop the header in the example and use the raw numbers. Then there is no dependency to manage and each subsystem maintainer can take the relevant patches. Rob
On 2023/3/30 下午 09:12, Rob Herring wrote: > On Thu, Mar 30, 2023 at 06:52:11PM +0800, Jacky Huang wrote: >> >> On 2023/3/30 下午 03:33, Krzysztof Kozlowski wrote: >>> On 29/03/2023 10:44, Jacky Huang wrote: >>>> Dear Krzysztof, >>>> >>>> >>>> Thanks for your review. >>>> >>>> >>>> On 2023/3/29 下午 04:20, Krzysztof Kozlowski wrote: >>>>> On 28/03/2023 04:19, Jacky Huang wrote: >>>>>> From: Jacky Huang <ychuang3@nuvoton.com> >>>>>> >>>>>> Add documentation to describe nuvoton ma35d1 uart driver bindings. >>>>>> >>>>> This depends on clock patches, so it must be taken together. >>>>> >>>>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >>>>> >>>>> Best regards, >>>>> Krzysztof >>>>> >>>> OK, I will combine this patch with the clock patch. >>> I don't know what you mean by "combine", but I don't think this is what >>> we want. You must clearly state all dependencies and patch merging >>> strategy/way. >>> >>> Best regards, >>> Krzysztof >>> >> Dear Krzysztof, >> >> >> I may be misunderstanding your request. >> I thought it was moving the "nuvoton,ma35d1-serial.yaml" to the patch of >> nuvoton,ma35d1-clk.h. >> Would you please provide guidance what should I do next on this [PATCH v6 >> 07/12]. Thank you. > The only combining you should do is putting the 2 patches in the same > series. Combining to 1 patch would be wrong. > > Your other option is just drop the header in the example and use the > raw numbers. Then there is no dependency to manage and each subsystem > maintainer can take the relevant patches. > > Rob Dear Rob, Thanks for your detailed explanation. I got it now. Best regards, Jacky Huang
diff --git a/Documentation/devicetree/bindings/serial/nuvoton,ma35d1-serial.yaml b/Documentation/devicetree/bindings/serial/nuvoton,ma35d1-serial.yaml new file mode 100644 index 000000000000..a76af0f6009b --- /dev/null +++ b/Documentation/devicetree/bindings/serial/nuvoton,ma35d1-serial.yaml @@ -0,0 +1,48 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/serial/nuvoton,ma35d1-serial.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Nuvoton MA35D1 Universal Asynchronous Receiver/Transmitter (UART) + +maintainers: + - Min-Jen Chen <mjchen@nuvoton.com> + - Jacky Huang <ychuang3@nuvoton.com> + +allOf: + - $ref: serial.yaml + +properties: + compatible: + const: nuvoton,ma35d1-uart + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + clocks: + maxItems: 1 + +required: + - compatible + - reg + - interrupts + - clocks + +unevaluatedProperties: false + +examples: + - | + #include <dt-bindings/interrupt-controller/arm-gic.h> + #include <dt-bindings/clock/nuvoton,ma35d1-clk.h> + + serial@40700000 { + compatible = "nuvoton,ma35d1-uart"; + reg = <0x40700000 0x100>; + interrupts = <GIC_SPI 59 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&clk UART0_GATE>; + }; +...