| Message ID | 20230330105502.4100351-1-jarkko.nikula@linux.intel.com |
|---|---|
| State | New |
| Headers | show |
| Series | [1/2] i2c: i801: Add support for Intel Meteor Lake-S SoC | expand |
Hi Jarkko, On Thu, 30 Mar 2023 13:55:01 +0300, Jarkko Nikula wrote: > Add SMBus PCI ID on Intel Meteor Lake-S SoC South. > > Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com> > --- > drivers/i2c/busses/i2c-i801.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c > index ac5326747c51..8172e2767b25 100644 > --- a/drivers/i2c/busses/i2c-i801.c > +++ b/drivers/i2c/busses/i2c-i801.c > @@ -77,6 +77,7 @@ > * Alder Lake-M (PCH) 0x54a3 32 hard yes yes yes > * Raptor Lake-S (PCH) 0x7a23 32 hard yes yes yes > * Meteor Lake-P (SOC) 0x7e22 32 hard yes yes yes > + * Meteor Lake-S (SOC) 0xae22 32 hard yes yes yes > * > * Features supported by this driver: > * Software PEC no > @@ -233,6 +234,7 @@ > #define PCI_DEVICE_ID_INTEL_RAPTOR_LAKE_S_SMBUS 0x7a23 > #define PCI_DEVICE_ID_INTEL_ALDER_LAKE_S_SMBUS 0x7aa3 > #define PCI_DEVICE_ID_INTEL_METEOR_LAKE_P_SMBUS 0x7e22 > +#define PCI_DEVICE_ID_INTEL_METEOR_LAKE_S_SMBUS 0xae22 > #define PCI_DEVICE_ID_INTEL_LYNXPOINT_SMBUS 0x8c22 > #define PCI_DEVICE_ID_INTEL_WILDCATPOINT_SMBUS 0x8ca2 > #define PCI_DEVICE_ID_INTEL_WELLSBURG_SMBUS 0x8d22 Sorry for nitpicking but since 34b57f40a6a2 ("i2c: i801: sort IDs alphabetically") this list is supposed to be sorted by ID. > @@ -1038,6 +1040,7 @@ static const struct pci_device_id i801_ids[] = { > { PCI_DEVICE_DATA(INTEL, ALDER_LAKE_M_SMBUS, FEATURES_ICH5 | FEATURE_TCO_CNL) }, > { PCI_DEVICE_DATA(INTEL, RAPTOR_LAKE_S_SMBUS, FEATURES_ICH5 | FEATURE_TCO_CNL) }, > { PCI_DEVICE_DATA(INTEL, METEOR_LAKE_P_SMBUS, FEATURES_ICH5 | FEATURE_TCO_CNL) }, > + { PCI_DEVICE_DATA(INTEL, METEOR_LAKE_S_SMBUS, FEATURES_ICH5 | FEATURE_TCO_CNL) }, > { 0, } > }; > Other than that, looks good. Reviewed-by: Jean Delvare <jdelvare@suse.de>
On 4/3/23 18:34, Jean Delvare wrote: > Hi Jarkko, > > On Thu, 30 Mar 2023 13:55:01 +0300, Jarkko Nikula wrote: >> Add SMBus PCI ID on Intel Meteor Lake-S SoC South. >> >> Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com> >> --- >> drivers/i2c/busses/i2c-i801.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c >> index ac5326747c51..8172e2767b25 100644 >> --- a/drivers/i2c/busses/i2c-i801.c >> +++ b/drivers/i2c/busses/i2c-i801.c >> @@ -77,6 +77,7 @@ >> * Alder Lake-M (PCH) 0x54a3 32 hard yes yes yes >> * Raptor Lake-S (PCH) 0x7a23 32 hard yes yes yes >> * Meteor Lake-P (SOC) 0x7e22 32 hard yes yes yes >> + * Meteor Lake-S (SOC) 0xae22 32 hard yes yes yes >> * >> * Features supported by this driver: >> * Software PEC no >> @@ -233,6 +234,7 @@ >> #define PCI_DEVICE_ID_INTEL_RAPTOR_LAKE_S_SMBUS 0x7a23 >> #define PCI_DEVICE_ID_INTEL_ALDER_LAKE_S_SMBUS 0x7aa3 >> #define PCI_DEVICE_ID_INTEL_METEOR_LAKE_P_SMBUS 0x7e22 >> +#define PCI_DEVICE_ID_INTEL_METEOR_LAKE_S_SMBUS 0xae22 >> #define PCI_DEVICE_ID_INTEL_LYNXPOINT_SMBUS 0x8c22 >> #define PCI_DEVICE_ID_INTEL_WILDCATPOINT_SMBUS 0x8ca2 >> #define PCI_DEVICE_ID_INTEL_WELLSBURG_SMBUS 0x8d22 > > Sorry for nitpicking but since 34b57f40a6a2 ("i2c: i801: sort IDs > alphabetically") this list is supposed to be sorted by ID. > Ah, true. Will fix and resend.
diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c index ac5326747c51..8172e2767b25 100644 --- a/drivers/i2c/busses/i2c-i801.c +++ b/drivers/i2c/busses/i2c-i801.c @@ -77,6 +77,7 @@ * Alder Lake-M (PCH) 0x54a3 32 hard yes yes yes * Raptor Lake-S (PCH) 0x7a23 32 hard yes yes yes * Meteor Lake-P (SOC) 0x7e22 32 hard yes yes yes + * Meteor Lake-S (SOC) 0xae22 32 hard yes yes yes * * Features supported by this driver: * Software PEC no @@ -233,6 +234,7 @@ #define PCI_DEVICE_ID_INTEL_RAPTOR_LAKE_S_SMBUS 0x7a23 #define PCI_DEVICE_ID_INTEL_ALDER_LAKE_S_SMBUS 0x7aa3 #define PCI_DEVICE_ID_INTEL_METEOR_LAKE_P_SMBUS 0x7e22 +#define PCI_DEVICE_ID_INTEL_METEOR_LAKE_S_SMBUS 0xae22 #define PCI_DEVICE_ID_INTEL_LYNXPOINT_SMBUS 0x8c22 #define PCI_DEVICE_ID_INTEL_WILDCATPOINT_SMBUS 0x8ca2 #define PCI_DEVICE_ID_INTEL_WELLSBURG_SMBUS 0x8d22 @@ -1038,6 +1040,7 @@ static const struct pci_device_id i801_ids[] = { { PCI_DEVICE_DATA(INTEL, ALDER_LAKE_M_SMBUS, FEATURES_ICH5 | FEATURE_TCO_CNL) }, { PCI_DEVICE_DATA(INTEL, RAPTOR_LAKE_S_SMBUS, FEATURES_ICH5 | FEATURE_TCO_CNL) }, { PCI_DEVICE_DATA(INTEL, METEOR_LAKE_P_SMBUS, FEATURES_ICH5 | FEATURE_TCO_CNL) }, + { PCI_DEVICE_DATA(INTEL, METEOR_LAKE_S_SMBUS, FEATURES_ICH5 | FEATURE_TCO_CNL) }, { 0, } };
Add SMBus PCI ID on Intel Meteor Lake-S SoC South. Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com> --- drivers/i2c/busses/i2c-i801.c | 3 +++ 1 file changed, 3 insertions(+)