| Message ID | 20230330063450.2289058-2-joychakr@google.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | spi: dw: DW SPI DMA Driver updates | expand |
On Thu, Mar 30, 2023 at 06:34:49AM +0000, Joy Chakraborty wrote: First of all the Subject is wrong. You are not touching DMA controller. Needs to be rephrased. > Add Support for AxSize = 4 bytes configuration from dw dma driver if SPI DMA driver (or something like this, note capital letters for acronyms). > n_bytes i.e. number of bytes per write to fifo is 3 or 4. > > Number of bytes written to fifo per write is depended on the bits/word > configuration being used which the DW core driver translates to n_bytes. ... > static enum dma_slave_buswidth dw_spi_dma_convert_width(u8 n_bytes) > { > - if (n_bytes == 1) > + switch (n_bytes) { > + case 1: > return DMA_SLAVE_BUSWIDTH_1_BYTE; > - else if (n_bytes == 2) > + case 2: > return DMA_SLAVE_BUSWIDTH_2_BYTES; > - > - return DMA_SLAVE_BUSWIDTH_UNDEFINED; > + case 3: I'm not sure about this. > + case 4: > + return DMA_SLAVE_BUSWIDTH_4_BYTES; > + default: > + return DMA_SLAVE_BUSWIDTH_UNDEFINED; > + } > }
On Tue, Apr 11, 2023 at 03:13:49PM +0300, Andy Shevchenko wrote: > On Thu, Mar 30, 2023 at 06:34:49AM +0000, Joy Chakraborty wrote: > > First of all the Subject is wrong. You are not touching DMA controller. > Needs to be rephrased. > > > Add Support for AxSize = 4 bytes configuration from dw dma driver if > > SPI DMA driver > > (or something like this, note capital letters for acronyms). > > > n_bytes i.e. number of bytes per write to fifo is 3 or 4. > > > > Number of bytes written to fifo per write is depended on the bits/word > > configuration being used which the DW core driver translates to n_bytes. > > ... > > > static enum dma_slave_buswidth dw_spi_dma_convert_width(u8 n_bytes) > > { > > - if (n_bytes == 1) > > + switch (n_bytes) { > > + case 1: > > return DMA_SLAVE_BUSWIDTH_1_BYTE; > > - else if (n_bytes == 2) > > + case 2: > > return DMA_SLAVE_BUSWIDTH_2_BYTES; > > - > > - return DMA_SLAVE_BUSWIDTH_UNDEFINED; > > > + case 3: > > I'm not sure about this. This actually makes sense seeing the function argument can have values 1, 2, _3_ and 4: dws->n_bytes = DIV_ROUND_UP(transfer->bits_per_word, BITS_PER_BYTE); transfer->bits_per_word = __F__(master->bits_per_word_mask = SPI_BPW_RANGE_MASK(4, 32)); ... dw_spi_dma_convert_width(dws->n_bytes) The spi_transfer.bits_per_word field value depends on the SPI peripheral device communication protocol requirements which may imply the 3-bytes word xfers (even though it's indeed unluckily). This semantic will also match to what we currently have in the IRQ-based SPI-transfer implementation (see dw_writer() and dw_reader()). -Serge(y) > > > + case 4: > > + return DMA_SLAVE_BUSWIDTH_4_BYTES; > > + default: > > + return DMA_SLAVE_BUSWIDTH_UNDEFINED; > > + } > > } > > -- > With Best Regards, > Andy Shevchenko > >
Hello Andy, On Tue, Apr 11, 2023 at 7:41 PM Serge Semin <fancer.lancer@gmail.com> wrote: > > On Tue, Apr 11, 2023 at 03:13:49PM +0300, Andy Shevchenko wrote: > > On Thu, Mar 30, 2023 at 06:34:49AM +0000, Joy Chakraborty wrote: > > > > First of all the Subject is wrong. You are not touching DMA controller. > > Needs to be rephrased. Sure, will rephrase this to "SPI DMA Driver" instead of controller. > > > > > Add Support for AxSize = 4 bytes configuration from dw dma driver if > > > > SPI DMA driver > > > > (or something like this, note capital letters for acronyms). > > > > > n_bytes i.e. number of bytes per write to fifo is 3 or 4. > > > > > > Number of bytes written to fifo per write is depended on the bits/word > > > configuration being used which the DW core driver translates to n_bytes. > > > > ... > > > > > static enum dma_slave_buswidth dw_spi_dma_convert_width(u8 n_bytes) > > > { > > > - if (n_bytes == 1) > > > + switch (n_bytes) { > > > + case 1: > > > return DMA_SLAVE_BUSWIDTH_1_BYTE; > > > - else if (n_bytes == 2) > > > + case 2: > > > return DMA_SLAVE_BUSWIDTH_2_BYTES; > > > - > > > - return DMA_SLAVE_BUSWIDTH_UNDEFINED; > > > > > + case 3: > > > > I'm not sure about this. > > This actually makes sense seeing the function argument can have values > 1, 2, _3_ and 4: > dws->n_bytes = DIV_ROUND_UP(transfer->bits_per_word, BITS_PER_BYTE); > transfer->bits_per_word = __F__(master->bits_per_word_mask = SPI_BPW_RANGE_MASK(4, 32)); > ... > dw_spi_dma_convert_width(dws->n_bytes) > > The spi_transfer.bits_per_word field value depends on the > SPI peripheral device communication protocol requirements which may > imply the 3-bytes word xfers (even though it's indeed unluckily). > > This semantic will also match to what we currently have in the > IRQ-based SPI-transfer implementation (see dw_writer() and > dw_reader()). > > -Serge(y) > Will keep this as is to be similar to dw_writer() / dw_reader() as explained by Serge(y). > > > > > + case 4: > > > + return DMA_SLAVE_BUSWIDTH_4_BYTES; > > > + default: > > > + return DMA_SLAVE_BUSWIDTH_UNDEFINED; > > > + } > > > } > > > > -- > > With Best Regards, > > Andy Shevchenko > > > > I shall create another patch series with the same. Thanks Joy
On Tue, Apr 11, 2023 at 08:00:23PM +0530, Joy Chakraborty wrote: > Hello Andy, > > On Tue, Apr 11, 2023 at 7:41 PM Serge Semin <fancer.lancer@gmail.com> wrote: > > > > On Tue, Apr 11, 2023 at 03:13:49PM +0300, Andy Shevchenko wrote: > > > On Thu, Mar 30, 2023 at 06:34:49AM +0000, Joy Chakraborty wrote: > > > > > > First of all the Subject is wrong. You are not touching DMA controller. > > > Needs to be rephrased. > > Sure, will rephrase this to "SPI DMA Driver" instead of controller. > > > > > > > > Add Support for AxSize = 4 bytes configuration from dw dma driver if > > > > > > SPI DMA driver > > > > > > (or something like this, note capital letters for acronyms). > > > > > > > n_bytes i.e. number of bytes per write to fifo is 3 or 4. > > > > > > > > Number of bytes written to fifo per write is depended on the bits/word > > > > configuration being used which the DW core driver translates to n_bytes. > > > > > > ... > > > > > > > static enum dma_slave_buswidth dw_spi_dma_convert_width(u8 n_bytes) > > > > { > > > > - if (n_bytes == 1) > > > > + switch (n_bytes) { > > > > + case 1: > > > > return DMA_SLAVE_BUSWIDTH_1_BYTE; > > > > - else if (n_bytes == 2) > > > > + case 2: > > > > return DMA_SLAVE_BUSWIDTH_2_BYTES; > > > > - > > > > - return DMA_SLAVE_BUSWIDTH_UNDEFINED; > > > > > > > + case 3: > > > > > > I'm not sure about this. > > > > This actually makes sense seeing the function argument can have values > > 1, 2, _3_ and 4: > > dws->n_bytes = DIV_ROUND_UP(transfer->bits_per_word, BITS_PER_BYTE); > > transfer->bits_per_word = __F__(master->bits_per_word_mask = SPI_BPW_RANGE_MASK(4, 32)); > > ... > > dw_spi_dma_convert_width(dws->n_bytes) > > > > The spi_transfer.bits_per_word field value depends on the > > SPI peripheral device communication protocol requirements which may > > imply the 3-bytes word xfers (even though it's indeed unluckily). > > > > This semantic will also match to what we currently have in the > > IRQ-based SPI-transfer implementation (see dw_writer() and > > dw_reader()). > > > > -Serge(y) > > > > Will keep this as is to be similar to dw_writer() / dw_reader() as > explained by Serge(y). > > > > > > > > + case 4: > > > > + return DMA_SLAVE_BUSWIDTH_4_BYTES; > > > > + default: > > > > + return DMA_SLAVE_BUSWIDTH_UNDEFINED; > > > > + } > > > > } > > > > > > -- > > > With Best Regards, > > > Andy Shevchenko > > > > > > > > I shall create another patch series with the same. Hold on for Andy to respond please. -Serge(y) > > Thanks > Joy
On Tue, Apr 11, 2023 at 05:11:15PM +0300, Serge Semin wrote: > On Tue, Apr 11, 2023 at 03:13:49PM +0300, Andy Shevchenko wrote: > > On Thu, Mar 30, 2023 at 06:34:49AM +0000, Joy Chakraborty wrote: ... > > > - if (n_bytes == 1) > > > + switch (n_bytes) { > > > + case 1: > > > return DMA_SLAVE_BUSWIDTH_1_BYTE; > > > - else if (n_bytes == 2) > > > + case 2: > > > return DMA_SLAVE_BUSWIDTH_2_BYTES; > > > - > > > - return DMA_SLAVE_BUSWIDTH_UNDEFINED; > > > > > + case 3: > > > > I'm not sure about this. > > This actually makes sense seeing the function argument can have values > 1, 2, _3_ and 4: > dws->n_bytes = DIV_ROUND_UP(transfer->bits_per_word, BITS_PER_BYTE); > transfer->bits_per_word = __F__(master->bits_per_word_mask = SPI_BPW_RANGE_MASK(4, 32)); > ... > dw_spi_dma_convert_width(dws->n_bytes) > > The spi_transfer.bits_per_word field value depends on the > SPI peripheral device communication protocol requirements which may > imply the 3-bytes word xfers (even though it's indeed unluckily). > > This semantic will also match to what we currently have in the > IRQ-based SPI-transfer implementation (see dw_writer() and > dw_reader()). Nice, but we have DMA_SLAVE_BUSWIDTH_3_BYTES definition for that. Why we don't use it? > > > + case 4: > > > + return DMA_SLAVE_BUSWIDTH_4_BYTES; > > > + default: > > > + return DMA_SLAVE_BUSWIDTH_UNDEFINED; > > > + }
On Tue, Apr 11, 2023 at 05:46:34PM +0300, Andy Shevchenko wrote: > On Tue, Apr 11, 2023 at 05:11:15PM +0300, Serge Semin wrote: > > On Tue, Apr 11, 2023 at 03:13:49PM +0300, Andy Shevchenko wrote: > > > On Thu, Mar 30, 2023 at 06:34:49AM +0000, Joy Chakraborty wrote: > > ... > > > > > - if (n_bytes == 1) > > > > + switch (n_bytes) { > > > > + case 1: > > > > return DMA_SLAVE_BUSWIDTH_1_BYTE; > > > > - else if (n_bytes == 2) > > > > + case 2: > > > > return DMA_SLAVE_BUSWIDTH_2_BYTES; > > > > - > > > > - return DMA_SLAVE_BUSWIDTH_UNDEFINED; > > > > > > > + case 3: > > > > > > I'm not sure about this. > > > > This actually makes sense seeing the function argument can have values > > 1, 2, _3_ and 4: > > dws->n_bytes = DIV_ROUND_UP(transfer->bits_per_word, BITS_PER_BYTE); > > transfer->bits_per_word = __F__(master->bits_per_word_mask = SPI_BPW_RANGE_MASK(4, 32)); > > ... > > dw_spi_dma_convert_width(dws->n_bytes) > > > > The spi_transfer.bits_per_word field value depends on the > > SPI peripheral device communication protocol requirements which may > > imply the 3-bytes word xfers (even though it's indeed unluckily). > > > > This semantic will also match to what we currently have in the > > IRQ-based SPI-transfer implementation (see dw_writer() and > > dw_reader()). > > Nice, but we have DMA_SLAVE_BUSWIDTH_3_BYTES definition for that. Why we don't > use it? We could but there are two more-or-less firm reasons not to do that: 1. There aren't that much DMA-engines with the DMA_SLAVE_BUSWIDTH_3_BYTES capability meanwhile the DW APB SSI just ignores the upper bits if CTRLR0.DFS is less than the value actual written to the DR registers. Note DW DMAC engine isn't one of such controllers. So if we get to meet a peripheral SPI-device with 3-bytes word protocol transfers and the DMA-engine doesn't support it the DMA-based transfers may fail (depending on the DMA-engine driver implementation). 2. The DW APB SSIs (3.x and 4.x) can be synthesized with the APB Data Bus Width of 8, 16 and 32. So no matter whether DMA-engine supports the 3-bytes bus width the system bus most likely will either convert the transfers to the proper sized bus-transactions or fail. So taking all of the above into account not using the DMA_SLAVE_BUSWIDTH_3_BYTES macro here seems better than using it with a risk to fail some of the platform setups especially seeing the DW APB SSI ignores the upper bits anyway. -Serge(y) > > > > > + case 4: > > > > + return DMA_SLAVE_BUSWIDTH_4_BYTES; > > > > + default: > > > > + return DMA_SLAVE_BUSWIDTH_UNDEFINED; > > > > + } > > -- > With Best Regards, > Andy Shevchenko > >
On Tue, Apr 11, 2023 at 06:09:16PM +0300, Serge Semin wrote: > On Tue, Apr 11, 2023 at 05:46:34PM +0300, Andy Shevchenko wrote: > > On Tue, Apr 11, 2023 at 05:11:15PM +0300, Serge Semin wrote: > > > On Tue, Apr 11, 2023 at 03:13:49PM +0300, Andy Shevchenko wrote: > > > > On Thu, Mar 30, 2023 at 06:34:49AM +0000, Joy Chakraborty wrote: ... > > > > > - if (n_bytes == 1) > > > > > + switch (n_bytes) { > > > > > + case 1: > > > > > return DMA_SLAVE_BUSWIDTH_1_BYTE; > > > > > - else if (n_bytes == 2) > > > > > + case 2: > > > > > return DMA_SLAVE_BUSWIDTH_2_BYTES; > > > > > - > > > > > - return DMA_SLAVE_BUSWIDTH_UNDEFINED; > > > > > > > > > + case 3: > > > > > > > > I'm not sure about this. > > > > > > This actually makes sense seeing the function argument can have values > > > 1, 2, _3_ and 4: > > > dws->n_bytes = DIV_ROUND_UP(transfer->bits_per_word, BITS_PER_BYTE); > > > transfer->bits_per_word = __F__(master->bits_per_word_mask = SPI_BPW_RANGE_MASK(4, 32)); > > > ... > > > dw_spi_dma_convert_width(dws->n_bytes) > > > > > > The spi_transfer.bits_per_word field value depends on the > > > SPI peripheral device communication protocol requirements which may > > > imply the 3-bytes word xfers (even though it's indeed unluckily). > > > > > > This semantic will also match to what we currently have in the > > > IRQ-based SPI-transfer implementation (see dw_writer() and > > > dw_reader()). > > > Nice, but we have DMA_SLAVE_BUSWIDTH_3_BYTES definition for that. Why we don't > > use it? > > We could but there are two more-or-less firm reasons not to do > that: > 1. There aren't that much DMA-engines with the > DMA_SLAVE_BUSWIDTH_3_BYTES capability meanwhile the DW APB SSI just > ignores the upper bits if CTRLR0.DFS is less than the value actual > written to the DR registers. Note DW DMAC engine isn't one of such > controllers. So if we get to meet a peripheral SPI-device with 3-bytes > word protocol transfers and the DMA-engine doesn't support it the > DMA-based transfers may fail (depending on the DMA-engine driver > implementation). > 2. The DW APB SSIs (3.x and 4.x) can be synthesized with the APB Data > Bus Width of 8, 16 and 32. So no matter whether DMA-engine supports > the 3-bytes bus width the system bus most likely will either convert > the transfers to the proper sized bus-transactions or fail. > > So taking all of the above into account not using the > DMA_SLAVE_BUSWIDTH_3_BYTES macro here seems better than using it with > a risk to fail some of the platform setups especially seeing the DW > APB SSI ignores the upper bits anyway. But this is not about SPI host hardware, it's about the consumers. They should know about supported sizes. Either we add the corresponding support to the driver or remove 3 case as I suggested. I don't think it's correct to use 3 as 4. > > > > > + case 4: > > > > > + return DMA_SLAVE_BUSWIDTH_4_BYTES; > > > > > + default: > > > > > + return DMA_SLAVE_BUSWIDTH_UNDEFINED; > > > > > + }
On Tue, Apr 11, 2023 at 8:47 PM Andy Shevchenko <andriy.shevchenko@intel.com> wrote: > > On Tue, Apr 11, 2023 at 06:09:16PM +0300, Serge Semin wrote: > > On Tue, Apr 11, 2023 at 05:46:34PM +0300, Andy Shevchenko wrote: > > > On Tue, Apr 11, 2023 at 05:11:15PM +0300, Serge Semin wrote: > > > > On Tue, Apr 11, 2023 at 03:13:49PM +0300, Andy Shevchenko wrote: > > > > > On Thu, Mar 30, 2023 at 06:34:49AM +0000, Joy Chakraborty wrote: > > ... > > > > > > > - if (n_bytes == 1) > > > > > > + switch (n_bytes) { > > > > > > + case 1: > > > > > > return DMA_SLAVE_BUSWIDTH_1_BYTE; > > > > > > - else if (n_bytes == 2) > > > > > > + case 2: > > > > > > return DMA_SLAVE_BUSWIDTH_2_BYTES; > > > > > > - > > > > > > - return DMA_SLAVE_BUSWIDTH_UNDEFINED; > > > > > > > > > > > + case 3: > > > > > > > > > > I'm not sure about this. > > > > > > > > This actually makes sense seeing the function argument can have values > > > > 1, 2, _3_ and 4: > > > > dws->n_bytes = DIV_ROUND_UP(transfer->bits_per_word, BITS_PER_BYTE); > > > > transfer->bits_per_word = __F__(master->bits_per_word_mask = SPI_BPW_RANGE_MASK(4, 32)); > > > > ... > > > > dw_spi_dma_convert_width(dws->n_bytes) > > > > > > > > The spi_transfer.bits_per_word field value depends on the > > > > SPI peripheral device communication protocol requirements which may > > > > imply the 3-bytes word xfers (even though it's indeed unluckily). > > > > > > > > This semantic will also match to what we currently have in the > > > > IRQ-based SPI-transfer implementation (see dw_writer() and > > > > dw_reader()). > > > > > Nice, but we have DMA_SLAVE_BUSWIDTH_3_BYTES definition for that. Why we don't > > > use it? > > > > We could but there are two more-or-less firm reasons not to do > > that: > > 1. There aren't that much DMA-engines with the > > DMA_SLAVE_BUSWIDTH_3_BYTES capability meanwhile the DW APB SSI just > > ignores the upper bits if CTRLR0.DFS is less than the value actual > > written to the DR registers. Note DW DMAC engine isn't one of such > > controllers. So if we get to meet a peripheral SPI-device with 3-bytes > > word protocol transfers and the DMA-engine doesn't support it the > > DMA-based transfers may fail (depending on the DMA-engine driver > > implementation). > > 2. The DW APB SSIs (3.x and 4.x) can be synthesized with the APB Data > > Bus Width of 8, 16 and 32. So no matter whether DMA-engine supports > > the 3-bytes bus width the system bus most likely will either convert > > the transfers to the proper sized bus-transactions or fail. > > > > So taking all of the above into account not using the > > DMA_SLAVE_BUSWIDTH_3_BYTES macro here seems better than using it with > > a risk to fail some of the platform setups especially seeing the DW > > APB SSI ignores the upper bits anyway. > > But this is not about SPI host hardware, it's about the consumers. > They should know about supported sizes. Either we add the corresponding support > to the driver or remove 3 case as I suggested. I don't think it's correct to > use 3 as 4. Another thing to add is that as per spi.h even if bits per word is a not a power of 2 the buffer should be formatted in memory as a power of 2 ... * @bits_per_word: Data transfers involve one or more words; word sizes * like eight or 12 bits are common. In-memory wordsizes are * powers of two bytes (e.g. 20 bit samples use 32 bits). * This may be changed by the device's driver, or left at the * default (0) indicating protocol words are eight bit bytes. * The spi_transfer.bits_per_word can override this for each transfer. ... Hence for n_bytes = 3 or 24 bits/per word we expect the client SW to format it to 4 byte buffers hence the transaction generated should also be of size 4 from the DMA. > > > > > > > + case 4: > > > > > > + return DMA_SLAVE_BUSWIDTH_4_BYTES; > > > > > > + default: > > > > > > + return DMA_SLAVE_BUSWIDTH_UNDEFINED; > > > > > > + } > > -- > With Best Regards, > Andy Shevchenko > > Thanks Joy
On Tue, Apr 11, 2023 at 08:48:52PM +0530, Joy Chakraborty wrote: > On Tue, Apr 11, 2023 at 8:47 PM Andy Shevchenko > <andriy.shevchenko@intel.com> wrote: > > On Tue, Apr 11, 2023 at 06:09:16PM +0300, Serge Semin wrote: > > > On Tue, Apr 11, 2023 at 05:46:34PM +0300, Andy Shevchenko wrote: > > > > On Tue, Apr 11, 2023 at 05:11:15PM +0300, Serge Semin wrote: > > > > > On Tue, Apr 11, 2023 at 03:13:49PM +0300, Andy Shevchenko wrote: > > > > > > On Thu, Mar 30, 2023 at 06:34:49AM +0000, Joy Chakraborty wrote: ... > > > > > > > - if (n_bytes == 1) > > > > > > > + switch (n_bytes) { > > > > > > > + case 1: > > > > > > > return DMA_SLAVE_BUSWIDTH_1_BYTE; > > > > > > > - else if (n_bytes == 2) > > > > > > > + case 2: > > > > > > > return DMA_SLAVE_BUSWIDTH_2_BYTES; > > > > > > > - > > > > > > > - return DMA_SLAVE_BUSWIDTH_UNDEFINED; > > > > > > > > > > > > > + case 3: > > > > > > > > > > > > I'm not sure about this. > > > > > > > > > > This actually makes sense seeing the function argument can have values > > > > > 1, 2, _3_ and 4: > > > > > dws->n_bytes = DIV_ROUND_UP(transfer->bits_per_word, BITS_PER_BYTE); > > > > > transfer->bits_per_word = __F__(master->bits_per_word_mask = SPI_BPW_RANGE_MASK(4, 32)); > > > > > ... > > > > > dw_spi_dma_convert_width(dws->n_bytes) > > > > > > > > > > The spi_transfer.bits_per_word field value depends on the > > > > > SPI peripheral device communication protocol requirements which may > > > > > imply the 3-bytes word xfers (even though it's indeed unluckily). > > > > > > > > > > This semantic will also match to what we currently have in the > > > > > IRQ-based SPI-transfer implementation (see dw_writer() and > > > > > dw_reader()). > > > > > > > Nice, but we have DMA_SLAVE_BUSWIDTH_3_BYTES definition for that. Why we don't > > > > use it? > > > > > > We could but there are two more-or-less firm reasons not to do > > > that: > > > 1. There aren't that much DMA-engines with the > > > DMA_SLAVE_BUSWIDTH_3_BYTES capability meanwhile the DW APB SSI just > > > ignores the upper bits if CTRLR0.DFS is less than the value actual > > > written to the DR registers. Note DW DMAC engine isn't one of such > > > controllers. So if we get to meet a peripheral SPI-device with 3-bytes > > > word protocol transfers and the DMA-engine doesn't support it the > > > DMA-based transfers may fail (depending on the DMA-engine driver > > > implementation). > > > 2. The DW APB SSIs (3.x and 4.x) can be synthesized with the APB Data > > > Bus Width of 8, 16 and 32. So no matter whether DMA-engine supports > > > the 3-bytes bus width the system bus most likely will either convert > > > the transfers to the proper sized bus-transactions or fail. > > > > > > So taking all of the above into account not using the > > > DMA_SLAVE_BUSWIDTH_3_BYTES macro here seems better than using it with > > > a risk to fail some of the platform setups especially seeing the DW > > > APB SSI ignores the upper bits anyway. > > > > But this is not about SPI host hardware, it's about the consumers. > > They should know about supported sizes. Either we add the corresponding support > > to the driver or remove 3 case as I suggested. I don't think it's correct to > > use 3 as 4. > > Another thing to add is that as per spi.h even if bits per word is a > not a power of 2 the buffer should be formatted in memory as a power > of 2 > ... > * @bits_per_word: Data transfers involve one or more words; word sizes > * like eight or 12 bits are common. In-memory wordsizes are > * powers of two bytes (e.g. 20 bit samples use 32 bits). > * This may be changed by the device's driver, or left at the > * default (0) indicating protocol words are eight bit bytes. > * The spi_transfer.bits_per_word can override this for each transfer. > ... > Hence for n_bytes = 3 or 24 bits/per word we expect the client SW to > format it to 4 byte buffers hence the transaction generated should > also be of size 4 from the DMA. You didn't get my point. The consumer wants to know if the 3 bytes is supported or not, that's should be part of the DMA related thing, right? It's incorrectly to say 4 for 3 if the backend DMA controller behaves differently on this. How do you know that (any) DMA controller integrated with this hardware has no side effects for this change. So, I don't think the case 3 is correct in this patch. > > > > > > > + case 4: > > > > > > > + return DMA_SLAVE_BUSWIDTH_4_BYTES; > > > > > > > + default: > > > > > > > + return DMA_SLAVE_BUSWIDTH_UNDEFINED; > > > > > > > + }
On Tue, Apr 11, 2023 at 9:52 PM Andy Shevchenko <andriy.shevchenko@intel.com> wrote: > > On Tue, Apr 11, 2023 at 08:48:52PM +0530, Joy Chakraborty wrote: > > On Tue, Apr 11, 2023 at 8:47 PM Andy Shevchenko > > <andriy.shevchenko@intel.com> wrote: > > > On Tue, Apr 11, 2023 at 06:09:16PM +0300, Serge Semin wrote: > > > > On Tue, Apr 11, 2023 at 05:46:34PM +0300, Andy Shevchenko wrote: > > > > > On Tue, Apr 11, 2023 at 05:11:15PM +0300, Serge Semin wrote: > > > > > > On Tue, Apr 11, 2023 at 03:13:49PM +0300, Andy Shevchenko wrote: > > > > > > > On Thu, Mar 30, 2023 at 06:34:49AM +0000, Joy Chakraborty wrote: > > ... > > > > > > > > > - if (n_bytes == 1) > > > > > > > > + switch (n_bytes) { > > > > > > > > + case 1: > > > > > > > > return DMA_SLAVE_BUSWIDTH_1_BYTE; > > > > > > > > - else if (n_bytes == 2) > > > > > > > > + case 2: > > > > > > > > return DMA_SLAVE_BUSWIDTH_2_BYTES; > > > > > > > > - > > > > > > > > - return DMA_SLAVE_BUSWIDTH_UNDEFINED; > > > > > > > > > > > > > > > + case 3: > > > > > > > > > > > > > > I'm not sure about this. > > > > > > > > > > > > This actually makes sense seeing the function argument can have values > > > > > > 1, 2, _3_ and 4: > > > > > > dws->n_bytes = DIV_ROUND_UP(transfer->bits_per_word, BITS_PER_BYTE); > > > > > > transfer->bits_per_word = __F__(master->bits_per_word_mask = SPI_BPW_RANGE_MASK(4, 32)); > > > > > > ... > > > > > > dw_spi_dma_convert_width(dws->n_bytes) > > > > > > > > > > > > The spi_transfer.bits_per_word field value depends on the > > > > > > SPI peripheral device communication protocol requirements which may > > > > > > imply the 3-bytes word xfers (even though it's indeed unluckily). > > > > > > > > > > > > This semantic will also match to what we currently have in the > > > > > > IRQ-based SPI-transfer implementation (see dw_writer() and > > > > > > dw_reader()). > > > > > > > > > Nice, but we have DMA_SLAVE_BUSWIDTH_3_BYTES definition for that. Why we don't > > > > > use it? > > > > > > > > We could but there are two more-or-less firm reasons not to do > > > > that: > > > > 1. There aren't that much DMA-engines with the > > > > DMA_SLAVE_BUSWIDTH_3_BYTES capability meanwhile the DW APB SSI just > > > > ignores the upper bits if CTRLR0.DFS is less than the value actual > > > > written to the DR registers. Note DW DMAC engine isn't one of such > > > > controllers. So if we get to meet a peripheral SPI-device with 3-bytes > > > > word protocol transfers and the DMA-engine doesn't support it the > > > > DMA-based transfers may fail (depending on the DMA-engine driver > > > > implementation). > > > > 2. The DW APB SSIs (3.x and 4.x) can be synthesized with the APB Data > > > > Bus Width of 8, 16 and 32. So no matter whether DMA-engine supports > > > > the 3-bytes bus width the system bus most likely will either convert > > > > the transfers to the proper sized bus-transactions or fail. > > > > > > > > So taking all of the above into account not using the > > > > DMA_SLAVE_BUSWIDTH_3_BYTES macro here seems better than using it with > > > > a risk to fail some of the platform setups especially seeing the DW > > > > APB SSI ignores the upper bits anyway. > > > > > > But this is not about SPI host hardware, it's about the consumers. > > > They should know about supported sizes. Either we add the corresponding support > > > to the driver or remove 3 case as I suggested. I don't think it's correct to > > > use 3 as 4. > > > > Another thing to add is that as per spi.h even if bits per word is a > > not a power of 2 the buffer should be formatted in memory as a power > > of 2 > > ... > > * @bits_per_word: Data transfers involve one or more words; word sizes > > * like eight or 12 bits are common. In-memory wordsizes are > > * powers of two bytes (e.g. 20 bit samples use 32 bits). > > * This may be changed by the device's driver, or left at the > > * default (0) indicating protocol words are eight bit bytes. > > * The spi_transfer.bits_per_word can override this for each transfer. > > ... > > Hence for n_bytes = 3 or 24 bits/per word we expect the client SW to > > format it to 4 byte buffers hence the transaction generated should > > also be of size 4 from the DMA. > > You didn't get my point. The consumer wants to know if the 3 bytes is supported > or not, that's should be part of the DMA related thing, right? > > It's incorrectly to say 4 for 3 if the backend DMA controller behaves differently > on this. How do you know that (any) DMA controller integrated with this hardware > has no side effects for this change. > > So, I don't think the case 3 is correct in this patch. I see, I am of the opposite opinion in this case. Other then Serge(y)'s points, I was trying to say that irrespective of what the underlying DMA controller supports we should use DMA_SLAVE_BUSWIDTH_4_BYTES when n_bytes = 3 from SPI perspective as we get n_bytes from bits per word passed by the client / spi framework " dws->n_bytes = DIV_ROUND_UP(transfer->bits_per_word, BITS_PER_BYTE) ". Based on the spi header what I perceive is that for bits/word between 17 and 32 the data has to be stored in 32bit words in memory as per the example in the header " (e.g. 20 bit samples use 32 bits) ". Hence, taking an example to transfer 6 bytes (say 0xAA 0xBB 0xCC 0xDD 0xEE 0xFF) with bits per word as 24 (n_bytes = 3) i.e. a total of 2 words I expect the buffer to look as follows which is coming from the client: _ _____address|__________0________4________8________C SD:00000000|>00CCBBAA 00FFEEDD 00000000 00000000 Hence to transfer this successfully the DMA controller would need to copy 4 bytes per word . Please correct me if my understanding of this is incorrect. > > > > > > > > > + case 4: > > > > > > > > + return DMA_SLAVE_BUSWIDTH_4_BYTES; > > > > > > > > + default: > > > > > > > > + return DMA_SLAVE_BUSWIDTH_UNDEFINED; > > > > > > > > + } > > -- > With Best Regards, > Andy Shevchenko > > Thanks Joy
On Wed, Apr 12, 2023 at 1:11 AM Joy Chakraborty <joychakr@google.com> wrote: > > On Tue, Apr 11, 2023 at 9:52 PM Andy Shevchenko > <andriy.shevchenko@intel.com> wrote: > > > > On Tue, Apr 11, 2023 at 08:48:52PM +0530, Joy Chakraborty wrote: > > > On Tue, Apr 11, 2023 at 8:47 PM Andy Shevchenko > > > <andriy.shevchenko@intel.com> wrote: > > > > On Tue, Apr 11, 2023 at 06:09:16PM +0300, Serge Semin wrote: > > > > > On Tue, Apr 11, 2023 at 05:46:34PM +0300, Andy Shevchenko wrote: > > > > > > On Tue, Apr 11, 2023 at 05:11:15PM +0300, Serge Semin wrote: > > > > > > > On Tue, Apr 11, 2023 at 03:13:49PM +0300, Andy Shevchenko wrote: > > > > > > > > On Thu, Mar 30, 2023 at 06:34:49AM +0000, Joy Chakraborty wrote: > > > > ... > > > > > > > > > > > - if (n_bytes == 1) > > > > > > > > > + switch (n_bytes) { > > > > > > > > > + case 1: > > > > > > > > > return DMA_SLAVE_BUSWIDTH_1_BYTE; > > > > > > > > > - else if (n_bytes == 2) > > > > > > > > > + case 2: > > > > > > > > > return DMA_SLAVE_BUSWIDTH_2_BYTES; > > > > > > > > > - > > > > > > > > > - return DMA_SLAVE_BUSWIDTH_UNDEFINED; > > > > > > > > > > > > > > > > > + case 3: > > > > > > > > > > > > > > > > I'm not sure about this. > > > > > > > > > > > > > > This actually makes sense seeing the function argument can have values > > > > > > > 1, 2, _3_ and 4: > > > > > > > dws->n_bytes = DIV_ROUND_UP(transfer->bits_per_word, BITS_PER_BYTE); > > > > > > > transfer->bits_per_word = __F__(master->bits_per_word_mask = SPI_BPW_RANGE_MASK(4, 32)); > > > > > > > ... > > > > > > > dw_spi_dma_convert_width(dws->n_bytes) > > > > > > > > > > > > > > The spi_transfer.bits_per_word field value depends on the > > > > > > > SPI peripheral device communication protocol requirements which may > > > > > > > imply the 3-bytes word xfers (even though it's indeed unluckily). > > > > > > > > > > > > > > This semantic will also match to what we currently have in the > > > > > > > IRQ-based SPI-transfer implementation (see dw_writer() and > > > > > > > dw_reader()). > > > > > > > > > > > Nice, but we have DMA_SLAVE_BUSWIDTH_3_BYTES definition for that. Why we don't > > > > > > use it? > > > > > > > > > > We could but there are two more-or-less firm reasons not to do > > > > > that: > > > > > 1. There aren't that much DMA-engines with the > > > > > DMA_SLAVE_BUSWIDTH_3_BYTES capability meanwhile the DW APB SSI just > > > > > ignores the upper bits if CTRLR0.DFS is less than the value actual > > > > > written to the DR registers. Note DW DMAC engine isn't one of such > > > > > controllers. So if we get to meet a peripheral SPI-device with 3-bytes > > > > > word protocol transfers and the DMA-engine doesn't support it the > > > > > DMA-based transfers may fail (depending on the DMA-engine driver > > > > > implementation). > > > > > 2. The DW APB SSIs (3.x and 4.x) can be synthesized with the APB Data > > > > > Bus Width of 8, 16 and 32. So no matter whether DMA-engine supports > > > > > the 3-bytes bus width the system bus most likely will either convert > > > > > the transfers to the proper sized bus-transactions or fail. > > > > > > > > > > So taking all of the above into account not using the > > > > > DMA_SLAVE_BUSWIDTH_3_BYTES macro here seems better than using it with > > > > > a risk to fail some of the platform setups especially seeing the DW > > > > > APB SSI ignores the upper bits anyway. > > > > > > > > But this is not about SPI host hardware, it's about the consumers. > > > > They should know about supported sizes. Either we add the corresponding support > > > > to the driver or remove 3 case as I suggested. I don't think it's correct to > > > > use 3 as 4. > > > > > > Another thing to add is that as per spi.h even if bits per word is a > > > not a power of 2 the buffer should be formatted in memory as a power > > > of 2 > > > ... > > > * @bits_per_word: Data transfers involve one or more words; word sizes > > > * like eight or 12 bits are common. In-memory wordsizes are > > > * powers of two bytes (e.g. 20 bit samples use 32 bits). > > > * This may be changed by the device's driver, or left at the > > > * default (0) indicating protocol words are eight bit bytes. > > > * The spi_transfer.bits_per_word can override this for each transfer. > > > ... > > > Hence for n_bytes = 3 or 24 bits/per word we expect the client SW to > > > format it to 4 byte buffers hence the transaction generated should > > > also be of size 4 from the DMA. > > > > You didn't get my point. The consumer wants to know if the 3 bytes is supported > > or not, that's should be part of the DMA related thing, right? > > > > It's incorrectly to say 4 for 3 if the backend DMA controller behaves differently > > on this. How do you know that (any) DMA controller integrated with this hardware > > has no side effects for this change. > > > > So, I don't think the case 3 is correct in this patch. > > I see, I am of the opposite opinion in this case. > > Other then Serge(y)'s points, > I was trying to say that irrespective of what the underlying DMA > controller supports we should use DMA_SLAVE_BUSWIDTH_4_BYTES when > n_bytes = 3 from SPI perspective as we get n_bytes from bits per word > passed by the client / spi framework " dws->n_bytes = > DIV_ROUND_UP(transfer->bits_per_word, BITS_PER_BYTE) ". > Based on the spi header what I perceive is that for bits/word between > 17 and 32 the data has to be stored in 32bit words in memory as per > the example in the header " (e.g. 20 bit samples use 32 bits) ". > > Hence, taking an example to transfer 6 bytes (say 0xAA 0xBB 0xCC 0xDD > 0xEE 0xFF) with bits per word as 24 (n_bytes = 3) i.e. a total of 2 > words I expect the buffer to look as follows which is coming from the > client: > _ _____address|__________0________4________8________C > SD:00000000|>00CCBBAA 00FFEEDD 00000000 00000000 > Hence to transfer this successfully the DMA controller would need to > copy 4 bytes per word . > > Please correct me if my understanding of this is incorrect. On the other hand I do see that in the fifo driver dw_writer() / dw_reader() increments the pointer with 3 incase n_bytes = 3 even though it copies 4 bytes. ... if (dws->n_bytes == 1) txw = *(u8 *)(dws->tx); else if (dws->n_bytes == 2) txw = *(u16 *)(dws->tx); else txw = *(u32 *)(dws->tx); dws->tx += dws->n_bytes; ... This will not behave as using DMA_SLAVE_BUSWIDTH_4_BYTES in the DMA so maybe I am not correct in interpretting the spi.h header file. Can CPU's in general access u32 from unaligned odd addresses ?
On Wed, Apr 12, 2023 at 02:51:44PM +0530, Joy Chakraborty wrote: > On Wed, Apr 12, 2023 at 1:11 AM Joy Chakraborty <joychakr@google.com> wrote: > > On Tue, Apr 11, 2023 at 9:52 PM Andy Shevchenko > > <andriy.shevchenko@intel.com> wrote: > > > On Tue, Apr 11, 2023 at 08:48:52PM +0530, Joy Chakraborty wrote: > > > > On Tue, Apr 11, 2023 at 8:47 PM Andy Shevchenko > > > > <andriy.shevchenko@intel.com> wrote: > > > > > On Tue, Apr 11, 2023 at 06:09:16PM +0300, Serge Semin wrote: > > > > > > On Tue, Apr 11, 2023 at 05:46:34PM +0300, Andy Shevchenko wrote: > > > > > > > On Tue, Apr 11, 2023 at 05:11:15PM +0300, Serge Semin wrote: > > > > > > > > On Tue, Apr 11, 2023 at 03:13:49PM +0300, Andy Shevchenko wrote: > > > > > > > > > On Thu, Mar 30, 2023 at 06:34:49AM +0000, Joy Chakraborty wrote: ... > > > > > > > > > > - if (n_bytes == 1) > > > > > > > > > > + switch (n_bytes) { > > > > > > > > > > + case 1: > > > > > > > > > > return DMA_SLAVE_BUSWIDTH_1_BYTE; > > > > > > > > > > - else if (n_bytes == 2) > > > > > > > > > > + case 2: > > > > > > > > > > return DMA_SLAVE_BUSWIDTH_2_BYTES; > > > > > > > > > > - > > > > > > > > > > - return DMA_SLAVE_BUSWIDTH_UNDEFINED; > > > > > > > > > > > > > > > > > > > + case 3: > > > > > > > > > > > > > > > > > > I'm not sure about this. > > > > > > > > > > > > > > > > This actually makes sense seeing the function argument can have values > > > > > > > > 1, 2, _3_ and 4: > > > > > > > > dws->n_bytes = DIV_ROUND_UP(transfer->bits_per_word, BITS_PER_BYTE); > > > > > > > > transfer->bits_per_word = __F__(master->bits_per_word_mask = SPI_BPW_RANGE_MASK(4, 32)); > > > > > > > > ... > > > > > > > > dw_spi_dma_convert_width(dws->n_bytes) > > > > > > > > > > > > > > > > The spi_transfer.bits_per_word field value depends on the > > > > > > > > SPI peripheral device communication protocol requirements which may > > > > > > > > imply the 3-bytes word xfers (even though it's indeed unluckily). > > > > > > > > > > > > > > > > This semantic will also match to what we currently have in the > > > > > > > > IRQ-based SPI-transfer implementation (see dw_writer() and > > > > > > > > dw_reader()). > > > > > > > > > > > > > Nice, but we have DMA_SLAVE_BUSWIDTH_3_BYTES definition for that. Why we don't > > > > > > > use it? > > > > > > > > > > > > We could but there are two more-or-less firm reasons not to do > > > > > > that: > > > > > > 1. There aren't that much DMA-engines with the > > > > > > DMA_SLAVE_BUSWIDTH_3_BYTES capability meanwhile the DW APB SSI just > > > > > > ignores the upper bits if CTRLR0.DFS is less than the value actual > > > > > > written to the DR registers. Note DW DMAC engine isn't one of such > > > > > > controllers. So if we get to meet a peripheral SPI-device with 3-bytes > > > > > > word protocol transfers and the DMA-engine doesn't support it the > > > > > > DMA-based transfers may fail (depending on the DMA-engine driver > > > > > > implementation). > > > > > > 2. The DW APB SSIs (3.x and 4.x) can be synthesized with the APB Data > > > > > > Bus Width of 8, 16 and 32. So no matter whether DMA-engine supports > > > > > > the 3-bytes bus width the system bus most likely will either convert > > > > > > the transfers to the proper sized bus-transactions or fail. > > > > > > > > > > > > So taking all of the above into account not using the > > > > > > DMA_SLAVE_BUSWIDTH_3_BYTES macro here seems better than using it with > > > > > > a risk to fail some of the platform setups especially seeing the DW > > > > > > APB SSI ignores the upper bits anyway. > > > > > > > > > > But this is not about SPI host hardware, it's about the consumers. > > > > > They should know about supported sizes. Either we add the corresponding support > > > > > to the driver or remove 3 case as I suggested. I don't think it's correct to > > > > > use 3 as 4. > > > > > > > > Another thing to add is that as per spi.h even if bits per word is a > > > > not a power of 2 the buffer should be formatted in memory as a power > > > > of 2 > > > > ... > > > > * @bits_per_word: Data transfers involve one or more words; word sizes > > > > * like eight or 12 bits are common. In-memory wordsizes are > > > > * powers of two bytes (e.g. 20 bit samples use 32 bits). > > > > * This may be changed by the device's driver, or left at the > > > > * default (0) indicating protocol words are eight bit bytes. > > > > * The spi_transfer.bits_per_word can override this for each transfer. > > > > ... > > > > Hence for n_bytes = 3 or 24 bits/per word we expect the client SW to > > > > format it to 4 byte buffers hence the transaction generated should > > > > also be of size 4 from the DMA. > > > > > > You didn't get my point. The consumer wants to know if the 3 bytes is supported > > > or not, that's should be part of the DMA related thing, right? > > > > > > It's incorrectly to say 4 for 3 if the backend DMA controller behaves differently > > > on this. How do you know that (any) DMA controller integrated with this hardware > > > has no side effects for this change. > > > > > > So, I don't think the case 3 is correct in this patch. > > > > I see, I am of the opposite opinion in this case. > > > > Other then Serge(y)'s points, > > I was trying to say that irrespective of what the underlying DMA > > controller supports we should use DMA_SLAVE_BUSWIDTH_4_BYTES when > > n_bytes = 3 from SPI perspective as we get n_bytes from bits per word > > passed by the client / spi framework " dws->n_bytes = > > DIV_ROUND_UP(transfer->bits_per_word, BITS_PER_BYTE) ". > > Based on the spi header what I perceive is that for bits/word between > > 17 and 32 the data has to be stored in 32bit words in memory as per > > the example in the header " (e.g. 20 bit samples use 32 bits) ". > > > > Hence, taking an example to transfer 6 bytes (say 0xAA 0xBB 0xCC 0xDD > > 0xEE 0xFF) with bits per word as 24 (n_bytes = 3) i.e. a total of 2 > > words I expect the buffer to look as follows which is coming from the > > client: > > _ _____address|__________0________4________8________C > > SD:00000000|>00CCBBAA 00FFEEDD 00000000 00000000 > > Hence to transfer this successfully the DMA controller would need to > > copy 4 bytes per word . > > > > Please correct me if my understanding of this is incorrect. Thank you for finding the answer for me by yourself! > On the other hand I do see that in the fifo driver dw_writer() / > dw_reader() increments the pointer with 3 incase n_bytes = 3 even > though it copies 4 bytes. > ... > if (dws->n_bytes == 1) > txw = *(u8 *)(dws->tx); > else if (dws->n_bytes == 2) > txw = *(u16 *)(dws->tx); > else > txw = *(u32 *)(dws->tx); > > dws->tx += dws->n_bytes; > ... > This will not behave as using DMA_SLAVE_BUSWIDTH_4_BYTES in the DMA so > maybe I am not correct in interpretting the spi.h header file. > Can CPU's in general access u32 from unaligned odd addresses ? Generally speaking the above code must check number of bytes for being 4. > From Serge(y)'s comment regarding this, the APB interface writing data > to the FIFO register definitely cannot handle > DMA_SLAVE_BUSWIDTH_3_BYTES since it handles a power of 2 only. > Hence we can possibly remove "case 3:" completely and also mask out > DMA_SLAVE_BUSWIDTH_3_BYTES from dma_addr_width capabilities so that > can_dma api does not allow n_bytes = 3 to use DMA. > > Would that be correct ? We have to fix the above and the DIV_ROUND_UP(transfer->bits_per_word, BITS_PER_BYTE) one to be something like roundup_pow_of_two(round_up(..., BITS_PER_BYTE)) > > > > > > > > > > + case 4: > > > > > > > > > > + return DMA_SLAVE_BUSWIDTH_4_BYTES; > > > > > > > > > > + default: > > > > > > > > > > + return DMA_SLAVE_BUSWIDTH_UNDEFINED; > > > > > > > > > > + }
On Wed, Apr 12, 2023 at 6:55 PM Andy Shevchenko <andriy.shevchenko@intel.com> wrote: > > On Wed, Apr 12, 2023 at 02:51:44PM +0530, Joy Chakraborty wrote: > > On Wed, Apr 12, 2023 at 1:11 AM Joy Chakraborty <joychakr@google.com> wrote: > > > On Tue, Apr 11, 2023 at 9:52 PM Andy Shevchenko > > > <andriy.shevchenko@intel.com> wrote: > > > > On Tue, Apr 11, 2023 at 08:48:52PM +0530, Joy Chakraborty wrote: > > > > > On Tue, Apr 11, 2023 at 8:47 PM Andy Shevchenko > > > > > <andriy.shevchenko@intel.com> wrote: > > > > > > On Tue, Apr 11, 2023 at 06:09:16PM +0300, Serge Semin wrote: > > > > > > > On Tue, Apr 11, 2023 at 05:46:34PM +0300, Andy Shevchenko wrote: > > > > > > > > On Tue, Apr 11, 2023 at 05:11:15PM +0300, Serge Semin wrote: > > > > > > > > > On Tue, Apr 11, 2023 at 03:13:49PM +0300, Andy Shevchenko wrote: > > > > > > > > > > On Thu, Mar 30, 2023 at 06:34:49AM +0000, Joy Chakraborty wrote: > > ... > > > > > > > > > > > > - if (n_bytes == 1) > > > > > > > > > > > + switch (n_bytes) { > > > > > > > > > > > + case 1: > > > > > > > > > > > return DMA_SLAVE_BUSWIDTH_1_BYTE; > > > > > > > > > > > - else if (n_bytes == 2) > > > > > > > > > > > + case 2: > > > > > > > > > > > return DMA_SLAVE_BUSWIDTH_2_BYTES; > > > > > > > > > > > - > > > > > > > > > > > - return DMA_SLAVE_BUSWIDTH_UNDEFINED; > > > > > > > > > > > > > > > > > > > > > + case 3: > > > > > > > > > > > > > > > > > > > > I'm not sure about this. > > > > > > > > > > > > > > > > > > This actually makes sense seeing the function argument can have values > > > > > > > > > 1, 2, _3_ and 4: > > > > > > > > > dws->n_bytes = DIV_ROUND_UP(transfer->bits_per_word, BITS_PER_BYTE); > > > > > > > > > transfer->bits_per_word = __F__(master->bits_per_word_mask = SPI_BPW_RANGE_MASK(4, 32)); > > > > > > > > > ... > > > > > > > > > dw_spi_dma_convert_width(dws->n_bytes) > > > > > > > > > > > > > > > > > > The spi_transfer.bits_per_word field value depends on the > > > > > > > > > SPI peripheral device communication protocol requirements which may > > > > > > > > > imply the 3-bytes word xfers (even though it's indeed unluckily). > > > > > > > > > > > > > > > > > > This semantic will also match to what we currently have in the > > > > > > > > > IRQ-based SPI-transfer implementation (see dw_writer() and > > > > > > > > > dw_reader()). > > > > > > > > > > > > > > > Nice, but we have DMA_SLAVE_BUSWIDTH_3_BYTES definition for that. Why we don't > > > > > > > > use it? > > > > > > > > > > > > > > We could but there are two more-or-less firm reasons not to do > > > > > > > that: > > > > > > > 1. There aren't that much DMA-engines with the > > > > > > > DMA_SLAVE_BUSWIDTH_3_BYTES capability meanwhile the DW APB SSI just > > > > > > > ignores the upper bits if CTRLR0.DFS is less than the value actual > > > > > > > written to the DR registers. Note DW DMAC engine isn't one of such > > > > > > > controllers. So if we get to meet a peripheral SPI-device with 3-bytes > > > > > > > word protocol transfers and the DMA-engine doesn't support it the > > > > > > > DMA-based transfers may fail (depending on the DMA-engine driver > > > > > > > implementation). > > > > > > > 2. The DW APB SSIs (3.x and 4.x) can be synthesized with the APB Data > > > > > > > Bus Width of 8, 16 and 32. So no matter whether DMA-engine supports > > > > > > > the 3-bytes bus width the system bus most likely will either convert > > > > > > > the transfers to the proper sized bus-transactions or fail. > > > > > > > > > > > > > > So taking all of the above into account not using the > > > > > > > DMA_SLAVE_BUSWIDTH_3_BYTES macro here seems better than using it with > > > > > > > a risk to fail some of the platform setups especially seeing the DW > > > > > > > APB SSI ignores the upper bits anyway. > > > > > > > > > > > > But this is not about SPI host hardware, it's about the consumers. > > > > > > They should know about supported sizes. Either we add the corresponding support > > > > > > to the driver or remove 3 case as I suggested. I don't think it's correct to > > > > > > use 3 as 4. > > > > > > > > > > Another thing to add is that as per spi.h even if bits per word is a > > > > > not a power of 2 the buffer should be formatted in memory as a power > > > > > of 2 > > > > > ... > > > > > * @bits_per_word: Data transfers involve one or more words; word sizes > > > > > * like eight or 12 bits are common. In-memory wordsizes are > > > > > * powers of two bytes (e.g. 20 bit samples use 32 bits). > > > > > * This may be changed by the device's driver, or left at the > > > > > * default (0) indicating protocol words are eight bit bytes. > > > > > * The spi_transfer.bits_per_word can override this for each transfer. > > > > > ... > > > > > Hence for n_bytes = 3 or 24 bits/per word we expect the client SW to > > > > > format it to 4 byte buffers hence the transaction generated should > > > > > also be of size 4 from the DMA. > > > > > > > > You didn't get my point. The consumer wants to know if the 3 bytes is supported > > > > or not, that's should be part of the DMA related thing, right? > > > > > > > > It's incorrectly to say 4 for 3 if the backend DMA controller behaves differently > > > > on this. How do you know that (any) DMA controller integrated with this hardware > > > > has no side effects for this change. > > > > > > > > So, I don't think the case 3 is correct in this patch. > > > > > > I see, I am of the opposite opinion in this case. > > > > > > Other then Serge(y)'s points, > > > I was trying to say that irrespective of what the underlying DMA > > > controller supports we should use DMA_SLAVE_BUSWIDTH_4_BYTES when > > > n_bytes = 3 from SPI perspective as we get n_bytes from bits per word > > > passed by the client / spi framework " dws->n_bytes = > > > DIV_ROUND_UP(transfer->bits_per_word, BITS_PER_BYTE) ". > > > Based on the spi header what I perceive is that for bits/word between > > > 17 and 32 the data has to be stored in 32bit words in memory as per > > > the example in the header " (e.g. 20 bit samples use 32 bits) ". > > > > > > Hence, taking an example to transfer 6 bytes (say 0xAA 0xBB 0xCC 0xDD > > > 0xEE 0xFF) with bits per word as 24 (n_bytes = 3) i.e. a total of 2 > > > words I expect the buffer to look as follows which is coming from the > > > client: > > > _ _____address|__________0________4________8________C > > > SD:00000000|>00CCBBAA 00FFEEDD 00000000 00000000 > > > Hence to transfer this successfully the DMA controller would need to > > > copy 4 bytes per word . > > > > > > Please correct me if my understanding of this is incorrect. > > Thank you for finding the answer for me by yourself! > > > On the other hand I do see that in the fifo driver dw_writer() / > > dw_reader() increments the pointer with 3 incase n_bytes = 3 even > > though it copies 4 bytes. > > ... > > if (dws->n_bytes == 1) > > txw = *(u8 *)(dws->tx); > > else if (dws->n_bytes == 2) > > txw = *(u16 *)(dws->tx); > > else > > txw = *(u32 *)(dws->tx); > > > > dws->tx += dws->n_bytes; > > ... > > This will not behave as using DMA_SLAVE_BUSWIDTH_4_BYTES in the DMA so > > maybe I am not correct in interpretting the spi.h header file. > > Can CPU's in general access u32 from unaligned odd addresses ? > > Generally speaking the above code must check number of bytes for being 4. > > > From Serge(y)'s comment regarding this, the APB interface writing data > > to the FIFO register definitely cannot handle > > DMA_SLAVE_BUSWIDTH_3_BYTES since it handles a power of 2 only. > > Hence we can possibly remove "case 3:" completely and also mask out > > DMA_SLAVE_BUSWIDTH_3_BYTES from dma_addr_width capabilities so that > > can_dma api does not allow n_bytes = 3 to use DMA. > > > > Would that be correct ? > > We have to fix the above and the DIV_ROUND_UP(transfer->bits_per_word, > BITS_PER_BYTE) one to be something like > > roundup_pow_of_two(round_up(..., BITS_PER_BYTE)) > Hello Serge(y), Are we okay in removing n_bytes=3 support from the dma driver switch case ? This will also lead to can_dma returning false for n_bytes=3 which will essentially make it fall back to fifo mode. > > > > > > > > > > > + case 4: > > > > > > > > > > > + return DMA_SLAVE_BUSWIDTH_4_BYTES; > > > > > > > > > > > + default: > > > > > > > > > > > + return DMA_SLAVE_BUSWIDTH_UNDEFINED; > > > > > > > > > > > + } > > -- > With Best Regards, > Andy Shevchenko > >
Hi Joy On Thu, Apr 13, 2023 at 09:37:35AM +0530, Joy Chakraborty wrote: > On Wed, Apr 12, 2023 at 6:55 PM Andy Shevchenko > <andriy.shevchenko@intel.com> wrote: > > > > On Wed, Apr 12, 2023 at 02:51:44PM +0530, Joy Chakraborty wrote: > > > On Wed, Apr 12, 2023 at 1:11 AM Joy Chakraborty <joychakr@google.com> wrote: > > > > On Tue, Apr 11, 2023 at 9:52 PM Andy Shevchenko > > > > <andriy.shevchenko@intel.com> wrote: > > > > > On Tue, Apr 11, 2023 at 08:48:52PM +0530, Joy Chakraborty wrote: > > > > > > On Tue, Apr 11, 2023 at 8:47 PM Andy Shevchenko > > > > > > <andriy.shevchenko@intel.com> wrote: > > > > > > > On Tue, Apr 11, 2023 at 06:09:16PM +0300, Serge Semin wrote: > > > > > > > > On Tue, Apr 11, 2023 at 05:46:34PM +0300, Andy Shevchenko wrote: > > > > > > > > > On Tue, Apr 11, 2023 at 05:11:15PM +0300, Serge Semin wrote: > > > > > > > > > > On Tue, Apr 11, 2023 at 03:13:49PM +0300, Andy Shevchenko wrote: > > > > > > > > > > > On Thu, Mar 30, 2023 at 06:34:49AM +0000, Joy Chakraborty wrote: > > > > ... > > > > > > > > > > > > > > - if (n_bytes == 1) > > > > > > > > > > > > + switch (n_bytes) { > > > > > > > > > > > > + case 1: > > > > > > > > > > > > return DMA_SLAVE_BUSWIDTH_1_BYTE; > > > > > > > > > > > > - else if (n_bytes == 2) > > > > > > > > > > > > + case 2: > > > > > > > > > > > > return DMA_SLAVE_BUSWIDTH_2_BYTES; > > > > > > > > > > > > - > > > > > > > > > > > > - return DMA_SLAVE_BUSWIDTH_UNDEFINED; > > > > > > > > > > > > > > > > > > > > > > > + case 3: > > > > > > > > > > > > > > > > > > > > > > I'm not sure about this. > > > > > > > > > > > > > > > > > > > > This actually makes sense seeing the function argument can have values > > > > > > > > > > 1, 2, _3_ and 4: > > > > > > > > > > dws->n_bytes = DIV_ROUND_UP(transfer->bits_per_word, BITS_PER_BYTE); > > > > > > > > > > transfer->bits_per_word = __F__(master->bits_per_word_mask = SPI_BPW_RANGE_MASK(4, 32)); > > > > > > > > > > ... > > > > > > > > > > dw_spi_dma_convert_width(dws->n_bytes) > > > > > > > > > > > > > > > > > > > > The spi_transfer.bits_per_word field value depends on the > > > > > > > > > > SPI peripheral device communication protocol requirements which may > > > > > > > > > > imply the 3-bytes word xfers (even though it's indeed unluckily). > > > > > > > > > > > > > > > > > > > > This semantic will also match to what we currently have in the > > > > > > > > > > IRQ-based SPI-transfer implementation (see dw_writer() and > > > > > > > > > > dw_reader()). > > > > > > > > > > > > > > > > > Nice, but we have DMA_SLAVE_BUSWIDTH_3_BYTES definition for that. Why we don't > > > > > > > > > use it? > > > > > > > > > > > > > > > > We could but there are two more-or-less firm reasons not to do > > > > > > > > that: > > > > > > > > 1. There aren't that much DMA-engines with the > > > > > > > > DMA_SLAVE_BUSWIDTH_3_BYTES capability meanwhile the DW APB SSI just > > > > > > > > ignores the upper bits if CTRLR0.DFS is less than the value actual > > > > > > > > written to the DR registers. Note DW DMAC engine isn't one of such > > > > > > > > controllers. So if we get to meet a peripheral SPI-device with 3-bytes > > > > > > > > word protocol transfers and the DMA-engine doesn't support it the > > > > > > > > DMA-based transfers may fail (depending on the DMA-engine driver > > > > > > > > implementation). > > > > > > > > 2. The DW APB SSIs (3.x and 4.x) can be synthesized with the APB Data > > > > > > > > Bus Width of 8, 16 and 32. So no matter whether DMA-engine supports > > > > > > > > the 3-bytes bus width the system bus most likely will either convert > > > > > > > > the transfers to the proper sized bus-transactions or fail. > > > > > > > > > > > > > > > > So taking all of the above into account not using the > > > > > > > > DMA_SLAVE_BUSWIDTH_3_BYTES macro here seems better than using it with > > > > > > > > a risk to fail some of the platform setups especially seeing the DW > > > > > > > > APB SSI ignores the upper bits anyway. > > > > > > > > > > > > > > But this is not about SPI host hardware, it's about the consumers. > > > > > > > They should know about supported sizes. Either we add the corresponding support > > > > > > > to the driver or remove 3 case as I suggested. I don't think it's correct to > > > > > > > use 3 as 4. > > > > > > > > > > > > Another thing to add is that as per spi.h even if bits per word is a > > > > > > not a power of 2 the buffer should be formatted in memory as a power > > > > > > of 2 > > > > > > ... > > > > > > * @bits_per_word: Data transfers involve one or more words; word sizes > > > > > > * like eight or 12 bits are common. In-memory wordsizes are > > > > > > * powers of two bytes (e.g. 20 bit samples use 32 bits). > > > > > > * This may be changed by the device's driver, or left at the > > > > > > * default (0) indicating protocol words are eight bit bytes. > > > > > > * The spi_transfer.bits_per_word can override this for each transfer. > > > > > > ... > > > > > > Hence for n_bytes = 3 or 24 bits/per word we expect the client SW to > > > > > > format it to 4 byte buffers hence the transaction generated should > > > > > > also be of size 4 from the DMA. > > > > > > > > > > You didn't get my point. The consumer wants to know if the 3 bytes is supported > > > > > or not, that's should be part of the DMA related thing, right? > > > > > > > > > > It's incorrectly to say 4 for 3 if the backend DMA controller behaves differently > > > > > on this. How do you know that (any) DMA controller integrated with this hardware > > > > > has no side effects for this change. > > > > > > > > > > So, I don't think the case 3 is correct in this patch. > > > > > > > > I see, I am of the opposite opinion in this case. > > > > > > > > Other then Serge(y)'s points, > > > > I was trying to say that irrespective of what the underlying DMA > > > > controller supports we should use DMA_SLAVE_BUSWIDTH_4_BYTES when > > > > n_bytes = 3 from SPI perspective as we get n_bytes from bits per word > > > > passed by the client / spi framework " dws->n_bytes = > > > > DIV_ROUND_UP(transfer->bits_per_word, BITS_PER_BYTE) ". > > > > Based on the spi header what I perceive is that for bits/word between > > > > 17 and 32 the data has to be stored in 32bit words in memory as per > > > > the example in the header " (e.g. 20 bit samples use 32 bits) ". > > > > > > > > Hence, taking an example to transfer 6 bytes (say 0xAA 0xBB 0xCC 0xDD > > > > 0xEE 0xFF) with bits per word as 24 (n_bytes = 3) i.e. a total of 2 > > > > words I expect the buffer to look as follows which is coming from the > > > > client: > > > > _ _____address|__________0________4________8________C > > > > SD:00000000|>00CCBBAA 00FFEEDD 00000000 00000000 > > > > Hence to transfer this successfully the DMA controller would need to > > > > copy 4 bytes per word . > > > > > > > > Please correct me if my understanding of this is incorrect. > > > > Thank you for finding the answer for me by yourself! > > > > > On the other hand I do see that in the fifo driver dw_writer() / > > > dw_reader() increments the pointer with 3 incase n_bytes = 3 even > > > though it copies 4 bytes. > > > ... > > > if (dws->n_bytes == 1) > > > txw = *(u8 *)(dws->tx); > > > else if (dws->n_bytes == 2) > > > txw = *(u16 *)(dws->tx); > > > else > > > txw = *(u32 *)(dws->tx); > > > > > > dws->tx += dws->n_bytes; > > > ... > > > This will not behave as using DMA_SLAVE_BUSWIDTH_4_BYTES in the DMA so > > > maybe I am not correct in interpretting the spi.h header file. > > > Can CPU's in general access u32 from unaligned odd addresses ? > > > > Generally speaking the above code must check number of bytes for being 4. > > > > > From Serge(y)'s comment regarding this, the APB interface writing data > > > to the FIFO register definitely cannot handle > > > DMA_SLAVE_BUSWIDTH_3_BYTES since it handles a power of 2 only. > > > Hence we can possibly remove "case 3:" completely and also mask out > > > DMA_SLAVE_BUSWIDTH_3_BYTES from dma_addr_width capabilities so that > > > can_dma api does not allow n_bytes = 3 to use DMA. > > > > > > Would that be correct ? > > > > We have to fix the above and the DIV_ROUND_UP(transfer->bits_per_word, > > BITS_PER_BYTE) one to be something like > > > > roundup_pow_of_two(round_up(..., BITS_PER_BYTE)) > > > > Hello Serge(y), > > Are we okay in removing n_bytes=3 support from the dma driver switch case ? > This will also lead to can_dma returning false for n_bytes=3 which > will essentially make it fall back to fifo mode. Yes, I am ok with dropping the "3"-case from dw_spi_dma_convert_width() in your patch. Could you also provide an additional patch in your series which would replace DIV_ROUND_UP(transfer->bits_per_word, BITS_PER_BYTE) with roundup_pow_of_two() as @Andy suggests? It is supposed to be a bug-fix AFAICS to the commit a51acc2400d4 ("spi: dw: Add support for 32-bits max xfer size"). -Serge(y) > > > > > > > > > > > > > + case 4: > > > > > > > > > > > > + return DMA_SLAVE_BUSWIDTH_4_BYTES; > > > > > > > > > > > > + default: > > > > > > > > > > > > + return DMA_SLAVE_BUSWIDTH_UNDEFINED; > > > > > > > > > > > > + } > > > > -- > > With Best Regards, > > Andy Shevchenko > > > >
On Thu, Apr 13, 2023 at 7:17 PM Serge Semin <fancer.lancer@gmail.com> wrote: > > Hi Joy > > On Thu, Apr 13, 2023 at 09:37:35AM +0530, Joy Chakraborty wrote: > > On Wed, Apr 12, 2023 at 6:55 PM Andy Shevchenko > > <andriy.shevchenko@intel.com> wrote: > > > > > > On Wed, Apr 12, 2023 at 02:51:44PM +0530, Joy Chakraborty wrote: > > > > On Wed, Apr 12, 2023 at 1:11 AM Joy Chakraborty <joychakr@google.com> wrote: > > > > > On Tue, Apr 11, 2023 at 9:52 PM Andy Shevchenko > > > > > <andriy.shevchenko@intel.com> wrote: > > > > > > On Tue, Apr 11, 2023 at 08:48:52PM +0530, Joy Chakraborty wrote: > > > > > > > On Tue, Apr 11, 2023 at 8:47 PM Andy Shevchenko > > > > > > > <andriy.shevchenko@intel.com> wrote: > > > > > > > > On Tue, Apr 11, 2023 at 06:09:16PM +0300, Serge Semin wrote: > > > > > > > > > On Tue, Apr 11, 2023 at 05:46:34PM +0300, Andy Shevchenko wrote: > > > > > > > > > > On Tue, Apr 11, 2023 at 05:11:15PM +0300, Serge Semin wrote: > > > > > > > > > > > On Tue, Apr 11, 2023 at 03:13:49PM +0300, Andy Shevchenko wrote: > > > > > > > > > > > > On Thu, Mar 30, 2023 at 06:34:49AM +0000, Joy Chakraborty wrote: > > > > > > ... > > > > > > > > > > > > > > > > - if (n_bytes == 1) > > > > > > > > > > > > > + switch (n_bytes) { > > > > > > > > > > > > > + case 1: > > > > > > > > > > > > > return DMA_SLAVE_BUSWIDTH_1_BYTE; > > > > > > > > > > > > > - else if (n_bytes == 2) > > > > > > > > > > > > > + case 2: > > > > > > > > > > > > > return DMA_SLAVE_BUSWIDTH_2_BYTES; > > > > > > > > > > > > > - > > > > > > > > > > > > > - return DMA_SLAVE_BUSWIDTH_UNDEFINED; > > > > > > > > > > > > > > > > > > > > > > > > > + case 3: > > > > > > > > > > > > > > > > > > > > > > > > I'm not sure about this. > > > > > > > > > > > > > > > > > > > > > > This actually makes sense seeing the function argument can have values > > > > > > > > > > > 1, 2, _3_ and 4: > > > > > > > > > > > dws->n_bytes = DIV_ROUND_UP(transfer->bits_per_word, BITS_PER_BYTE); > > > > > > > > > > > transfer->bits_per_word = __F__(master->bits_per_word_mask = SPI_BPW_RANGE_MASK(4, 32)); > > > > > > > > > > > ... > > > > > > > > > > > dw_spi_dma_convert_width(dws->n_bytes) > > > > > > > > > > > > > > > > > > > > > > The spi_transfer.bits_per_word field value depends on the > > > > > > > > > > > SPI peripheral device communication protocol requirements which may > > > > > > > > > > > imply the 3-bytes word xfers (even though it's indeed unluckily). > > > > > > > > > > > > > > > > > > > > > > This semantic will also match to what we currently have in the > > > > > > > > > > > IRQ-based SPI-transfer implementation (see dw_writer() and > > > > > > > > > > > dw_reader()). > > > > > > > > > > > > > > > > > > > Nice, but we have DMA_SLAVE_BUSWIDTH_3_BYTES definition for that. Why we don't > > > > > > > > > > use it? > > > > > > > > > > > > > > > > > > We could but there are two more-or-less firm reasons not to do > > > > > > > > > that: > > > > > > > > > 1. There aren't that much DMA-engines with the > > > > > > > > > DMA_SLAVE_BUSWIDTH_3_BYTES capability meanwhile the DW APB SSI just > > > > > > > > > ignores the upper bits if CTRLR0.DFS is less than the value actual > > > > > > > > > written to the DR registers. Note DW DMAC engine isn't one of such > > > > > > > > > controllers. So if we get to meet a peripheral SPI-device with 3-bytes > > > > > > > > > word protocol transfers and the DMA-engine doesn't support it the > > > > > > > > > DMA-based transfers may fail (depending on the DMA-engine driver > > > > > > > > > implementation). > > > > > > > > > 2. The DW APB SSIs (3.x and 4.x) can be synthesized with the APB Data > > > > > > > > > Bus Width of 8, 16 and 32. So no matter whether DMA-engine supports > > > > > > > > > the 3-bytes bus width the system bus most likely will either convert > > > > > > > > > the transfers to the proper sized bus-transactions or fail. > > > > > > > > > > > > > > > > > > So taking all of the above into account not using the > > > > > > > > > DMA_SLAVE_BUSWIDTH_3_BYTES macro here seems better than using it with > > > > > > > > > a risk to fail some of the platform setups especially seeing the DW > > > > > > > > > APB SSI ignores the upper bits anyway. > > > > > > > > > > > > > > > > But this is not about SPI host hardware, it's about the consumers. > > > > > > > > They should know about supported sizes. Either we add the corresponding support > > > > > > > > to the driver or remove 3 case as I suggested. I don't think it's correct to > > > > > > > > use 3 as 4. > > > > > > > > > > > > > > Another thing to add is that as per spi.h even if bits per word is a > > > > > > > not a power of 2 the buffer should be formatted in memory as a power > > > > > > > of 2 > > > > > > > ... > > > > > > > * @bits_per_word: Data transfers involve one or more words; word sizes > > > > > > > * like eight or 12 bits are common. In-memory wordsizes are > > > > > > > * powers of two bytes (e.g. 20 bit samples use 32 bits). > > > > > > > * This may be changed by the device's driver, or left at the > > > > > > > * default (0) indicating protocol words are eight bit bytes. > > > > > > > * The spi_transfer.bits_per_word can override this for each transfer. > > > > > > > ... > > > > > > > Hence for n_bytes = 3 or 24 bits/per word we expect the client SW to > > > > > > > format it to 4 byte buffers hence the transaction generated should > > > > > > > also be of size 4 from the DMA. > > > > > > > > > > > > You didn't get my point. The consumer wants to know if the 3 bytes is supported > > > > > > or not, that's should be part of the DMA related thing, right? > > > > > > > > > > > > It's incorrectly to say 4 for 3 if the backend DMA controller behaves differently > > > > > > on this. How do you know that (any) DMA controller integrated with this hardware > > > > > > has no side effects for this change. > > > > > > > > > > > > So, I don't think the case 3 is correct in this patch. > > > > > > > > > > I see, I am of the opposite opinion in this case. > > > > > > > > > > Other then Serge(y)'s points, > > > > > I was trying to say that irrespective of what the underlying DMA > > > > > controller supports we should use DMA_SLAVE_BUSWIDTH_4_BYTES when > > > > > n_bytes = 3 from SPI perspective as we get n_bytes from bits per word > > > > > passed by the client / spi framework " dws->n_bytes = > > > > > DIV_ROUND_UP(transfer->bits_per_word, BITS_PER_BYTE) ". > > > > > Based on the spi header what I perceive is that for bits/word between > > > > > 17 and 32 the data has to be stored in 32bit words in memory as per > > > > > the example in the header " (e.g. 20 bit samples use 32 bits) ". > > > > > > > > > > Hence, taking an example to transfer 6 bytes (say 0xAA 0xBB 0xCC 0xDD > > > > > 0xEE 0xFF) with bits per word as 24 (n_bytes = 3) i.e. a total of 2 > > > > > words I expect the buffer to look as follows which is coming from the > > > > > client: > > > > > _ _____address|__________0________4________8________C > > > > > SD:00000000|>00CCBBAA 00FFEEDD 00000000 00000000 > > > > > Hence to transfer this successfully the DMA controller would need to > > > > > copy 4 bytes per word . > > > > > > > > > > Please correct me if my understanding of this is incorrect. > > > > > > Thank you for finding the answer for me by yourself! > > > > > > > On the other hand I do see that in the fifo driver dw_writer() / > > > > dw_reader() increments the pointer with 3 incase n_bytes = 3 even > > > > though it copies 4 bytes. > > > > ... > > > > if (dws->n_bytes == 1) > > > > txw = *(u8 *)(dws->tx); > > > > else if (dws->n_bytes == 2) > > > > txw = *(u16 *)(dws->tx); > > > > else > > > > txw = *(u32 *)(dws->tx); > > > > > > > > dws->tx += dws->n_bytes; > > > > ... > > > > This will not behave as using DMA_SLAVE_BUSWIDTH_4_BYTES in the DMA so > > > > maybe I am not correct in interpretting the spi.h header file. > > > > Can CPU's in general access u32 from unaligned odd addresses ? > > > > > > Generally speaking the above code must check number of bytes for being 4. > > > > > > > From Serge(y)'s comment regarding this, the APB interface writing data > > > > to the FIFO register definitely cannot handle > > > > DMA_SLAVE_BUSWIDTH_3_BYTES since it handles a power of 2 only. > > > > Hence we can possibly remove "case 3:" completely and also mask out > > > > DMA_SLAVE_BUSWIDTH_3_BYTES from dma_addr_width capabilities so that > > > > can_dma api does not allow n_bytes = 3 to use DMA. > > > > > > > > Would that be correct ? > > > > > > We have to fix the above and the DIV_ROUND_UP(transfer->bits_per_word, > > > BITS_PER_BYTE) one to be something like > > > > > > roundup_pow_of_two(round_up(..., BITS_PER_BYTE)) > > > > > > > Hello Serge(y), > > > > Are we okay in removing n_bytes=3 support from the dma driver switch case ? > > This will also lead to can_dma returning false for n_bytes=3 which > > will essentially make it fall back to fifo mode. > > Yes, I am ok with dropping the "3"-case from > dw_spi_dma_convert_width() in your patch. Could you also provide an > additional patch in your series which would replace > DIV_ROUND_UP(transfer->bits_per_word, BITS_PER_BYTE) with > roundup_pow_of_two() as @Andy suggests? It is supposed to be a bug-fix > AFAICS to the commit a51acc2400d4 ("spi: dw: Add support for 32-bits > max xfer size"). > > -Serge(y) > Sure, I will update this patch series and resend. Thanks Joy > > > > > > > > > > > > > > > + case 4: > > > > > > > > > > > > > + return DMA_SLAVE_BUSWIDTH_4_BYTES; > > > > > > > > > > > > > + default: > > > > > > > > > > > > > + return DMA_SLAVE_BUSWIDTH_UNDEFINED; > > > > > > > > > > > > > + } > > > > > > -- > > > With Best Regards, > > > Andy Shevchenko > > > > > >
diff --git a/drivers/spi/spi-dw-dma.c b/drivers/spi/spi-dw-dma.c index ababb910b391..b3a88bb75907 100644 --- a/drivers/spi/spi-dw-dma.c +++ b/drivers/spi/spi-dw-dma.c @@ -208,12 +208,17 @@ static bool dw_spi_can_dma(struct spi_controller *master, static enum dma_slave_buswidth dw_spi_dma_convert_width(u8 n_bytes) { - if (n_bytes == 1) + switch (n_bytes) { + case 1: return DMA_SLAVE_BUSWIDTH_1_BYTE; - else if (n_bytes == 2) + case 2: return DMA_SLAVE_BUSWIDTH_2_BYTES; - - return DMA_SLAVE_BUSWIDTH_UNDEFINED; + case 3: + case 4: + return DMA_SLAVE_BUSWIDTH_4_BYTES; + default: + return DMA_SLAVE_BUSWIDTH_UNDEFINED; + } } static int dw_spi_dma_wait(struct dw_spi *dws, unsigned int len, u32 speed)
Add Support for AxSize = 4 bytes configuration from dw dma driver if n_bytes i.e. number of bytes per write to fifo is 3 or 4. Number of bytes written to fifo per write is depended on the bits/word configuration being used which the DW core driver translates to n_bytes. Signed-off-by: Joy Chakraborty <joychakr@google.com> --- drivers/spi/spi-dw-dma.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-)