| Message ID | 20230331064520.1320749-1-michenyuan@huawei.com |
|---|---|
| State | New |
| Headers | show |
| Series | cmtp: fix argument error | expand |
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=735678 ---Test result--- Test Summary: CheckPatch PASS 0.75 seconds GitLint PASS 0.36 seconds SubjectPrefix FAIL 0.41 seconds BuildKernel PASS 39.31 seconds CheckAllWarning PASS 43.12 seconds CheckSparse PASS 48.21 seconds CheckSmatch PASS 129.98 seconds BuildKernel32 PASS 38.30 seconds TestRunnerSetup PASS 534.77 seconds TestRunner_l2cap-tester PASS 18.44 seconds TestRunner_iso-tester PASS 18.96 seconds TestRunner_bnep-tester PASS 6.32 seconds TestRunner_mgmt-tester PASS 123.65 seconds TestRunner_rfcomm-tester PASS 10.02 seconds TestRunner_sco-tester PASS 8.95 seconds TestRunner_ioctl-tester PASS 10.65 seconds TestRunner_mesh-tester PASS 8.16 seconds TestRunner_smp-tester PASS 9.17 seconds TestRunner_userchan-tester PASS 6.59 seconds IncrementalBuild PASS 35.97 seconds Details ############################## Test: SubjectPrefix - FAIL Desc: Check subject contains "Bluetooth" prefix Output: "Bluetooth: " prefix is not specified in the subject --- Regards, Linux Bluetooth
On Fri, Mar 31, 2023 at 02:45:20PM +0800, Chenyuan Mi wrote: > Fix this issue by using BTPROTO_CMTP as argument instead of BTPROTO_HIDP. Thanks for your patch. Some things you may want to consider: * I think it would be good to describe what the effect of this problem is, if it can be observed. And if not, say so. I think it would also be useful to state how the problem was found. F.e. using a tool, or by inspection. * As this is described as a fix, it should probably have a fixes tag. I think it would be: Fixes: 8c8de589cedd ("Bluetooth: Added /proc/net/cmtp via bt_procfs_init()") > Signed-off-by: Chenyuan Mi <michenyuan@huawei.com> > --- > net/bluetooth/cmtp/sock.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Code change looks good. > diff --git a/net/bluetooth/cmtp/sock.c b/net/bluetooth/cmtp/sock.c > index 96d49d9fae96..cf4370055ce2 100644 > --- a/net/bluetooth/cmtp/sock.c > +++ b/net/bluetooth/cmtp/sock.c > @@ -250,7 +250,7 @@ int cmtp_init_sockets(void) > err = bt_procfs_init(&init_net, "cmtp", &cmtp_sk_list, NULL); > if (err < 0) { > BT_ERR("Failed to create CMTP proc file"); > - bt_sock_unregister(BTPROTO_HIDP); > + bt_sock_unregister(BTPROTO_CMTP); > goto error; > } > > -- > 2.25.1
diff --git a/net/bluetooth/cmtp/sock.c b/net/bluetooth/cmtp/sock.c index 96d49d9fae96..cf4370055ce2 100644 --- a/net/bluetooth/cmtp/sock.c +++ b/net/bluetooth/cmtp/sock.c @@ -250,7 +250,7 @@ int cmtp_init_sockets(void) err = bt_procfs_init(&init_net, "cmtp", &cmtp_sk_list, NULL); if (err < 0) { BT_ERR("Failed to create CMTP proc file"); - bt_sock_unregister(BTPROTO_HIDP); + bt_sock_unregister(BTPROTO_CMTP); goto error; }
Fix this issue by using BTPROTO_CMTP as argument instead of BTPROTO_HIDP. Signed-off-by: Chenyuan Mi <michenyuan@huawei.com> --- net/bluetooth/cmtp/sock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)