| Message ID | 20230330180448.269635-1-lars@metafoo.de |
|---|---|
| State | New |
| Headers | show |
| Series | [1/2] dt-bindings: i2c: cadence: Document reset property | expand |
On 3/31/23 02:42, Krzysztof Kozlowski wrote: > On 30/03/2023 20:04, Lars-Peter Clausen wrote: >> The Cadence I2C controller has an external reset that needs to be >> de-asserted before the I2C controller can be accessed. >> >> Document the `resets` devicetree property that can be used to describe how >> the reset signal is connected. > You could add it also to the example to have complete picture (and > validate your change). > > > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > When I resend with it added to the example, do you want me to keep or drop the acked-by?
On 31/03/2023 19:11, Lars-Peter Clausen wrote: > On 3/31/23 02:42, Krzysztof Kozlowski wrote: >> On 30/03/2023 20:04, Lars-Peter Clausen wrote: >>> The Cadence I2C controller has an external reset that needs to be >>> de-asserted before the I2C controller can be accessed. >>> >>> Document the `resets` devicetree property that can be used to describe how >>> the reset signal is connected. >> You could add it also to the example to have complete picture (and >> validate your change). >> >> >> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> > When I resend with it added to the example, do you want me to keep or > drop the acked-by? Keep the ack, please. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/i2c/cdns,i2c-r1p10.yaml b/Documentation/devicetree/bindings/i2c/cdns,i2c-r1p10.yaml index 9187015d9702..76e2b9a10de8 100644 --- a/Documentation/devicetree/bindings/i2c/cdns,i2c-r1p10.yaml +++ b/Documentation/devicetree/bindings/i2c/cdns,i2c-r1p10.yaml @@ -24,6 +24,9 @@ properties: clocks: minItems: 1 + resets: + maxItems: 1 + interrupts: maxItems: 1
The Cadence I2C controller has an external reset that needs to be de-asserted before the I2C controller can be accessed. Document the `resets` devicetree property that can be used to describe how the reset signal is connected. While the reset signal will always be present in hardware the devicetree property is kept optional for backwards compatibility with existing systems that do not specify the reset property and where the reset signal might not be controlled by operating system. Signed-off-by: Lars-Peter Clausen <lars@metafoo.de> --- Documentation/devicetree/bindings/i2c/cdns,i2c-r1p10.yaml | 3 +++ 1 file changed, 3 insertions(+)