diff mbox

configure.ac: remove duplicated line

Message ID 1461946374-56370-1-git-send-email-christophe.milard@linaro.org
State Accepted
Commit 04149e64e897d79229cf06539cda4d5f29bc7a90
Headers show

Commit Message

Christophe Milard April 29, 2016, 4:12 p.m. UTC
Removed an instance AM_CONDITIONAL for test_example, as this line was
twice in the file.

Signed-off-by: Christophe Milard <christophe.milard@linaro.org>
---
 configure.ac | 1 -
 1 file changed, 1 deletion(-)

Comments

Mike Holmes April 29, 2016, 3:24 p.m. UTC | #1
On 29 April 2016 at 12:12, Christophe Milard <christophe.milard@linaro.org>
wrote:

> Removed an instance AM_CONDITIONAL for test_example, as this line was

> twice in the file.

>

> Signed-off-by: Christophe Milard <christophe.milard@linaro.org>

>


Assuming Maxim can improve the subject line without a v2

configure.ac: remove duplicated test example configure

Reviewed-by: Mike Holmes <mike.holmes@linaro.org>



---
>  configure.ac | 1 -

>  1 file changed, 1 deletion(-)

>

> diff --git a/configure.ac b/configure.ac

> index f88c36b..f138031 100644

> --- a/configure.ac

> +++ b/configure.ac

> @@ -134,7 +134,6 @@ AM_CONDITIONAL([netmap_support], [test

> x$netmap_support = xyes ])

>  AM_CONDITIONAL([PKTIO_DPDK], [test x$pktio_dpdk_support = xyes ])

>  AM_CONDITIONAL([HAVE_PCAP], [test $have_pcap = yes])

>  AM_CONDITIONAL([SDK_INSTALL_PATH_], [test "x${SDK_INSTALL_PATH_}" = "x1"])

> -AM_CONDITIONAL([test_example], [test x$test_example = xyes ])

>  AM_CONDITIONAL([test_installdir], [test "$testdir" != ""])

>  AM_CONDITIONAL([cunit_support], [test x$cunit_support = xyes ])

>  AM_CONDITIONAL([test_vald], [test x$test_vald = xyes ])

> --

> 2.5.0

>

>



-- 
Mike Holmes
Technical Manager - Linaro Networking Group
Linaro.org <http://www.linaro.org/> *│ *Open source software for ARM SoCs
"Work should be fun and collaborative, the rest follows"
Maxim Uvarov April 29, 2016, 3:42 p.m. UTC | #2
Merged,
Maxim.

On 04/29/16 18:24, Mike Holmes wrote:
>
>
> On 29 April 2016 at 12:12, Christophe Milard 
> <christophe.milard@linaro.org <mailto:christophe.milard@linaro.org>> 
> wrote:
>
>     Removed an instance AM_CONDITIONAL for test_example, as this line was
>     twice in the file.
>
>     Signed-off-by: Christophe Milard <christophe.milard@linaro.org
>     <mailto:christophe.milard@linaro.org>>
>
>
> Assuming Maxim can improve the subject line without a v2
>
> configure.ac <http://configure.ac>: remove duplicated test example 
> configure
>
> Reviewed-by: Mike Holmes <mike.holmes@linaro.org 
> <mailto:mike.holmes@linaro.org>>
>
>
>     ---
>     configure.ac <http://configure.ac> | 1 -
>      1 file changed, 1 deletion(-)
>
>     diff --git a/configure.ac <http://configure.ac> b/configure.ac
>     <http://configure.ac>
>     index f88c36b..f138031 100644
>     --- a/configure.ac <http://configure.ac>
>     +++ b/configure.ac <http://configure.ac>
>     @@ -134,7 +134,6 @@ AM_CONDITIONAL([netmap_support], [test
>     x$netmap_support = xyes ])
>      AM_CONDITIONAL([PKTIO_DPDK], [test x$pktio_dpdk_support = xyes ])
>      AM_CONDITIONAL([HAVE_PCAP], [test $have_pcap = yes])
>      AM_CONDITIONAL([SDK_INSTALL_PATH_], [test "x${SDK_INSTALL_PATH_}"
>     = "x1"])
>     -AM_CONDITIONAL([test_example], [test x$test_example = xyes ])
>      AM_CONDITIONAL([test_installdir], [test "$testdir" != ""])
>      AM_CONDITIONAL([cunit_support], [test x$cunit_support = xyes ])
>      AM_CONDITIONAL([test_vald], [test x$test_vald = xyes ])
>     --
>     2.5.0
>
>
>
>
> -- 
> Mike Holmes
> Technical Manager - Linaro Networking Group
> Linaro.org <http://www.linaro.org/>***│ *Open source software for ARM SoCs
> "Work should be fun and collaborative, the rest follows"
>
>
>
> _______________________________________________
> lng-odp mailing list
> lng-odp@lists.linaro.org
> https://lists.linaro.org/mailman/listinfo/lng-odp
diff mbox

Patch

diff --git a/configure.ac b/configure.ac
index f88c36b..f138031 100644
--- a/configure.ac
+++ b/configure.ac
@@ -134,7 +134,6 @@  AM_CONDITIONAL([netmap_support], [test x$netmap_support = xyes ])
 AM_CONDITIONAL([PKTIO_DPDK], [test x$pktio_dpdk_support = xyes ])
 AM_CONDITIONAL([HAVE_PCAP], [test $have_pcap = yes])
 AM_CONDITIONAL([SDK_INSTALL_PATH_], [test "x${SDK_INSTALL_PATH_}" = "x1"])
-AM_CONDITIONAL([test_example], [test x$test_example = xyes ])
 AM_CONDITIONAL([test_installdir], [test "$testdir" != ""])
 AM_CONDITIONAL([cunit_support], [test x$cunit_support = xyes ])
 AM_CONDITIONAL([test_vald], [test x$test_vald = xyes ])