| Message ID | 20230404004501.1913144-1-trix@redhat.com |
|---|---|
| State | Accepted |
| Commit | 743d3336029ffe2bb38e982a3b572ced243c6d43 |
| Headers | show |
| Series | pinctrl: mlxbf3: set varaiable mlxbf3_pmx_funcs storage-class-specifier to static | expand |
diff --git a/drivers/pinctrl/pinctrl-mlxbf3.c b/drivers/pinctrl/pinctrl-mlxbf3.c index 3698f7bbd88d..d9944e6a0af9 100644 --- a/drivers/pinctrl/pinctrl-mlxbf3.c +++ b/drivers/pinctrl/pinctrl-mlxbf3.c @@ -159,7 +159,7 @@ static const struct pinctrl_ops mlxbf3_pinctrl_group_ops = { static const char * const mlxbf3_gpiofunc_group_names[] = { "swctrl" }; static const char * const mlxbf3_hwfunc_group_names[] = { "hwctrl" }; -struct pinfunction mlxbf3_pmx_funcs[] = { +static struct pinfunction mlxbf3_pmx_funcs[] = { PINCTRL_PINFUNCTION("hwfunc", mlxbf3_hwfunc_group_names, 1), PINCTRL_PINFUNCTION("gpiofunc", mlxbf3_gpiofunc_group_names, 1), };
smatch reports drivers/pinctrl/pinctrl-mlxbf3.c:162:20: warning: symbol 'mlxbf3_pmx_funcs' was not declared. Should it be static? This variable is only used in one file so it should be static. Signed-off-by: Tom Rix <trix@redhat.com> --- drivers/pinctrl/pinctrl-mlxbf3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)