| Message ID | 20230405200341.4911-1-danascape@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | ASoC: dt-bindings: wm8904: Convert to dtschema | expand |
On Thu, 06 Apr 2023 01:33:41 +0530, Saalim Quadri wrote: > Convert the WM8904 audio CODEC bindings to DT schema > > Signed-off-by: Saalim Quadri <danascape@gmail.com> > --- > .../devicetree/bindings/sound/wlf,wm8904.yaml | 66 +++++++++++++++++++ > .../devicetree/bindings/sound/wm8904.txt | 33 ---------- > 2 files changed, 66 insertions(+), 33 deletions(-) > create mode 100644 Documentation/devicetree/bindings/sound/wlf,wm8904.yaml > delete mode 100644 Documentation/devicetree/bindings/sound/wm8904.txt > Running 'make dtbs_check' with the schema in this patch gives the following warnings. Consider if they are expected or the schema is incorrect. These may not be new warnings. Note that it is not yet a requirement to have 0 warnings for dtbs_check. This will change in the future. Full log is available here: https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230405200341.4911-1-danascape@gmail.com audio-codec@1a: Unevaluated properties are not allowed ('AVDD-supply', 'CPVDD-supply', 'DBVDD-supply', 'DCVDD-supply', 'MICVDD-supply' were unexpected) arch/arm64/boot/dts/freescale/imx8mm-verdin-nonwifi-dahlia.dtb arch/arm64/boot/dts/freescale/imx8mm-verdin-wifi-dahlia.dtb
On Thu, Apr 6, 2023 at 4:24 AM Rob Herring <robh@kernel.org> wrote: > > > On Thu, 06 Apr 2023 01:33:41 +0530, Saalim Quadri wrote: > > Convert the WM8904 audio CODEC bindings to DT schema > > > > Signed-off-by: Saalim Quadri <danascape@gmail.com> > > --- > > .../devicetree/bindings/sound/wlf,wm8904.yaml | 66 +++++++++++++++++++ > > .../devicetree/bindings/sound/wm8904.txt | 33 ---------- > > 2 files changed, 66 insertions(+), 33 deletions(-) > > create mode 100644 Documentation/devicetree/bindings/sound/wlf,wm8904.yaml > > delete mode 100644 Documentation/devicetree/bindings/sound/wm8904.txt > > > > Running 'make dtbs_check' with the schema in this patch gives the > following warnings. Consider if they are expected or the schema is > incorrect. These may not be new warnings. > So, these properties are present in some dts files! We need to evaluated if they are always expected or can be optional. > Note that it is not yet a requirement to have 0 warnings for dtbs_check. > This will change in the future. > > Full log is available here: https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230405200341.4911-1-danascape@gmail.com > > > audio-codec@1a: Unevaluated properties are not allowed ('AVDD-supply', 'CPVDD-supply', 'DBVDD-supply', 'DCVDD-supply', 'MICVDD-supply' were unexpected) > arch/arm64/boot/dts/freescale/imx8mm-verdin-nonwifi-dahlia.dtb > arch/arm64/boot/dts/freescale/imx8mm-verdin-wifi-dahlia.dtb >
On 06/04/2023 08:40, Daniel Baluta wrote: > On Thu, Apr 6, 2023 at 4:24 AM Rob Herring <robh@kernel.org> wrote: >> >> >> On Thu, 06 Apr 2023 01:33:41 +0530, Saalim Quadri wrote: >>> Convert the WM8904 audio CODEC bindings to DT schema >>> >>> Signed-off-by: Saalim Quadri <danascape@gmail.com> >>> --- >>> .../devicetree/bindings/sound/wlf,wm8904.yaml | 66 +++++++++++++++++++ >>> .../devicetree/bindings/sound/wm8904.txt | 33 ---------- >>> 2 files changed, 66 insertions(+), 33 deletions(-) >>> create mode 100644 Documentation/devicetree/bindings/sound/wlf,wm8904.yaml >>> delete mode 100644 Documentation/devicetree/bindings/sound/wm8904.txt >>> >> >> Running 'make dtbs_check' with the schema in this patch gives the >> following warnings. Consider if they are expected or the schema is >> incorrect. These may not be new warnings. >> > So, these properties are present in some dts files! We need to > evaluated if they are always expected > or can be optional. I assume the DTSes are tested when you submit new DT schema conversion... Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/sound/wlf,wm8904.yaml b/Documentation/devicetree/bindings/sound/wlf,wm8904.yaml new file mode 100644 index 000000000000..78d76c1c1326 --- /dev/null +++ b/Documentation/devicetree/bindings/sound/wlf,wm8904.yaml @@ -0,0 +1,66 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/sound/wlf,wm8904.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: WM8904 audio CODEC + +description: | + Pins on the device (for linking into audio routes): + * IN1L + * IN1R + * IN2L + * IN2R + * IN3L + * IN3R + * HPOUTL + * HPOUTR + * LINEOUTL + * LINEOUTR + * MICBIAS + +maintainers: + - patches@opensource.cirrus.com + +allOf: + - $ref: dai-common.yaml# + +properties: + compatible: + enum: + - wlf,wm8904 + - wlf,wm8912 + + reg: + maxItems: 1 + + "#sound-dai-cells": + const: 0 + + clocks: + maxItems: 1 + + clock-names: + const: mclk + +required: + - compatible + - reg + - clock-names + - clocks + +unevaluatedProperties: false + +examples: + - | + i2c { + #address-cells = <1>; + #size-cells = <0>; + codec@1a { + compatible = "wlf,wm8904"; + reg = <0x1a>; + clocks = <&pck0>; + clock-names = "mclk"; + }; + }; diff --git a/Documentation/devicetree/bindings/sound/wm8904.txt b/Documentation/devicetree/bindings/sound/wm8904.txt deleted file mode 100644 index 66bf261423b9..000000000000 --- a/Documentation/devicetree/bindings/sound/wm8904.txt +++ /dev/null @@ -1,33 +0,0 @@ -WM8904 audio CODEC - -This device supports I2C only. - -Required properties: - - compatible: "wlf,wm8904" or "wlf,wm8912" - - reg: the I2C address of the device. - - clock-names: "mclk" - - clocks: reference to - <Documentation/devicetree/bindings/clock/clock-bindings.txt> - -Pins on the device (for linking into audio routes): - - * IN1L - * IN1R - * IN2L - * IN2R - * IN3L - * IN3R - * HPOUTL - * HPOUTR - * LINEOUTL - * LINEOUTR - * MICBIAS - -Examples: - -codec: wm8904@1a { - compatible = "wlf,wm8904"; - reg = <0x1a>; - clocks = <&pck0>; - clock-names = "mclk"; -};
Convert the WM8904 audio CODEC bindings to DT schema Signed-off-by: Saalim Quadri <danascape@gmail.com> --- .../devicetree/bindings/sound/wlf,wm8904.yaml | 66 +++++++++++++++++++ .../devicetree/bindings/sound/wm8904.txt | 33 ---------- 2 files changed, 66 insertions(+), 33 deletions(-) create mode 100644 Documentation/devicetree/bindings/sound/wlf,wm8904.yaml delete mode 100644 Documentation/devicetree/bindings/sound/wm8904.txt