| Message ID | trinity-76c5c0b4-a6f7-4679-a1ef-74e745649355-1680811577008@3c-app-gmx-bap69 |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [RESEND] ARM: dts: meson8b: correct uart_B and uart_C clock references | expand |
On 06/04/2023 22:06, hfdevel@gmx.net wrote: > Resending this patch with proper subject line, corrected distribution and reference to what the patch fixes. Thanks, Neil and Martin, for your guidance! > > commit b3b6a88d2347d2ec9075603920e616836cb46750 > Author: Hans-Frieder Vogt <hfdevel@gmx.net> > Date: Thu Apr 6 10:21:49 2023 +0200 > > [PATCH] correct uart_B and uart_C clock references for meson8b That's not correct patch format. All this above is not part of patch. > > with the current device tree for meson8b, uarts B (e.g. available on pins 8/10 on Odroid-C1) and C (pins 3/5 on Odroid-C1) do not work, because they are relying on incorrect clocks. Start sentences with capital letter. > This trivial patch changes the references of pclk to the correct CLKID, which allows to use the two uarts. Please wrap commit message according to Linux coding style / submission process (neither too early nor over the limit): https://elixir.bootlin.com/linux/v5.18-rc4/source/Documentation/process/submitting-patches.rst#L586 > > Fixes: 3375aa77135f ("ARM: dts: meson8b: Fix the UART device-tree schema validation") > Drop blank line > Signed-off-by: Hans-Frieder Vogt <hfdevel@gmx.net> > --- > meson8b.dtsi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Best regards, Krzysztof
diff --git a/arch/arm/boot/dts/meson8b.dtsi b/arch/arm/boot/dts/meson8b.dtsi index d5a3fe21e8e7..25f7c985f9ea 100644 --- a/arch/arm/boot/dts/meson8b.dtsi +++ b/arch/arm/boot/dts/meson8b.dtsi @@ -740,13 +740,13 @@ &uart_A { &uart_B { compatible = "amlogic,meson8b-uart"; - clocks = <&xtal>, <&clkc CLKID_UART0>, <&clkc CLKID_CLK81>; + clocks = <&xtal>, <&clkc CLKID_UART1>, <&clkc CLKID_CLK81>; clock-names = "xtal", "pclk", "baud"; }; &uart_C { compatible = "amlogic,meson8b-uart"; - clocks = <&xtal>, <&clkc CLKID_UART0>, <&clkc CLKID_CLK81>; + clocks = <&xtal>, <&clkc CLKID_UART2>, <&clkc CLKID_CLK81>; clock-names = "xtal", "pclk", "baud"; };
Resending this patch with proper subject line, corrected distribution and reference to what the patch fixes. Thanks, Neil and Martin, for your guidance! commit b3b6a88d2347d2ec9075603920e616836cb46750 Author: Hans-Frieder Vogt <hfdevel@gmx.net> Date: Thu Apr 6 10:21:49 2023 +0200 [PATCH] correct uart_B and uart_C clock references for meson8b with the current device tree for meson8b, uarts B (e.g. available on pins 8/10 on Odroid-C1) and C (pins 3/5 on Odroid-C1) do not work, because they are relying on incorrect clocks. This trivial patch changes the references of pclk to the correct CLKID, which allows to use the two uarts. Fixes: 3375aa77135f ("ARM: dts: meson8b: Fix the UART device-tree schema validation") Signed-off-by: Hans-Frieder Vogt <hfdevel@gmx.net> --- meson8b.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)