Message ID | 20230412185608.64628-3-prabhakar.mahadev-lad.rj@bp.renesas.com |
---|---|
State | New |
Headers | show |
Series | RZ/V2L: Add CRU, CSI support | expand |
Hi Prabhakar, Thanks for your patch! On Wed, Apr 12, 2023 at 8:56 PM Prabhakar <prabhakar.csengg@gmail.com> wrote: > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > Enable CRU, CSI on RZ/V2L SMARC EVK and tie the CSI to the OV5645 sensor > using Device Tree overlay. RZ/G2L SMARC EVK and RZ/V2L SMARC EVK have the > same connections for connecting the CSI to OV5645 sensor so just reuse > the existing r9a07g044l2-smarc-cru-csi-ov5645.dtso and create a symbolic > link to this file for RZ/V2L SMARC EVK. Perhaps it makes more sense to rename r9a07g044l2-smarc-cru-csi-ov5645.dtso to rzg2l-smarc-cru-csi-ov5645.dtso instead? Gr{oetje,eeting}s, Geert
Hi Geert, Thank you for the review. On Mon, Apr 17, 2023 at 9:57 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > Hi Prabhakar, > > Thanks for your patch! > > On Wed, Apr 12, 2023 at 8:56 PM Prabhakar <prabhakar.csengg@gmail.com> wrote: > > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > > > Enable CRU, CSI on RZ/V2L SMARC EVK and tie the CSI to the OV5645 sensor > > using Device Tree overlay. RZ/G2L SMARC EVK and RZ/V2L SMARC EVK have the > > same connections for connecting the CSI to OV5645 sensor so just reuse > > the existing r9a07g044l2-smarc-cru-csi-ov5645.dtso and create a symbolic > > link to this file for RZ/V2L SMARC EVK. > > Perhaps it makes more sense to rename r9a07g044l2-smarc-cru-csi-ov5645.dtso > to rzg2l-smarc-cru-csi-ov5645.dtso instead? > ok, and then for g2lc [0] I add rzg2lc-smarc-cru-csi-ov5645.dtso ? [0] https://patchwork.kernel.org/project/linux-renesas-soc/patch/20230413114016.16068-1-prabhakar.mahadev-lad.rj@bp.renesas.com/ Cheers, Prabhakar
Hi Prabhakar, On Mon, Apr 17, 2023 at 1:05 PM Lad, Prabhakar <prabhakar.csengg@gmail.com> wrote: > On Mon, Apr 17, 2023 at 9:57 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > On Wed, Apr 12, 2023 at 8:56 PM Prabhakar <prabhakar.csengg@gmail.com> wrote: > > > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > > > > > Enable CRU, CSI on RZ/V2L SMARC EVK and tie the CSI to the OV5645 sensor > > > using Device Tree overlay. RZ/G2L SMARC EVK and RZ/V2L SMARC EVK have the > > > same connections for connecting the CSI to OV5645 sensor so just reuse > > > the existing r9a07g044l2-smarc-cru-csi-ov5645.dtso and create a symbolic > > > link to this file for RZ/V2L SMARC EVK. > > > > Perhaps it makes more sense to rename r9a07g044l2-smarc-cru-csi-ov5645.dtso > > to rzg2l-smarc-cru-csi-ov5645.dtso instead? > > > ok, and then for g2lc [0] I add rzg2lc-smarc-cru-csi-ov5645.dtso ? > > [0] https://patchwork.kernel.org/project/linux-renesas-soc/patch/20230413114016.16068-1-prabhakar.mahadev-lad.rj@bp.renesas.com/ Oh wait... had missed that one. Let me catch up and get a better view on the big picture first... ;-) Gr{oetje,eeting}s, Geert
On Mon, Apr 17, 2023 at 1:37 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > On Mon, Apr 17, 2023 at 1:05 PM Lad, Prabhakar > <prabhakar.csengg@gmail.com> wrote: > > On Mon, Apr 17, 2023 at 9:57 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > > On Wed, Apr 12, 2023 at 8:56 PM Prabhakar <prabhakar.csengg@gmail.com> wrote: > > > > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > > > > > > > Enable CRU, CSI on RZ/V2L SMARC EVK and tie the CSI to the OV5645 sensor > > > > using Device Tree overlay. RZ/G2L SMARC EVK and RZ/V2L SMARC EVK have the > > > > same connections for connecting the CSI to OV5645 sensor so just reuse > > > > the existing r9a07g044l2-smarc-cru-csi-ov5645.dtso and create a symbolic > > > > link to this file for RZ/V2L SMARC EVK. > > > > > > Perhaps it makes more sense to rename r9a07g044l2-smarc-cru-csi-ov5645.dtso > > > to rzg2l-smarc-cru-csi-ov5645.dtso instead? > > > > > ok, and then for g2lc [0] I add rzg2lc-smarc-cru-csi-ov5645.dtso ? > > > > [0] https://patchwork.kernel.org/project/linux-renesas-soc/patch/20230413114016.16068-1-prabhakar.mahadev-lad.rj@bp.renesas.com/ > > Oh wait... had missed that one. Let me catch up and get a better > view on the big picture first... ;-) Let's keep it for now... Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> i.e. will queue in renesas-devel for v6.5. Gr{oetje,eeting}s, Geert
diff --git a/arch/arm64/boot/dts/renesas/Makefile b/arch/arm64/boot/dts/renesas/Makefile index f130165577a8..ebcbd66ba816 100644 --- a/arch/arm64/boot/dts/renesas/Makefile +++ b/arch/arm64/boot/dts/renesas/Makefile @@ -83,6 +83,7 @@ dtb-$(CONFIG_ARCH_R9A07G044) += r9a07g044l2-smarc.dtb dtb-$(CONFIG_ARCH_R9A07G044) += r9a07g044l2-smarc-cru-csi-ov5645.dtbo dtb-$(CONFIG_ARCH_R9A07G054) += r9a07g054l2-smarc.dtb +dtb-$(CONFIG_ARCH_R9A07G054) += r9a07g054l2-smarc-cru-csi-ov5645.dtbo dtb-$(CONFIG_ARCH_R9A09G011) += r9a09g011-v2mevk2.dtb diff --git a/arch/arm64/boot/dts/renesas/r9a07g044l2-smarc-cru-csi-ov5645.dtso b/arch/arm64/boot/dts/renesas/r9a07g044l2-smarc-cru-csi-ov5645.dtso index d834bff9bda2..736c1e688cc8 100644 --- a/arch/arm64/boot/dts/renesas/r9a07g044l2-smarc-cru-csi-ov5645.dtso +++ b/arch/arm64/boot/dts/renesas/r9a07g044l2-smarc-cru-csi-ov5645.dtso @@ -1,6 +1,6 @@ // SPDX-License-Identifier: GPL-2.0 /* - * Device Tree overlay for the RZ/G2L SMARC EVK with OV5645 camera + * Device Tree overlay for the RZ/{G2L, V2L} SMARC EVK with OV5645 camera * connected to CSI and CRU enabled. * * Copyright (C) 2023 Renesas Electronics Corp. diff --git a/arch/arm64/boot/dts/renesas/r9a07g054l2-smarc-cru-csi-ov5645.dtso b/arch/arm64/boot/dts/renesas/r9a07g054l2-smarc-cru-csi-ov5645.dtso new file mode 120000 index 000000000000..0f175341d3ed --- /dev/null +++ b/arch/arm64/boot/dts/renesas/r9a07g054l2-smarc-cru-csi-ov5645.dtso @@ -0,0 +1 @@ +r9a07g044l2-smarc-cru-csi-ov5645.dtso \ No newline at end of file