| Message ID | 20230413113438.1577658-12-bryan.odonoghue@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | Add Qualcomm PMIC TPCM support | expand |
On 13.04.2023 13:34, Bryan O'Donoghue wrote: > Switch on usb-role-switching for usb_1 via TCPM. We need to declare > usb-role-switch in &usb_1 and associate with the remote-endpoint in TCPM > which provides the necessary signal. > > Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> > --- This belongs to the SoC DTSI as it describes the capabilities of the USB controllers on the chip. Also please add a newline before each subnode. Konrad > arch/arm64/boot/dts/qcom/qrb5165-rb5.dts | 19 ++++++++++++++++++- > 1 file changed, 18 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts > index 1e0b6fd59abc9..b5cc45358a474 100644 > --- a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts > +++ b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts > @@ -1273,7 +1273,13 @@ &usb_1 { > }; > > &usb_1_dwc3 { > - dr_mode = "peripheral"; > + dr_mode = "otg"; > + usb-role-switch; > + port { > + dwc3_role_switch_in: endpoint { > + remote-endpoint = <&pm8150b_role_switch_out>; > + }; > + }; > }; > > &usb_1_hsphy { > @@ -1359,5 +1365,16 @@ connector { > PDO_FIXED_DUAL_ROLE | > PDO_FIXED_USB_COMM | > PDO_FIXED_DATA_SWAP)>; > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + pm8150b_role_switch_out: endpoint { > + remote-endpoint = <&dwc3_role_switch_in>; > + }; > + }; > + }; > }; > };
On 22.04.2023 16:52, Konrad Dybcio wrote: > > > On 13.04.2023 13:34, Bryan O'Donoghue wrote: >> Switch on usb-role-switching for usb_1 via TCPM. We need to declare >> usb-role-switch in &usb_1 and associate with the remote-endpoint in TCPM >> which provides the necessary signal. >> >> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> >> --- > This belongs to the SoC DTSI as it describes the capabilities > of the USB controllers on the chip. > > Also please add a newline before each subnode. To be clear, I meant the port definitions and properties, not the DWC<->PMIC_TCPM port assignments Konrad > > Konrad >> arch/arm64/boot/dts/qcom/qrb5165-rb5.dts | 19 ++++++++++++++++++- >> 1 file changed, 18 insertions(+), 1 deletion(-) >> >> diff --git a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts >> index 1e0b6fd59abc9..b5cc45358a474 100644 >> --- a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts >> +++ b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts >> @@ -1273,7 +1273,13 @@ &usb_1 { >> }; >> >> &usb_1_dwc3 { >> - dr_mode = "peripheral"; >> + dr_mode = "otg"; >> + usb-role-switch; >> + port { >> + dwc3_role_switch_in: endpoint { >> + remote-endpoint = <&pm8150b_role_switch_out>; >> + }; >> + }; >> }; >> >> &usb_1_hsphy { >> @@ -1359,5 +1365,16 @@ connector { >> PDO_FIXED_DUAL_ROLE | >> PDO_FIXED_USB_COMM | >> PDO_FIXED_DATA_SWAP)>; >> + ports { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + port@0 { >> + reg = <0>; >> + pm8150b_role_switch_out: endpoint { >> + remote-endpoint = <&dwc3_role_switch_in>; >> + }; >> + }; >> + }; >> }; >> };
diff --git a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts index 1e0b6fd59abc9..b5cc45358a474 100644 --- a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts +++ b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts @@ -1273,7 +1273,13 @@ &usb_1 { }; &usb_1_dwc3 { - dr_mode = "peripheral"; + dr_mode = "otg"; + usb-role-switch; + port { + dwc3_role_switch_in: endpoint { + remote-endpoint = <&pm8150b_role_switch_out>; + }; + }; }; &usb_1_hsphy { @@ -1359,5 +1365,16 @@ connector { PDO_FIXED_DUAL_ROLE | PDO_FIXED_USB_COMM | PDO_FIXED_DATA_SWAP)>; + ports { + #address-cells = <1>; + #size-cells = <0>; + + port@0 { + reg = <0>; + pm8150b_role_switch_out: endpoint { + remote-endpoint = <&dwc3_role_switch_in>; + }; + }; + }; }; };
Switch on usb-role-switching for usb_1 via TCPM. We need to declare usb-role-switch in &usb_1 and associate with the remote-endpoint in TCPM which provides the necessary signal. Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> --- arch/arm64/boot/dts/qcom/qrb5165-rb5.dts | 19 ++++++++++++++++++- 1 file changed, 18 insertions(+), 1 deletion(-)