| Message ID | 20230417125651.25126-7-tzimmermann@suse.de |
|---|---|
| State | New |
| Headers | show |
| Series | arch: Consolidate <asm/fb.h> | expand |
Hi, On 2023/4/17 20:56, Thomas Zimmermann wrote: > Replace the architecture's fbdev helpers with the generic > ones from <asm-generic/fb.h>. No functional changes. > > v2: > * use default implementation for fb_pgprotect() (Arnd) > > Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> > Cc: Huacai Chen <chenhuacai@kernel.org> > Cc: WANG Xuerui <kernel@xen0n.name> > --- > arch/loongarch/include/asm/fb.h | 15 +-------------- > 1 file changed, 1 insertion(+), 14 deletions(-) > > diff --git a/arch/loongarch/include/asm/fb.h b/arch/loongarch/include/asm/fb.h > index 3116bde8772d..ff82f20685c8 100644 > --- a/arch/loongarch/include/asm/fb.h > +++ b/arch/loongarch/include/asm/fb.h > @@ -5,19 +5,6 @@ > #ifndef _ASM_FB_H_ > #define _ASM_FB_H_ > > -#include <linux/fb.h> > -#include <linux/fs.h> > -#include <asm/page.h> > - > -static inline void fb_pgprotect(struct file *file, struct vm_area_struct *vma, > - unsigned long off) > -{ > - vma->vm_page_prot = pgprot_writecombine(vma->vm_page_prot); > -} > - > -static inline int fb_is_primary_device(struct fb_info *info) > -{ > - return 0; > -} > +#include <asm-generic/fb.h> > > #endif /* _ASM_FB_H_ */ Sorry for the late review. The change is fairly trivial, so: Reviewed-by: WANG Xuerui <git@xen0n.name> Thanks!
diff --git a/arch/loongarch/include/asm/fb.h b/arch/loongarch/include/asm/fb.h index 3116bde8772d..ff82f20685c8 100644 --- a/arch/loongarch/include/asm/fb.h +++ b/arch/loongarch/include/asm/fb.h @@ -5,19 +5,6 @@ #ifndef _ASM_FB_H_ #define _ASM_FB_H_ -#include <linux/fb.h> -#include <linux/fs.h> -#include <asm/page.h> - -static inline void fb_pgprotect(struct file *file, struct vm_area_struct *vma, - unsigned long off) -{ - vma->vm_page_prot = pgprot_writecombine(vma->vm_page_prot); -} - -static inline int fb_is_primary_device(struct fb_info *info) -{ - return 0; -} +#include <asm-generic/fb.h> #endif /* _ASM_FB_H_ */
Replace the architecture's fbdev helpers with the generic ones from <asm-generic/fb.h>. No functional changes. v2: * use default implementation for fb_pgprotect() (Arnd) Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> Cc: Huacai Chen <chenhuacai@kernel.org> Cc: WANG Xuerui <kernel@xen0n.name> --- arch/loongarch/include/asm/fb.h | 15 +-------------- 1 file changed, 1 insertion(+), 14 deletions(-)