| Message ID | 1462894477-9931-1-git-send-email-maxim.uvarov@linaro.org |
|---|---|
| State | Accepted |
| Commit | e63a6cc10819fccbc55ec55d4585e0619463320b |
| Headers | show |
As we discussed today, I believe doc clarifications like this should be fine for RC3. Petri to confirm. On Tue, May 10, 2016 at 10:34 AM, Maxim Uvarov <maxim.uvarov@linaro.org> wrote: > System can have different sizes for huge pages. Clarify that > this api returns default system huge page size, which is usually > 2Mb on x86 reachable with: > grep Hugepagesize: /proc/meminfo > > Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org> > Reviewed-by: Bill Fischofer <bill.fischofer@linaro.org> > --- > It might be too late for current Monarch rename api calls or do some > more smart info about huge pages, so we can clarify behaviour in odp api. > > Maxim. > > include/odp/api/spec/system_info.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/odp/api/spec/system_info.h > b/include/odp/api/spec/system_info.h > index 6957731..c5a5fd0 100644 > --- a/include/odp/api/spec/system_info.h > +++ b/include/odp/api/spec/system_info.h > @@ -24,9 +24,9 @@ extern "C" { > */ > > /** > - * Huge page size in bytes > + * Default system huge page size in bytes > * > - * @return Huge page size in bytes > + * @return Default huge page size in bytes > */ > uint64_t odp_sys_huge_page_size(void); > > -- > 2.7.1.250.gff4ea60 > > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org > https://lists.linaro.org/mailman/listinfo/lng-odp >
Merged, Maxim. On 05/11/16 10:41, Savolainen, Petri (Nokia - FI/Espoo) wrote: > > Reviewed-by: Petri Savolainen <petri.savolainen@nokia.com > <mailto:petri.savolainen@nokia.com>> > > *From:*lng-odp [mailto:lng-odp-bounces@lists.linaro.org] *On Behalf Of > *Bill Fischofer > *Sent:* Wednesday, May 11, 2016 1:39 AM > *To:* Maxim Uvarov <maxim.uvarov@linaro.org> > *Cc:* LNG ODP Mailman List <lng-odp@lists.linaro.org> > *Subject:* Re: [lng-odp] [API-NEXT PATCH] api: system: specify default > huge page size > > As we discussed today, I believe doc clarifications like this should > be fine for RC3. Petri to confirm. > > On Tue, May 10, 2016 at 10:34 AM, Maxim Uvarov > <maxim.uvarov@linaro.org <mailto:maxim.uvarov@linaro.org>> wrote: > > System can have different sizes for huge pages. Clarify that > this api returns default system huge page size, which is usually > 2Mb on x86 reachable with: > grep Hugepagesize: /proc/meminfo > > Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org > <mailto:maxim.uvarov@linaro.org>> > > Reviewed-by: Bill Fischofer <bill.fischofer@linaro.org > <mailto:bill.fischofer@linaro.org>> > > --- > It might be too late for current Monarch rename api calls or do some > more smart info about huge pages, so we can clarify behaviour in > odp api. > > Maxim. > > include/odp/api/spec/system_info.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/odp/api/spec/system_info.h > b/include/odp/api/spec/system_info.h > index 6957731..c5a5fd0 100644 > --- a/include/odp/api/spec/system_info.h > +++ b/include/odp/api/spec/system_info.h > @@ -24,9 +24,9 @@ extern "C" { > */ > > /** > - * Huge page size in bytes > + * Default system huge page size in bytes > * > - * @return Huge page size in bytes > + * @return Default huge page size in bytes > */ > uint64_t odp_sys_huge_page_size(void); > > -- > 2.7.1.250.gff4ea60 > > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org <mailto:lng-odp@lists.linaro.org> > https://lists.linaro.org/mailman/listinfo/lng-odp >
diff --git a/include/odp/api/spec/system_info.h b/include/odp/api/spec/system_info.h index 6957731..c5a5fd0 100644 --- a/include/odp/api/spec/system_info.h +++ b/include/odp/api/spec/system_info.h @@ -24,9 +24,9 @@ extern "C" { */ /** - * Huge page size in bytes + * Default system huge page size in bytes * - * @return Huge page size in bytes + * @return Default huge page size in bytes */ uint64_t odp_sys_huge_page_size(void);
System can have different sizes for huge pages. Clarify that this api returns default system huge page size, which is usually 2Mb on x86 reachable with: grep Hugepagesize: /proc/meminfo Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org> --- It might be too late for current Monarch rename api calls or do some more smart info about huge pages, so we can clarify behaviour in odp api. Maxim. include/odp/api/spec/system_info.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)