| Message ID | 20230420150009.1675181-3-alex.bennee@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | tracing: remove dynamic vcpu state | expand |
On 20/4/23 17:00, Alex Bennée wrote: > While these are all in helper functions being designated vcpu events > complicates the removal of the dynamic vcpu state code. TCG plugins > allow you to instrument vcpu_[init|exit|idle]. > > Signed-off-by: Alex Bennée <alex.bennee@linaro.org> > --- > hw/core/cpu-common.c | 2 -- > trace/control-target.c | 1 - > trace/control.c | 2 -- > trace-events | 31 ------------------------------- > 4 files changed, 36 deletions(-) > > diff --git a/hw/core/cpu-common.c b/hw/core/cpu-common.c > index 5ccc3837b6..8373a500d2 100644 > --- a/hw/core/cpu-common.c > +++ b/hw/core/cpu-common.c > @@ -112,8 +112,6 @@ void cpu_dump_state(CPUState *cpu, FILE *f, int flags) > void cpu_reset(CPUState *cpu) > { > device_cold_reset(DEVICE(cpu)); > - > - trace_guest_cpu_reset(cpu); > } Can we convert this one to a "normal" trace event instead of removing it? I find it helpful in build configured without plugin.
diff --git a/hw/core/cpu-common.c b/hw/core/cpu-common.c index 5ccc3837b6..8373a500d2 100644 --- a/hw/core/cpu-common.c +++ b/hw/core/cpu-common.c @@ -112,8 +112,6 @@ void cpu_dump_state(CPUState *cpu, FILE *f, int flags) void cpu_reset(CPUState *cpu) { device_cold_reset(DEVICE(cpu)); - - trace_guest_cpu_reset(cpu); } static void cpu_common_reset_hold(Object *obj) diff --git a/trace/control-target.c b/trace/control-target.c index 232c97a4a1..c6132f243f 100644 --- a/trace/control-target.c +++ b/trace/control-target.c @@ -145,5 +145,4 @@ void trace_init_vcpu(CPUState *vcpu) } } } - trace_guest_cpu_enter(vcpu); } diff --git a/trace/control.c b/trace/control.c index 6c77cc6318..d24af91004 100644 --- a/trace/control.c +++ b/trace/control.c @@ -277,8 +277,6 @@ void trace_fini_vcpu(CPUState *vcpu) TraceEventIter iter; TraceEvent *ev; - trace_guest_cpu_exit(vcpu); - trace_event_iter_init_all(&iter); while ((ev = trace_event_iter_next(&iter)) != NULL) { if (trace_event_is_vcpu(ev) && diff --git a/trace-events b/trace-events index 691c3533e4..dd318ed1af 100644 --- a/trace-events +++ b/trace-events @@ -54,34 +54,3 @@ qmp_job_resume(void *job) "job %p" qmp_job_complete(void *job) "job %p" qmp_job_finalize(void *job) "job %p" qmp_job_dismiss(void *job) "job %p" - - -### Guest events, keep at bottom - - -## vCPU - -# trace/control-target.c - -# Hot-plug a new virtual (guest) CPU -# -# Mode: user, softmmu -# Targets: all -vcpu guest_cpu_enter(void) - -# trace/control.c - -# Hot-unplug a virtual (guest) CPU -# -# Mode: user, softmmu -# Targets: all -vcpu guest_cpu_exit(void) - -# hw/core/cpu.c - -# Reset the state of a virtual (guest) CPU -# -# Mode: user, softmmu -# Targets: all -vcpu guest_cpu_reset(void) -
While these are all in helper functions being designated vcpu events complicates the removal of the dynamic vcpu state code. TCG plugins allow you to instrument vcpu_[init|exit|idle]. Signed-off-by: Alex Bennée <alex.bennee@linaro.org> --- hw/core/cpu-common.c | 2 -- trace/control-target.c | 1 - trace/control.c | 2 -- trace-events | 31 ------------------------------- 4 files changed, 36 deletions(-)