| Message ID | 76b21a14-70ff-4ca9-927d-587543c6699c@kili.mountain |
|---|---|
| State | Accepted |
| Commit | 7b374a2fc8665bfb8a0d93b617463cc0732f533a |
| Headers | show |
| Series | soc: qcom: rmtfs: Fix error code in probe() | expand |
On 21.04.2023 12:44, Dan Carpenter wrote: > Return an error code if of_property_count_u32_elems() fails. Don't > return success. > > Fixes: e656cd0bcf3d ("soc: qcom: rmtfs: Optionally map RMTFS to more VMs") > Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad > drivers/soc/qcom/rmtfs_mem.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/soc/qcom/rmtfs_mem.c b/drivers/soc/qcom/rmtfs_mem.c > index ce48a9f3b4c8..f83811f51175 100644 > --- a/drivers/soc/qcom/rmtfs_mem.c > +++ b/drivers/soc/qcom/rmtfs_mem.c > @@ -233,6 +233,7 @@ static int qcom_rmtfs_mem_probe(struct platform_device *pdev) > num_vmids = 0; > } else if (num_vmids < 0) { > dev_err(&pdev->dev, "failed to count qcom,vmid elements: %d\n", num_vmids); > + ret = num_vmids; > goto remove_cdev; > } else if (num_vmids > NUM_MAX_VMIDS) { > dev_warn(&pdev->dev,
On Fri, 21 Apr 2023 13:44:21 +0300, Dan Carpenter wrote: > Return an error code if of_property_count_u32_elems() fails. Don't > return success. > > Applied, thanks! [1/1] soc: qcom: rmtfs: Fix error code in probe() commit: 7b374a2fc8665bfb8a0d93b617463cc0732f533a Best regards,
diff --git a/drivers/soc/qcom/rmtfs_mem.c b/drivers/soc/qcom/rmtfs_mem.c index ce48a9f3b4c8..f83811f51175 100644 --- a/drivers/soc/qcom/rmtfs_mem.c +++ b/drivers/soc/qcom/rmtfs_mem.c @@ -233,6 +233,7 @@ static int qcom_rmtfs_mem_probe(struct platform_device *pdev) num_vmids = 0; } else if (num_vmids < 0) { dev_err(&pdev->dev, "failed to count qcom,vmid elements: %d\n", num_vmids); + ret = num_vmids; goto remove_cdev; } else if (num_vmids > NUM_MAX_VMIDS) { dev_warn(&pdev->dev,
Return an error code if of_property_count_u32_elems() fails. Don't return success. Fixes: e656cd0bcf3d ("soc: qcom: rmtfs: Optionally map RMTFS to more VMs") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> --- drivers/soc/qcom/rmtfs_mem.c | 1 + 1 file changed, 1 insertion(+)