From patchwork Wed May 11 16:00:44 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ard Biesheuvel X-Patchwork-Id: 67599 Delivered-To: patch@linaro.org Received: by 10.140.92.199 with SMTP id b65csp309741qge; Wed, 11 May 2016 09:18:02 -0700 (PDT) X-Received: by 10.55.41.99 with SMTP id p96mr4579551qkh.120.1462983482796; Wed, 11 May 2016 09:18:02 -0700 (PDT) Return-Path: Received: from lists.linaro.org (lists.linaro.org. [54.225.227.206]) by mx.google.com with ESMTP id 5si5665969qht.98.2016.05.11.09.18.02; Wed, 11 May 2016 09:18:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linaro-uefi-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) client-ip=54.225.227.206; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linaro-uefi-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) smtp.mailfrom=linaro-uefi-bounces@lists.linaro.org; dmarc=pass (p=NONE dis=NONE) header.from=linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id 77DE86164C; Wed, 11 May 2016 16:18:02 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ip-10-142-244-252 X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, URIBL_BLOCKED autolearn=disabled version=3.4.0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id 3C9C161693; Wed, 11 May 2016 16:04:24 +0000 (UTC) X-Original-To: linaro-uefi@lists.linaro.org Delivered-To: linaro-uefi@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id CB96361693; Wed, 11 May 2016 16:04:19 +0000 (UTC) Received: from mail-wm0-f43.google.com (mail-wm0-f43.google.com [74.125.82.43]) by lists.linaro.org (Postfix) with ESMTPS id 17D5161655 for ; Wed, 11 May 2016 16:01:12 +0000 (UTC) Received: by mail-wm0-f43.google.com with SMTP id n129so225942145wmn.1 for ; Wed, 11 May 2016 09:01:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=15XkW4t7WECjwh6KNNorCAn6uGql7FufChuEWvn723k=; b=Q5CkIGJC9nkWJdoLuT5uWs517nrkuvWCe7NB77q3XmamuON7Av8YwburUg2I9kMZcJ fOJ41bkrrNv4pVYiai9Fbtrn1RvOqGOoeqZDZTeWRQxK8eg4da/kJ4wc19qbnG//8jWX JLIoqi03VVMOZyJsesC5j8Gji/9Rn5qk+fA57g81bJFBYllHr09C9cwRmlN1krt2kViC S9r0ssUw4ahvDazNufjdxgoCsxZNJttGeDu3omPRmHkQVNOcnnks8r2tXvDg/h1YKfN8 yHeJxQpkTjOOzerETFCUtNFhs+Hc9a/6e8TJmlE3e9JLlZ7ewwZxbtMwEp1kf6TB+tXP lteg== X-Gm-Message-State: AOPr4FWtzeO6oW5Z+ita7vJ13Jx6VZ/L6KTd/ilI7YVU4zjalC/eNWv8/jzCLm1CX/2N/9ETXLQ= X-Received: by 10.28.94.12 with SMTP id s12mr964933wmb.54.1462982471200; Wed, 11 May 2016 09:01:11 -0700 (PDT) Received: from localhost.localdomain ([195.55.142.58]) by smtp.gmail.com with ESMTPSA id f11sm36699133wmf.22.2016.05.11.09.01.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 11 May 2016 09:01:10 -0700 (PDT) From: Ard Biesheuvel To: linaro-uefi@lists.linaro.org Date: Wed, 11 May 2016 18:00:44 +0200 Message-Id: <1462982452-1316-4-git-send-email-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1462982452-1316-1-git-send-email-ard.biesheuvel@linaro.org> References: <1462982452-1316-1-git-send-email-ard.biesheuvel@linaro.org> Cc: leo.duran@amd.com Subject: [Linaro-uefi] [PATCH 03/11] Platforms/AMD/Styx/AmdStyx.dec: remove cross-package includes X-BeenThere: linaro-uefi@lists.linaro.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: linaro-uefi-bounces@lists.linaro.org Sender: "Linaro-uefi" Package .DEC files should only describe include directories that belong to the package, otherwise including one package will pull in headers from another, obfuscating the dependencies between them. For instance, as this patch shows, FdtDxe depends on ShellPkg and MdeModulePkg, so these dependencies should be made explicit rather than pulling them in via another package. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- Platforms/AMD/Styx/AmdStyx.dec | 11 +---------- Platforms/AMD/Styx/OverdriveBoard/FdtDxe/FdtDxe.inf | 2 ++ 2 files changed, 3 insertions(+), 10 deletions(-) diff --git a/Platforms/AMD/Styx/AmdStyx.dec b/Platforms/AMD/Styx/AmdStyx.dec index a01384f2421c..bba91dda6977 100644 --- a/Platforms/AMD/Styx/AmdStyx.dec +++ b/Platforms/AMD/Styx/AmdStyx.dec @@ -20,16 +20,7 @@ PACKAGE_VERSION = 0.1 [Includes] - Common - ../../../../AmdModulePkg/Common - ../../../../AmdModulePkg/Include - ../../../../ArmPkg/Include - ../../../../ArmPkg/Library - ../../../../EmbeddedPkg/Include - ../../../../IntelFrameworkPkg/Include - ../../../../MdeModulePkg/Include - ../../../../MdePkg/Include - ../../../../ShellPkg/Include + Common [LibraryClasses] diff --git a/Platforms/AMD/Styx/OverdriveBoard/FdtDxe/FdtDxe.inf b/Platforms/AMD/Styx/OverdriveBoard/FdtDxe/FdtDxe.inf index be446a5a5d71..a0b00b3c5dc8 100644 --- a/Platforms/AMD/Styx/OverdriveBoard/FdtDxe/FdtDxe.inf +++ b/Platforms/AMD/Styx/OverdriveBoard/FdtDxe/FdtDxe.inf @@ -36,8 +36,10 @@ ArmPkg/ArmPkg.dec EmbeddedPkg/EmbeddedPkg.dec MdePkg/MdePkg.dec + MdeModulePkg/MdeModulePkg.dec AmdModulePkg/AmdModulePkg.dec OpenPlatformPkg/Platforms/AMD/Styx/AmdStyx.dec + ShellPkg/ShellPkg.dec [LibraryClasses] UefiDriverEntryPoint