diff mbox series

[06/10] wifi: rtw88: fix incorrect error codes in rtw_debugfs_set_rf_write

Message ID tencent_588107D54A02EA06A1D67C6B118CC3A35805@qq.com
State Superseded
Headers show
Series [01/10] wifi: rtw88: fix incorrect error codes in rtw_debugfs_set_write_reg | expand

Commit Message

Zhang Shurong April 22, 2023, 10:04 a.m. UTC 
If there is a failure during copy_from_user or user-provided data
buffer is invalid, rtw_debugfs_set_rf_write should return negative
error code instead of a positive value count.

Fix this bug by returning correct error code.

Signed-off-by: Zhang Shurong <zhang_shurong@foxmail.com>
---
 drivers/net/wireless/realtek/rtw88/debug.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
diff mbox series

Patch

diff --git a/drivers/net/wireless/realtek/rtw88/debug.c b/drivers/net/wireless/realtek/rtw88/debug.c
index 911f0514c497..259e6c15bc78 100644
--- a/drivers/net/wireless/realtek/rtw88/debug.c
+++ b/drivers/net/wireless/realtek/rtw88/debug.c
@@ -423,14 +423,17 @@  static ssize_t rtw_debugfs_set_rf_write(struct file *filp,
 	char tmp[32 + 1];
 	u32 path, addr, mask, val;
 	int num;
+	int ret;
 
-	rtw_debugfs_copy_from_user(tmp, sizeof(tmp), buffer, count, 4);
+	ret = rtw_debugfs_copy_from_user(tmp, sizeof(tmp), buffer, count, 4);
+	if (ret < 0)
+		return ret;
 
 	num = sscanf(tmp, "%x %x %x %x", &path, &addr, &mask, &val);
 
 	if (num !=  4) {
 		rtw_warn(rtwdev, "invalid args, [path] [addr] [mask] [val]\n");
-		return count;
+		return -EINVAL;
 	}
 
 	mutex_lock(&rtwdev->mutex);