| Message ID | 20230501105832.1185477-4-bhupesh.sharma@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | [v2,1/3] arm64: dts: qcom: qrb4210-rb2: Add SD pinctrl states | expand |
On 1.05.2023 12:58, Bhupesh Sharma wrote: > Enable the aDSP and cDSP remoteproc nodes on Qualcomm QRB4210 RB2 board. > > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> > --- > arch/arm64/boot/dts/qcom/qrb4210-rb2.dts | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts b/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts > index bff6ba1d689f..3ab46499d3fa 100644 > --- a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts > +++ b/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts > @@ -34,6 +34,16 @@ &qupv3_id_0 { > status = "okay"; > }; > > +&remoteproc_adsp { > + status = "okay"; > + firmware-name = "qcom/sm6115/adsp.mdt"; status last also, don't we want to use .mbn (squashed binary)? Konrad > +}; > + > +&remoteproc_cdsp { > + status = "okay"; > + firmware-name = "qcom/sm6115/cdsp.mdt"; > +}; > + > &rpm_requests { > regulators { > compatible = "qcom,rpm-pm6125-regulators";
On Tue, 2 May 2023 at 14:58, Konrad Dybcio <konrad.dybcio@linaro.org> wrote: > > > > On 1.05.2023 12:58, Bhupesh Sharma wrote: > > Enable the aDSP and cDSP remoteproc nodes on Qualcomm QRB4210 RB2 board. > > > > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> > > --- > > arch/arm64/boot/dts/qcom/qrb4210-rb2.dts | 10 ++++++++++ > > 1 file changed, 10 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts b/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts > > index bff6ba1d689f..3ab46499d3fa 100644 > > --- a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts > > +++ b/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts > > @@ -34,6 +34,16 @@ &qupv3_id_0 { > > status = "okay"; > > }; > > > > +&remoteproc_adsp { > > + status = "okay"; > > + firmware-name = "qcom/sm6115/adsp.mdt"; > status last > also, don't we want to use .mbn (squashed binary)? Yes, please. Also, just to make sure, are sm6115 and qrb4210 binaries fully compatible? We already have a mess of sdm845 vs sda845. > > Konrad > > +}; > > + > > +&remoteproc_cdsp { > > + status = "okay"; > > + firmware-name = "qcom/sm6115/cdsp.mdt"; > > +}; > > + > > &rpm_requests { > > regulators { > > compatible = "qcom,rpm-pm6125-regulators";
On Tue, 2 May 2023 at 17:28, Konrad Dybcio <konrad.dybcio@linaro.org> wrote: > > On 1.05.2023 12:58, Bhupesh Sharma wrote: > > Enable the aDSP and cDSP remoteproc nodes on Qualcomm QRB4210 RB2 board. > > > > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> > > --- > > arch/arm64/boot/dts/qcom/qrb4210-rb2.dts | 10 ++++++++++ > > 1 file changed, 10 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts b/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts > > index bff6ba1d689f..3ab46499d3fa 100644 > > --- a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts > > +++ b/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts > > @@ -34,6 +34,16 @@ &qupv3_id_0 { > > status = "okay"; > > }; > > > > +&remoteproc_adsp { > > + status = "okay"; > > + firmware-name = "qcom/sm6115/adsp.mdt"; > status last > also, don't we want to use .mbn (squashed binary)? Ok, let me fix this in the next version. Thanks, Bhupesh
On Tue, 2 May 2023 at 17:53, Dmitry Baryshkov <dmitry.baryshkov@linaro.org> wrote: > > On Tue, 2 May 2023 at 14:58, Konrad Dybcio <konrad.dybcio@linaro.org> wrote: > > > > On 1.05.2023 12:58, Bhupesh Sharma wrote: > > > Enable the aDSP and cDSP remoteproc nodes on Qualcomm QRB4210 RB2 board. > > > > > > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> > > > --- > > > arch/arm64/boot/dts/qcom/qrb4210-rb2.dts | 10 ++++++++++ > > > 1 file changed, 10 insertions(+) > > > > > > diff --git a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts b/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts > > > index bff6ba1d689f..3ab46499d3fa 100644 > > > --- a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts > > > +++ b/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts > > > @@ -34,6 +34,16 @@ &qupv3_id_0 { > > > status = "okay"; > > > }; > > > > > > +&remoteproc_adsp { > > > + status = "okay"; > > > + firmware-name = "qcom/sm6115/adsp.mdt"; > > status last > > also, don't we want to use .mbn (squashed binary)? > > Yes, please. Also, just to make sure, are sm6115 and qrb4210 binaries > fully compatible? We already have a mess of sdm845 vs sda845. That's a fair point. Let's use qrb4210 naming instead of sm6115 here. I will send a fixed version shortly. Thanks, Bhupesh
diff --git a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts b/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts index bff6ba1d689f..3ab46499d3fa 100644 --- a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts +++ b/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts @@ -34,6 +34,16 @@ &qupv3_id_0 { status = "okay"; }; +&remoteproc_adsp { + status = "okay"; + firmware-name = "qcom/sm6115/adsp.mdt"; +}; + +&remoteproc_cdsp { + status = "okay"; + firmware-name = "qcom/sm6115/cdsp.mdt"; +}; + &rpm_requests { regulators { compatible = "qcom,rpm-pm6125-regulators";
Enable the aDSP and cDSP remoteproc nodes on Qualcomm QRB4210 RB2 board. Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> --- arch/arm64/boot/dts/qcom/qrb4210-rb2.dts | 10 ++++++++++ 1 file changed, 10 insertions(+)