| Message ID | 20230430125154.126863-2-saraday@hust.edu.cn |
|---|---|
| State | New |
| Headers | show |
| Series | [1/2] bus: qcom-ebi2: use prefix devm for clock resource allocation functions | expand |
On Sun, Apr 30, 2023 at 2:54 PM Ziliang Liao <saraday@hust.edu.cn> wrote: > The code use platform_get_resource() and devm_ioremap_resource() to > allocate memory resources for the device. It can be simplified by using > devm_platform_ioremap_resource(). > > Fixes: 335a12754808 ("bus: qcom: add EBI2 driver") It doesn't need Fixes: if it's not a bug, but who cares. Maybe the stable maintainers care. > Signed-off-by: Ziliang Liao <saraday@hust.edu.cn> > Reviewed-by: Dongliang Mu <dzm91@hust.edu.cn> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
Thanks for your advice. Do I need to delete the Fixes in [PATCH 2/2] and resend another patch set? > On Sun, Apr 30, 2023 at 2:54 PM Ziliang Liao <saraday@hust.edu.cn> wrote: > >> The code use platform_get_resource() and devm_ioremap_resource() to >> allocate memory resources for the device. It can be simplified by using >> devm_platform_ioremap_resource(). >> >> Fixes: 335a12754808 ("bus: qcom: add EBI2 driver") > It doesn't need Fixes: if it's not a bug, but who cares. Maybe > the stable maintainers care. > >> Signed-off-by: Ziliang Liao <saraday@hust.edu.cn> >> Reviewed-by: Dongliang Mu <dzm91@hust.edu.cn> > Reviewed-by: Linus Walleij <linus.walleij@linaro.org> > > Yours, > Linus Walleij
On Mon, May 8, 2023 at 6:22 PM Ziliang Liao <saraday@hust.edu.cn> wrote: > Thanks for your advice. > Do I need to delete the Fixes in [PATCH 2/2] and resend another patch set? No I think Bjorn can delete it while applying the patch. Yours, Linus Walleij
diff --git a/drivers/bus/qcom-ebi2.c b/drivers/bus/qcom-ebi2.c index 3999e969e1cf..bd419398d1c1 100644 --- a/drivers/bus/qcom-ebi2.c +++ b/drivers/bus/qcom-ebi2.c @@ -294,7 +294,6 @@ static int qcom_ebi2_probe(struct platform_device *pdev) struct device_node *np = pdev->dev.of_node; struct device_node *child; struct device *dev = &pdev->dev; - struct resource *res; void __iomem *ebi2_base; void __iomem *ebi2_xmem; struct clk *ebi2xclk; @@ -315,14 +314,12 @@ static int qcom_ebi2_probe(struct platform_device *pdev) return PTR_ERR(ebi2clk); } - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - ebi2_base = devm_ioremap_resource(dev, res); + ebi2_base = devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(ebi2_base)) { return PTR_ERR(ebi2_base); } - res = platform_get_resource(pdev, IORESOURCE_MEM, 1); - ebi2_xmem = devm_ioremap_resource(dev, res); + ebi2_xmem = devm_platform_ioremap_resource(pdev, 1); if (IS_ERR(ebi2_xmem)) { return PTR_ERR(ebi2_xmem); }
The code use platform_get_resource() and devm_ioremap_resource() to allocate memory resources for the device. It can be simplified by using devm_platform_ioremap_resource(). Fixes: 335a12754808 ("bus: qcom: add EBI2 driver") Signed-off-by: Ziliang Liao <saraday@hust.edu.cn> Reviewed-by: Dongliang Mu <dzm91@hust.edu.cn> --- drivers/bus/qcom-ebi2.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)