diff mbox series

[v2,2/2] power: supply: remove unneeded include of linux/leds.h

Message ID 20230212-include-power_supply-leds-v2-2-e9910a3f5837@weissschuh.net
State New
Headers show
Series [v2,1/2] HID: lg4ff: explicitly include linux/leds.h | expand

Commit Message

Thomas Weißschuh May 2, 2023, 4:28 a.m. UTC
Instead of including the full linux/leds.h header file a single
forward-declaration is enough.

Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
---
 include/linux/power_supply.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Sebastian Reichel May 8, 2023, 12:22 p.m. UTC | #1
Hi,

On Tue, May 02, 2023 at 06:28:45AM +0200, Thomas Weißschuh wrote:
> Instead of including the full linux/leds.h header file a single
> forward-declaration is enough.
> 
> Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
> ---

Acked-by: Sebastian Reichel <sebastian.reichel@collabora.com>

-- Sebastian

>  include/linux/power_supply.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/include/linux/power_supply.h b/include/linux/power_supply.h
> index a427f13c757f..dc5e17e8c919 100644
> --- a/include/linux/power_supply.h
> +++ b/include/linux/power_supply.h
> @@ -14,10 +14,11 @@
>  
>  #include <linux/device.h>
>  #include <linux/workqueue.h>
> -#include <linux/leds.h>
>  #include <linux/spinlock.h>
>  #include <linux/notifier.h>
>  
> +struct led_trigger;
> +
>  /*
>   * All voltages, currents, charges, energies, time and temperatures in uV,
>   * µA, µAh, µWh, seconds and tenths of degree Celsius unless otherwise
> 
> -- 
> 2.40.1
>
diff mbox series

Patch

diff --git a/include/linux/power_supply.h b/include/linux/power_supply.h
index a427f13c757f..dc5e17e8c919 100644
--- a/include/linux/power_supply.h
+++ b/include/linux/power_supply.h
@@ -14,10 +14,11 @@ 
 
 #include <linux/device.h>
 #include <linux/workqueue.h>
-#include <linux/leds.h>
 #include <linux/spinlock.h>
 #include <linux/notifier.h>
 
+struct led_trigger;
+
 /*
  * All voltages, currents, charges, energies, time and temperatures in uV,
  * µA, µAh, µWh, seconds and tenths of degree Celsius unless otherwise