diff mbox series

[09/22] hw/arm: Select e1000e for sbsa-ref machine

Message ID 20230503091244.1450613-10-alex.bennee@linaro.org
State New
Headers show
Series testing/next: cirrus, docker, docs, ci, configs, gitlab | expand

Commit Message

Alex Bennée May 3, 2023, 9:12 a.m. UTC 
From: Fabiano Rosas <farosas@suse.de>

This machine explicitly selects the e1000e network adapter if no other
option was given in the command line. Make sure e1000e is present in
the build.

Signed-off-by: Fabiano Rosas <farosas@suse.de>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20230208192654.8854-10-farosas@suse.de>
---
 hw/arm/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Richard Henderson May 3, 2023, 10:20 a.m. UTC | #1 
On 5/3/23 10:12, Alex Bennée wrote:
> From: Fabiano Rosas<farosas@suse.de>
> 
> This machine explicitly selects the e1000e network adapter if no other
> option was given in the command line. Make sure e1000e is present in
> the build.
> 
> Signed-off-by: Fabiano Rosas<farosas@suse.de>
> Signed-off-by: Alex Bennée<alex.bennee@linaro.org>
> Message-Id:<20230208192654.8854-10-farosas@suse.de>
> ---
>   hw/arm/Kconfig | 1 +
>   1 file changed, 1 insertion(+)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~
Paolo Bonzini May 3, 2023, 5:13 p.m. UTC | #2 
On 5/3/23 11:12, Alex Bennée wrote:
> From: Fabiano Rosas <farosas@suse.de>
> 
> This machine explicitly selects the e1000e network adapter if no other
> option was given in the command line. Make sure e1000e is present in
> the build.
> 
> Signed-off-by: Fabiano Rosas <farosas@suse.de>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> Message-Id: <20230208192654.8854-10-farosas@suse.de>
> ---
>   hw/arm/Kconfig | 1 +
>   1 file changed, 1 insertion(+)

This is not necessary, and patch 10 is not as well, because neither VGA 
nor a NIC are added with --nodefaults.

Paolo
diff mbox series

Patch

diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig
index 0cce0b8d5b..06f58d1a6f 100644
--- a/hw/arm/Kconfig
+++ b/hw/arm/Kconfig
@@ -253,6 +253,7 @@  config SBSA_REF
     select USB_EHCI_SYSBUS
     select WDT_SBSA
     select ARM_GICV3_TCG
+    select E1000E_PCI_EXPRESS
 
 config SABRELITE
     bool