diff mbox series

[v2,1/4] mmc: sdhci-esdhc-imx: remove unused enum cd_types

Message ID 20230506074037.522961-2-haibo.chen@nxp.com
State New
Headers show
Series cd/wp code clean up for i.MX USDHC | expand

Commit Message

Bough Chen May 6, 2023, 7:40 a.m. UTC 
From: Haibo Chen <haibo.chen@nxp.com>

enum cd_types is no more used, so remove it here.

Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
---
 drivers/mmc/host/sdhci-esdhc-imx.c | 9 ---------
 1 file changed, 9 deletions(-)

Comments

Adrian Hunter May 19, 2023, 10:37 a.m. UTC | #1 
On 6/05/23 10:40, haibo.chen@nxp.com wrote:
> From: Haibo Chen <haibo.chen@nxp.com>
> 
> enum cd_types is no more used, so remove it here.

FWIW it doesn't look like max_bus_width is being used either?

> 
> Signed-off-by: Haibo Chen <haibo.chen@nxp.com>

Nevertheless:

Acked-by: Adrian Hunter <adrian.hunter@intel.com>

> ---
>  drivers/mmc/host/sdhci-esdhc-imx.c | 9 ---------
>  1 file changed, 9 deletions(-)
> 
> diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c b/drivers/mmc/host/sdhci-esdhc-imx.c
> index eebf94604a7f..c7db742f729c 100644
> --- a/drivers/mmc/host/sdhci-esdhc-imx.c
> +++ b/drivers/mmc/host/sdhci-esdhc-imx.c
> @@ -207,25 +207,16 @@ enum wp_types {
>  	ESDHC_WP_GPIO,		/* external gpio pin for WP */
>  };
>  
> -enum cd_types {
> -	ESDHC_CD_NONE,		/* no CD, neither controller nor gpio */
> -	ESDHC_CD_CONTROLLER,	/* mmc controller internal CD */
> -	ESDHC_CD_GPIO,		/* external gpio pin for CD */
> -	ESDHC_CD_PERMANENT,	/* no CD, card permanently wired to host */
> -};
> -
>  /*
>   * struct esdhc_platform_data - platform data for esdhc on i.MX
>   *
>   * ESDHC_WP(CD)_CONTROLLER type is not available on i.MX25/35.
>   *
>   * @wp_type:	type of write_protect method (see wp_types enum above)
> - * @cd_type:	type of card_detect method (see cd_types enum above)
>   */
>  
>  struct esdhc_platform_data {
>  	enum wp_types wp_type;
> -	enum cd_types cd_type;
>  	int max_bus_width;
>  	unsigned int delay_line;
>  	unsigned int tuning_step;       /* The delay cell steps in tuning procedure */
diff mbox series

Patch

diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c b/drivers/mmc/host/sdhci-esdhc-imx.c
index eebf94604a7f..c7db742f729c 100644
--- a/drivers/mmc/host/sdhci-esdhc-imx.c
+++ b/drivers/mmc/host/sdhci-esdhc-imx.c
@@ -207,25 +207,16 @@  enum wp_types {
 	ESDHC_WP_GPIO,		/* external gpio pin for WP */
 };
 
-enum cd_types {
-	ESDHC_CD_NONE,		/* no CD, neither controller nor gpio */
-	ESDHC_CD_CONTROLLER,	/* mmc controller internal CD */
-	ESDHC_CD_GPIO,		/* external gpio pin for CD */
-	ESDHC_CD_PERMANENT,	/* no CD, card permanently wired to host */
-};
-
 /*
  * struct esdhc_platform_data - platform data for esdhc on i.MX
  *
  * ESDHC_WP(CD)_CONTROLLER type is not available on i.MX25/35.
  *
  * @wp_type:	type of write_protect method (see wp_types enum above)
- * @cd_type:	type of card_detect method (see cd_types enum above)
  */
 
 struct esdhc_platform_data {
 	enum wp_types wp_type;
-	enum cd_types cd_type;
 	int max_bus_width;
 	unsigned int delay_line;
 	unsigned int tuning_step;       /* The delay cell steps in tuning procedure */