diff mbox series

[v2,6/6] ARM: dts: qcom: apq8074-dragonboard: enable coincell charger

Message ID 20230508160446.2374438-7-dmitry.baryshkov@linaro.org
State New
Headers show
Series None | expand

Commit Message

Dmitry Baryshkov May 8, 2023, 4:04 p.m. UTC
Enable coincell charger for the coin battery which can be installed on
the APQ8074 dragonboard.

Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
 arch/arm/boot/dts/qcom-apq8074-dragonboard.dts | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Dmitry Baryshkov May 23, 2023, 11:34 p.m. UTC | #1
On 08/05/2023 19:04, Dmitry Baryshkov wrote:
> Enable coincell charger for the coin battery which can be installed on
> the APQ8074 dragonboard.
> 
> Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
>   arch/arm/boot/dts/qcom-apq8074-dragonboard.dts | 6 ++++++
>   1 file changed, 6 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/qcom-apq8074-dragonboard.dts b/arch/arm/boot/dts/qcom-apq8074-dragonboard.dts
> index 07db6451f273..93a059641957 100644
> --- a/arch/arm/boot/dts/qcom-apq8074-dragonboard.dts
> +++ b/arch/arm/boot/dts/qcom-apq8074-dragonboard.dts
> @@ -58,6 +58,12 @@ eeprom: eeprom@52 {
>   	};
>   };
>   
> +&pm8941_coincell {
> +	qcom,rset-ohms = <2100>;
> +	qcom,vset-millivolts = <3000>;
> +	status = "okay";
> +};

Ok, this one might need reconsideration. I still didn't find the lithium 
accumulator of this size and granted that it might be the battery 
instead of the accumulator, it is safer not to enable the charger, at 
least by default.

> +
>   &pm8941_gpios {
>           msm_keys_default: pm8941-gpio-keys-state {
>   		pins = "gpio5", "gpio23";
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/qcom-apq8074-dragonboard.dts b/arch/arm/boot/dts/qcom-apq8074-dragonboard.dts
index 07db6451f273..93a059641957 100644
--- a/arch/arm/boot/dts/qcom-apq8074-dragonboard.dts
+++ b/arch/arm/boot/dts/qcom-apq8074-dragonboard.dts
@@ -58,6 +58,12 @@  eeprom: eeprom@52 {
 	};
 };
 
+&pm8941_coincell {
+	qcom,rset-ohms = <2100>;
+	qcom,vset-millivolts = <3000>;
+	status = "okay";
+};
+
 &pm8941_gpios {
         msm_keys_default: pm8941-gpio-keys-state {
 		pins = "gpio5", "gpio23";