diff mbox series

[net] MAINTAINERS: exclude wireless drivers from netdev

Message ID 20230511160310.979113-1-kuba@kernel.org
State New
Headers show
Series [net] MAINTAINERS: exclude wireless drivers from netdev | expand

Commit Message

Jakub Kicinski May 11, 2023, 4:03 p.m. UTC
It seems that we mostly get netdev CCed on wireless patches
which are written by people who don't know any better and
CC everything that get_maintainers spits out. Rather than
patches which indeed could benefit from general networking
review.

Marking them down in patchwork as Awaiting Upstream is
a bit tedious.

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
CC: kvalo@kernel.org
CC: johannes@sipsolutions.net
CC: linux-wireless@vger.kernel.org

Is this okay with everyone?

It's not a big deal, but it really feels that for wireless
we only get bot/autogenerated patches to netdev..

Here's the list of patches we marked as Awaiting Upstream:
https://patchwork.kernel.org/project/netdevbpf/list/?delegate=netdev&param=-date&order=date&state=8
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

Comments

Johannes Berg May 11, 2023, 4:38 p.m. UTC | #1
On Thu, 2023-05-11 at 09:03 -0700, Jakub Kicinski wrote:
> It seems that we mostly get netdev CCed on wireless patches
> which are written by people who don't know any better and
> CC everything that get_maintainers spits out. Rather than
> patches which indeed could benefit from general networking
> review.
> 
> Marking them down in patchwork as Awaiting Upstream is
> a bit tedious.
> 
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> CC: kvalo@kernel.org
> CC: johannes@sipsolutions.net
> CC: linux-wireless@vger.kernel.org
> 
> Is this okay with everyone?
> 

Yeah, makes sense.

Acked-by: Johannes Berg <johannes@sipsolutions.net>

Are you going to take it (since you marked it 'net')?

johannes
Marcel Holtmann May 11, 2023, 4:50 p.m. UTC | #2
Hi Jakub,

> It seems that we mostly get netdev CCed on wireless patches
> which are written by people who don't know any better and
> CC everything that get_maintainers spits out. Rather than
> patches which indeed could benefit from general networking
> review.
> 
> Marking them down in patchwork as Awaiting Upstream is
> a bit tedious.
> 
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> CC: kvalo@kernel.org
> CC: johannes@sipsolutions.net
> CC: linux-wireless@vger.kernel.org
> 
> Is this okay with everyone?
> 
> It's not a big deal, but it really feels that for wireless
> we only get bot/autogenerated patches to netdev..
> 
> Here's the list of patches we marked as Awaiting Upstream:
> https://patchwork.kernel.org/project/netdevbpf/list/?delegate=netdev&param=-date&order=date&state=8
> ---
> MAINTAINERS | 1 +
> 1 file changed, 1 insertion(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 58239fbc7007..4c49f4703a18 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -14565,6 +14565,7 @@ T:	git git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git
> F:	Documentation/devicetree/bindings/net/
> F:	drivers/connector/
> F:	drivers/net/
> +X:	drivers/net/wireless/
> F:	include/dt-bindings/net/
> F:	include/linux/etherdevice.h
> F:	include/linux/fcdevice.h

I didn’t know such an option existed, can we do the same for Bluetooth?

Regards

Marcel
Jakub Kicinski May 11, 2023, 11:45 p.m. UTC | #3
On Thu, 11 May 2023 18:50:15 +0200 Marcel Holtmann wrote:
> I didn’t know such an option existed,

Same, I was looking for something unrelated in MAINTAINERS yesterday:
https://lore.kernel.org/all/20230511020204.910178-1-kuba@kernel.org/
and I noticed the X: entries in Documentation :)

> can we do the same for Bluetooth?

SG, I'll give folks a couple of days to object to this one, 
and it goes thru send a similar one for Bluetooth.
Kalle Valo May 12, 2023, 4:06 a.m. UTC | #4
Johannes Berg <johannes@sipsolutions.net> writes:

> On Thu, 2023-05-11 at 09:03 -0700, Jakub Kicinski wrote:
>> It seems that we mostly get netdev CCed on wireless patches
>> which are written by people who don't know any better and
>> CC everything that get_maintainers spits out. Rather than
>> patches which indeed could benefit from general networking
>> review.
>> 
>> Marking them down in patchwork as Awaiting Upstream is
>> a bit tedious.
>> 
>> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
>> ---
>> CC: kvalo@kernel.org
>> CC: johannes@sipsolutions.net
>> CC: linux-wireless@vger.kernel.org
>> 
>> Is this okay with everyone?
>> 
>
> Yeah, makes sense.
>
> Acked-by: Johannes Berg <johannes@sipsolutions.net>

I didn't even know about 'X', a very good idea:

Acked-by: Kalle Valo <kvalo@kernel.org>
patchwork-bot+netdevbpf@kernel.org May 12, 2023, 8 a.m. UTC | #5
Hello:

This patch was applied to netdev/net.git (main)
by David S. Miller <davem@davemloft.net>:

On Thu, 11 May 2023 09:03:10 -0700 you wrote:
> It seems that we mostly get netdev CCed on wireless patches
> which are written by people who don't know any better and
> CC everything that get_maintainers spits out. Rather than
> patches which indeed could benefit from general networking
> review.
> 
> Marking them down in patchwork as Awaiting Upstream is
> a bit tedious.
> 
> [...]

Here is the summary with links:
  - [net] MAINTAINERS: exclude wireless drivers from netdev
    https://git.kernel.org/netdev/net/c/47af4291711f

You are awesome, thank you!
diff mbox series

Patch

diff --git a/MAINTAINERS b/MAINTAINERS
index 58239fbc7007..4c49f4703a18 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -14565,6 +14565,7 @@  T:	git git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git
 F:	Documentation/devicetree/bindings/net/
 F:	drivers/connector/
 F:	drivers/net/
+X:	drivers/net/wireless/
 F:	include/dt-bindings/net/
 F:	include/linux/etherdevice.h
 F:	include/linux/fcdevice.h