| Message ID | 33c598f3655db56eed13a5b46a1468379f69349c.1683863629.git.chiaen_wu@richtek.com |
|---|---|
| State | Accepted |
| Commit | bc97139ff13598fa5becf6b582ef99ab428c03ef |
| Headers | show |
| Series | power: supply: rt9467: Fix passing zero to 'dev_err_probe' | expand |
Hi, On Fri, May 12, 2023 at 01:44:23PM +0800, ChiaEn Wu wrote: > Fix passing zero to 'dev_err_probe()' in 'rt9467_request_interrupt()' > > Fixes: 6f7f70e3a8dd ("power: supply: rt9467: Add Richtek RT9467 charger driver") > Reported-by: kernel test robot <lkp@intel.com> > Reported-by: Dan Carpenter <error27@gmail.com> > Link: https://lore.kernel.org/r/202305111228.bHLWU6bq-lkp@intel.com/ > Signed-off-by: ChiaEn Wu <chiaen_wu@richtek.com> > --- Thanks, queued to my fixes branch. -- Sebastian > drivers/power/supply/rt9467-charger.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/power/supply/rt9467-charger.c b/drivers/power/supply/rt9467-charger.c > index 73f744a..ea33693 100644 > --- a/drivers/power/supply/rt9467-charger.c > +++ b/drivers/power/supply/rt9467-charger.c > @@ -1023,7 +1023,7 @@ static int rt9467_request_interrupt(struct rt9467_chg_data *data) > for (i = 0; i < num_chg_irqs; i++) { > virq = regmap_irq_get_virq(data->irq_chip_data, chg_irqs[i].hwirq); > if (virq <= 0) > - return dev_err_probe(dev, virq, "Failed to get (%s) irq\n", > + return dev_err_probe(dev, -EINVAL, "Failed to get (%s) irq\n", > chg_irqs[i].name); > > ret = devm_request_threaded_irq(dev, virq, NULL, chg_irqs[i].handler, > -- > 2.7.4 >
diff --git a/drivers/power/supply/rt9467-charger.c b/drivers/power/supply/rt9467-charger.c index 73f744a..ea33693 100644 --- a/drivers/power/supply/rt9467-charger.c +++ b/drivers/power/supply/rt9467-charger.c @@ -1023,7 +1023,7 @@ static int rt9467_request_interrupt(struct rt9467_chg_data *data) for (i = 0; i < num_chg_irqs; i++) { virq = regmap_irq_get_virq(data->irq_chip_data, chg_irqs[i].hwirq); if (virq <= 0) - return dev_err_probe(dev, virq, "Failed to get (%s) irq\n", + return dev_err_probe(dev, -EINVAL, "Failed to get (%s) irq\n", chg_irqs[i].name); ret = devm_request_threaded_irq(dev, virq, NULL, chg_irqs[i].handler,
Fix passing zero to 'dev_err_probe()' in 'rt9467_request_interrupt()' Fixes: 6f7f70e3a8dd ("power: supply: rt9467: Add Richtek RT9467 charger driver") Reported-by: kernel test robot <lkp@intel.com> Reported-by: Dan Carpenter <error27@gmail.com> Link: https://lore.kernel.org/r/202305111228.bHLWU6bq-lkp@intel.com/ Signed-off-by: ChiaEn Wu <chiaen_wu@richtek.com> --- drivers/power/supply/rt9467-charger.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)