Message ID | 20230516195046.550584-1-arnd@kernel.org |
---|---|
State | New |
Headers | show |
Series | [1/2] ALSA: cs46xx: mark snd_cs46xx_download_image as static | expand |
On Tue, 16 May 2023 21:50:42 +0200, Arnd Bergmann wrote: > > From: Arnd Bergmann <arnd@arndb.de> > > Two functions are defined and used in pcm_oss.c but also optionally > used from io.c, with an optional prototype. If CONFIG_SND_PCM_OSS_PLUGINS > is disabled, this causes a warning as the functions are not static > and have no prototype: > > sound/core/oss/pcm_oss.c:1235:19: error: no previous prototype for 'snd_pcm_oss_write3' [-Werror=missing-prototypes] > sound/core/oss/pcm_oss.c:1266:19: error: no previous prototype for 'snd_pcm_oss_read3' [-Werror=missing-prototypes] > > Avoid this by making the prototypes unconditional. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Thanks, applied now. Takashi
diff --git a/sound/pci/cs46xx/cs46xx_lib.c b/sound/pci/cs46xx/cs46xx_lib.c index 62f45847b351..7d882b33d45e 100644 --- a/sound/pci/cs46xx/cs46xx_lib.c +++ b/sound/pci/cs46xx/cs46xx_lib.c @@ -531,7 +531,7 @@ static int load_firmware(struct snd_cs46xx *chip) return err; } -int snd_cs46xx_download_image(struct snd_cs46xx *chip) +static __maybe_unused int snd_cs46xx_download_image(struct snd_cs46xx *chip) { int idx, err; unsigned int offset = 0;