[5/8] qla2xxx: klocwork - Fix buffer overrun

Message ID	20230518075841.40363-6-njavali@marvell.com
State	Superseded
Headers	show Return-Path: <linux-scsi-owner@vger.kernel.org> From: Nilesh Javali <njavali@marvell.com> To: <martin.petersen@oracle.com> CC: <linux-scsi@vger.kernel.org>, <GR-QLogic-Storage-Upstream@marvell.com>, <bhazarika@marvell.com>, <agurumurthy@marvell.com>, <sdeodhar@marvell.com> Subject: [PATCH 5/8] qla2xxx: klocwork - Fix buffer overrun Date: Thu, 18 May 2023 13:28:38 +0530 Message-ID: <20230518075841.40363-6-njavali@marvell.com> In-Reply-To: <20230518075841.40363-1-njavali@marvell.com> References: <20230518075841.40363-1-njavali@marvell.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Precedence: bulk
Series	qla2xxx klocwork fixes \| expand [0/8] qla2xxx klocwork fixes [1/8] qla2xxx: klocwork - Array index may go out of bound [2/8] qla2xxx: klocwork - Fix potential null pointer dereference [3/8] qla2xxx: klocwork - Check for a valid fcport pointer [4/8] qla2xxx: klocwork - Check valid rport returned by fc_bsg_to_rport [5/8] qla2xxx: klocwork - Fix buffer overrun [6/8] qla2xxx: klocwork - pointer may be dereferenced [7/8] qla2xxx: klocwork - correct the index of array [8/8] qla2xxx: Update version to 10.02.08.400-k

Message ID

20230518075841.40363-6-njavali@marvell.com

State

Superseded

Headers

From: Nilesh Javali <njavali@marvell.com>
To: <martin.petersen@oracle.com>
CC: <linux-scsi@vger.kernel.org>,
        <GR-QLogic-Storage-Upstream@marvell.com>, <bhazarika@marvell.com>,
        <agurumurthy@marvell.com>, <sdeodhar@marvell.com>
Subject: [PATCH 5/8] qla2xxx: klocwork - Fix buffer overrun
Date: Thu, 18 May 2023 13:28:38 +0530
Message-ID: <20230518075841.40363-6-njavali@marvell.com>
In-Reply-To: <20230518075841.40363-1-njavali@marvell.com>
References: <20230518075841.40363-1-njavali@marvell.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk

Series

qla2xxx klocwork fixes | expand

Commit Message

Nilesh Javali May 18, 2023, 7:58 a.m. UTC

From: Quinn Tran <qutran@marvell.com>

Klocwork warning: Buffer Overflow - Array Index Out of Bounds

Driver uses fc_els_flogi to calculate size of buffer.
The actual buffer is nested inside of fc_els_flogi
which is smaller.

Replace structure name to allow proper size calculation.

Cc: stable@vger.kernel.org
Signed-off-by: Quinn Tran <qutran@marvell.com>
Signed-off-by: Nilesh Javali <njavali@marvell.com>
---
 drivers/scsi/qla2xxx/qla_init.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.c
index 0df6eae7324e..b0225f6f3221 100644
--- a/drivers/scsi/qla2xxx/qla_init.c
+++ b/drivers/scsi/qla2xxx/qla_init.c
@@ -5549,7 +5549,7 @@  static void qla_get_login_template(scsi_qla_host_t *vha)
 	__be32 *q;
 
 	memset(ha->init_cb, 0, ha->init_cb_size);
-	sz = min_t(int, sizeof(struct fc_els_flogi), ha->init_cb_size);
+	sz = min_t(int, sizeof(struct fc_els_csp), ha->init_cb_size);
 	rval = qla24xx_get_port_login_templ(vha, ha->init_cb_dma,
 					    ha->init_cb, sz);
 	if (rval != QLA_SUCCESS) {

[5/8] qla2xxx: klocwork - Fix buffer overrun

Commit Message

Patch