| Message ID | 20230524102729.810892-3-marcin.juszkiewicz@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | hw/arm/sbsa-ref: sort out graphics a bit | expand |
On 24/05/2023 12.27, Marcin Juszkiewicz wrote: > arm/sbsa-ref uses Bochs-display graphics card and without it being > present in vga_interfaces "-vga none" argument handling cannot be added. > > Signed-off-by: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org> > --- > include/sysemu/sysemu.h | 2 +- > softmmu/vl.c | 6 ++++++ > 2 files changed, 7 insertions(+), 1 deletion(-) Sorry for not noticing it earlier ... but while you're at it, please also add an entry for VGA_BOCHS to pci_vga_init(), so that other machines could benefit from this automatically, too. Thomas
On 5/24/23 03:27, Marcin Juszkiewicz wrote: > arm/sbsa-ref uses Bochs-display graphics card and without it being > present in vga_interfaces "-vga none" argument handling cannot be added. > > Signed-off-by: Marcin Juszkiewicz<marcin.juszkiewicz@linaro.org> > --- > include/sysemu/sysemu.h | 2 +- > softmmu/vl.c | 6 ++++++ > 2 files changed, 7 insertions(+), 1 deletion(-) Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~
diff --git a/include/sysemu/sysemu.h b/include/sysemu/sysemu.h index 25be2a692e..9713a1b470 100644 --- a/include/sysemu/sysemu.h +++ b/include/sysemu/sysemu.h @@ -29,7 +29,7 @@ extern int autostart; typedef enum { VGA_NONE, VGA_STD, VGA_CIRRUS, VGA_VMWARE, VGA_XENFB, VGA_QXL, - VGA_TCX, VGA_CG3, VGA_DEVICE, VGA_VIRTIO, + VGA_TCX, VGA_CG3, VGA_DEVICE, VGA_VIRTIO, VGA_BOCHS, VGA_TYPE_MAX, } VGAInterfaceType; diff --git a/softmmu/vl.c b/softmmu/vl.c index b0b96f67fa..07e6030875 100644 --- a/softmmu/vl.c +++ b/softmmu/vl.c @@ -216,6 +216,7 @@ static struct { { .driver = "ati-vga", .flag = &default_vga }, { .driver = "vhost-user-vga", .flag = &default_vga }, { .driver = "virtio-vga-gl", .flag = &default_vga }, + { .driver = "bochs-display", .flag = &default_vga }, }; static QemuOptsList qemu_rtc_opts = { @@ -935,6 +936,11 @@ static const VGAInterfaceInfo vga_interfaces[VGA_TYPE_MAX] = { .name = "CG3 framebuffer", .class_names = { "cgthree" }, }, + [VGA_BOCHS] = { + .opt_name = "bochs-display", + .name = "Bochs framebuffer", + .class_names = { "bochs-display" }, + }, #ifdef CONFIG_XEN_BACKEND [VGA_XENFB] = { .opt_name = "xenfb",
arm/sbsa-ref uses Bochs-display graphics card and without it being present in vga_interfaces "-vga none" argument handling cannot be added. Signed-off-by: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org> --- include/sysemu/sysemu.h | 2 +- softmmu/vl.c | 6 ++++++ 2 files changed, 7 insertions(+), 1 deletion(-)